* [PATCH 4/4] vti6: delete unneeded call to netdev_priv
@ 2014-05-15 3:43 Julia Lawall
2014-05-15 20:58 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Julia Lawall @ 2014-05-15 3:43 UTC (permalink / raw)
To: Steffen Klassert
Cc: kernel-janitors, Herbert Xu, David S. Miller, Alexey Kuznetsov,
James Morris, Hideaki YOSHIFUJI, Patrick McHardy, netdev,
linux-kernel
From: Julia Lawall <Julia.Lawall@lip6.fr>
Netdev_priv is an accessor function, and has no purpose if its result is
not used.
A simplified version of the semantic match that fixes this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
@@ local idexpression x; @@
-x = netdev_priv(...);
... when != x
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
net/ipv6/ip6_vti.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/net/ipv6/ip6_vti.c b/net/ipv6/ip6_vti.c
index 6cc9f93..9aaa6bb 100644
--- a/net/ipv6/ip6_vti.c
+++ b/net/ipv6/ip6_vti.c
@@ -795,15 +795,12 @@ static const struct net_device_ops vti6_netdev_ops = {
**/
static void vti6_dev_setup(struct net_device *dev)
{
- struct ip6_tnl *t;
-
dev->netdev_ops = &vti6_netdev_ops;
dev->destructor = vti6_dev_free;
dev->type = ARPHRD_TUNNEL6;
dev->hard_header_len = LL_MAX_HEADER + sizeof(struct ipv6hdr);
dev->mtu = ETH_DATA_LEN;
- t = netdev_priv(dev);
dev->flags |= IFF_NOARP;
dev->addr_len = sizeof(struct in6_addr);
dev->priv_flags &= ~IFF_XMIT_DST_RELEASE;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 4/4] vti6: delete unneeded call to netdev_priv
2014-05-15 3:43 [PATCH 4/4] vti6: delete unneeded call to netdev_priv Julia Lawall
@ 2014-05-15 20:58 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2014-05-15 20:58 UTC (permalink / raw)
To: Julia.Lawall
Cc: steffen.klassert, kernel-janitors, herbert, kuznet, jmorris,
yoshfuji, kaber, netdev, linux-kernel
From: Julia Lawall <Julia.Lawall@lip6.fr>
Date: Thu, 15 May 2014 05:43:21 +0200
> From: Julia Lawall <Julia.Lawall@lip6.fr>
>
> Netdev_priv is an accessor function, and has no purpose if its result is
> not used.
>
> A simplified version of the semantic match that fixes this problem is as
> follows: (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @@ local idexpression x; @@
> -x = netdev_priv(...);
> ... when != x
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-05-15 20:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-05-15 3:43 [PATCH 4/4] vti6: delete unneeded call to netdev_priv Julia Lawall
2014-05-15 20:58 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).