* [PATCH] mwifiex: remove unnecessary call to memset
@ 2017-09-11 12:46 Himanshu Jha
[not found] ` <1505133964-376-1-git-send-email-himanshujha199640-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Himanshu Jha @ 2017-09-11 12:46 UTC (permalink / raw)
To: amitkarwar
Cc: nishants, gbhat, huxm, kvalo, linux-wireless, netdev, Himanshu Jha
call to memset to assign 0 value immediately after allocating
memory with kzalloc is unnecesaary as kzalloc allocates the memory
filled with 0 value.
Semantic patch used to resolve this issue:
@@
expression e,e2; constant c;
statement S;
@@
e = kzalloc(e2, c);
if(e == NULL) S
- memset(e, 0, e2);
Signed-off-by: Himanshu Jha <himanshujha199640@gmail.com>
---
drivers/net/wireless/marvell/mwifiex/scan.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/wireless/marvell/mwifiex/scan.c b/drivers/net/wireless/marvell/mwifiex/scan.c
index c9d41ed..8838b88 100644
--- a/drivers/net/wireless/marvell/mwifiex/scan.c
+++ b/drivers/net/wireless/marvell/mwifiex/scan.c
@@ -1936,8 +1936,6 @@ mwifiex_active_scan_req_for_passive_chan(struct mwifiex_private *priv)
if (!user_scan_cfg)
return -ENOMEM;
- memset(user_scan_cfg, 0, sizeof(*user_scan_cfg));
-
for (id = 0; id < MWIFIEX_USER_SCAN_CHAN_MAX; id++) {
if (!priv->hidden_chan[id].chan_number)
break;
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: mwifiex: remove unnecessary call to memset
[not found] ` <1505133964-376-1-git-send-email-himanshujha199640-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
@ 2017-09-20 12:47 ` Kalle Valo
0 siblings, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2017-09-20 12:47 UTC (permalink / raw)
To: Himanshu Jha
Cc: amitkarwar-Re5JQEeQqe8AvxtiuMwx3w,
nishants-eYqpPyKDWXRBDgjK7y7TUQ, gbhat-eYqpPyKDWXRBDgjK7y7TUQ,
huxm-eYqpPyKDWXRBDgjK7y7TUQ,
linux-wireless-u79uwXL29TY76Z2rM5mHXA,
netdev-u79uwXL29TY76Z2rM5mHXA, Himanshu Jha
Himanshu Jha <himanshujha199640-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> call to memset to assign 0 value immediately after allocating
> memory with kzalloc is unnecesaary as kzalloc allocates the memory
> filled with 0 value.
>
> Semantic patch used to resolve this issue:
>
> @@
> expression e,e2; constant c;
> statement S;
> @@
>
> e = kzalloc(e2, c);
> if(e == NULL) S
> - memset(e, 0, e2);
>
> Signed-off-by: Himanshu Jha <himanshujha199640-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Patch applied to wireless-drivers-next.git, thanks.
85dafc129196 mwifiex: remove unnecessary call to memset
--
https://patchwork.kernel.org/patch/9947331/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH] mwifiex: remove unnecessary call to memset
@ 2017-09-12 1:36 Xinming Hu
0 siblings, 0 replies; 3+ messages in thread
From: Xinming Hu @ 2017-09-12 1:36 UTC (permalink / raw)
To: Himanshu Jha, amitkarwar
Cc: Nishant Sarmukadam, Ganapathi Bhat, kvalo, linux-wireless, netdev
Hi Himanshu,
> -----Original Message-----
> From: Himanshu Jha [mailto:himanshujha199640@gmail.com]
> Sent: 2017年9月11日 20:46
> To: amitkarwar@gmail.com
> Cc: Nishant Sarmukadam <nishants@marvell.com>; Ganapathi Bhat
> <gbhat@marvell.com>; Xinming Hu <huxm@marvell.com>;
> kvalo@codeaurora.org; linux-wireless@vger.kernel.org;
> netdev@vger.kernel.org; Himanshu Jha <himanshujha199640@gmail.com>
> Subject: [EXT] [PATCH] mwifiex: remove unnecessary call to memset
>
> External Email
>
> ----------------------------------------------------------------------
> call to memset to assign 0 value immediately after allocating memory with
> kzalloc is unnecesaary as kzalloc allocates the memory filled with 0 value.
>
Looks find to me, Thanks.
Regards,
Simon
> Semantic patch used to resolve this issue:
>
> @@
> expression e,e2; constant c;
> statement S;
> @@
>
> e = kzalloc(e2, c);
> if(e == NULL) S
> - memset(e, 0, e2);
>
> Signed-off-by: Himanshu Jha <himanshujha199640@gmail.com>
> ---
> drivers/net/wireless/marvell/mwifiex/scan.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/net/wireless/marvell/mwifiex/scan.c
> b/drivers/net/wireless/marvell/mwifiex/scan.c
> index c9d41ed..8838b88 100644
> --- a/drivers/net/wireless/marvell/mwifiex/scan.c
> +++ b/drivers/net/wireless/marvell/mwifiex/scan.c
> @@ -1936,8 +1936,6 @@ mwifiex_active_scan_req_for_passive_chan(struct
> mwifiex_private *priv)
> if (!user_scan_cfg)
> return -ENOMEM;
>
> - memset(user_scan_cfg, 0, sizeof(*user_scan_cfg));
> -
> for (id = 0; id < MWIFIEX_USER_SCAN_CHAN_MAX; id++) {
> if (!priv->hidden_chan[id].chan_number)
> break;
> --
> 2.7.4
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-09-20 12:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-11 12:46 [PATCH] mwifiex: remove unnecessary call to memset Himanshu Jha
[not found] ` <1505133964-376-1-git-send-email-himanshujha199640-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-09-20 12:47 ` Kalle Valo
2017-09-12 1:36 [PATCH] " Xinming Hu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).