* [PATCH net-next] net: ethernet: ti: davinci_mdio: fix build for mdio bitbang uses
@ 2022-08-24 2:42 Randy Dunlap
2022-08-24 5:07 ` [EXTERNAL] " Ravi Gunasekaran
2022-08-25 2:30 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Randy Dunlap @ 2022-08-24 2:42 UTC (permalink / raw)
To: netdev
Cc: Randy Dunlap, Grygorii Strashko, Ravi Gunasekaran, linux-omap,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Naresh Kamboju, Sudip Mukherjee
davinci_mdio.c uses mdio bitbang APIs, so it should select
MDIO_BITBANG to prevent build errors.
arm-linux-gnueabi-ld: drivers/net/ethernet/ti/davinci_mdio.o: in function `davinci_mdio_remove':
drivers/net/ethernet/ti/davinci_mdio.c:649: undefined reference to `free_mdio_bitbang'
arm-linux-gnueabi-ld: drivers/net/ethernet/ti/davinci_mdio.o: in function `davinci_mdio_probe':
drivers/net/ethernet/ti/davinci_mdio.c:545: undefined reference to `alloc_mdio_bitbang'
arm-linux-gnueabi-ld: drivers/net/ethernet/ti/davinci_mdio.o: in function `davinci_mdiobb_read':
drivers/net/ethernet/ti/davinci_mdio.c:236: undefined reference to `mdiobb_read'
arm-linux-gnueabi-ld: drivers/net/ethernet/ti/davinci_mdio.o: in function `davinci_mdiobb_write':
drivers/net/ethernet/ti/davinci_mdio.c:253: undefined reference to `mdiobb_write'
Fixes: d04807b80691 ("net: ethernet: ti: davinci_mdio: Add workaround for errata i2329")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Grygorii Strashko <grygorii.strashko@ti.com>
Cc: Ravi Gunasekaran <r-gunasekaran@ti.com>
Cc: linux-omap@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Eric Dumazet <edumazet@google.com>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Paolo Abeni <pabeni@redhat.com>
Cc: Naresh Kamboju <naresh.kamboju@linaro.org>
Cc: Sudip Mukherjee (Codethink) <sudipm.mukherjee@gmail.com>
---
drivers/net/ethernet/ti/Kconfig | 1 +
1 file changed, 1 insertion(+)
--- a/drivers/net/ethernet/ti/Kconfig
+++ b/drivers/net/ethernet/ti/Kconfig
@@ -33,6 +33,7 @@ config TI_DAVINCI_MDIO
tristate "TI DaVinci MDIO Support"
depends on ARCH_DAVINCI || ARCH_OMAP2PLUS || ARCH_KEYSTONE || ARCH_K3 || COMPILE_TEST
select PHYLIB
+ select MDIO_BITBANG
help
This driver supports TI's DaVinci MDIO module.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [EXTERNAL] [PATCH net-next] net: ethernet: ti: davinci_mdio: fix build for mdio bitbang uses
2022-08-24 2:42 [PATCH net-next] net: ethernet: ti: davinci_mdio: fix build for mdio bitbang uses Randy Dunlap
@ 2022-08-24 5:07 ` Ravi Gunasekaran
2022-08-25 2:30 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Ravi Gunasekaran @ 2022-08-24 5:07 UTC (permalink / raw)
To: Randy Dunlap, netdev
Cc: Grygorii Strashko, linux-omap, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, Naresh Kamboju, Sudip Mukherjee
Hi Randy,
On 24/08/22 8:12 am, Randy Dunlap wrote:
> davinci_mdio.c uses mdio bitbang APIs, so it should select
> MDIO_BITBANG to prevent build errors.
>
> arm-linux-gnueabi-ld: drivers/net/ethernet/ti/davinci_mdio.o: in function `davinci_mdio_remove':
> drivers/net/ethernet/ti/davinci_mdio.c:649: undefined reference to `free_mdio_bitbang'
> arm-linux-gnueabi-ld: drivers/net/ethernet/ti/davinci_mdio.o: in function `davinci_mdio_probe':
> drivers/net/ethernet/ti/davinci_mdio.c:545: undefined reference to `alloc_mdio_bitbang'
> arm-linux-gnueabi-ld: drivers/net/ethernet/ti/davinci_mdio.o: in function `davinci_mdiobb_read':
> drivers/net/ethernet/ti/davinci_mdio.c:236: undefined reference to `mdiobb_read'
> arm-linux-gnueabi-ld: drivers/net/ethernet/ti/davinci_mdio.o: in function `davinci_mdiobb_write':
> drivers/net/ethernet/ti/davinci_mdio.c:253: undefined reference to `mdiobb_write'
>
> Fixes: d04807b80691 ("net: ethernet: ti: davinci_mdio: Add workaround for errata i2329")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Grygorii Strashko <grygorii.strashko@ti.com>
> Cc: Ravi Gunasekaran <r-gunasekaran@ti.com>
> Cc: linux-omap@vger.kernel.org
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Eric Dumazet <edumazet@google.com>
> Cc: Jakub Kicinski <kuba@kernel.org>
> Cc: Paolo Abeni <pabeni@redhat.com>
> Cc: Naresh Kamboju <naresh.kamboju@linaro.org>
> Cc: Sudip Mukherjee (Codethink) <sudipm.mukherjee@gmail.com>
> ---
> drivers/net/ethernet/ti/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> --- a/drivers/net/ethernet/ti/Kconfig
> +++ b/drivers/net/ethernet/ti/Kconfig
> @@ -33,6 +33,7 @@ config TI_DAVINCI_MDIO
> tristate "TI DaVinci MDIO Support"
> depends on ARCH_DAVINCI || ARCH_OMAP2PLUS || ARCH_KEYSTONE || ARCH_K3 || COMPILE_TEST
> select PHYLIB
> + select MDIO_BITBANG
> help
> This driver supports TI's DaVinci MDIO module.
>
Thanks for posting this patch before me.
--
Regards,
Ravi
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: ethernet: ti: davinci_mdio: fix build for mdio bitbang uses
2022-08-24 2:42 [PATCH net-next] net: ethernet: ti: davinci_mdio: fix build for mdio bitbang uses Randy Dunlap
2022-08-24 5:07 ` [EXTERNAL] " Ravi Gunasekaran
@ 2022-08-25 2:30 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-08-25 2:30 UTC (permalink / raw)
To: Randy Dunlap
Cc: netdev, grygorii.strashko, r-gunasekaran, linux-omap, davem,
edumazet, kuba, pabeni, naresh.kamboju, sudipm.mukherjee
Hello:
This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@kernel.org>:
On Tue, 23 Aug 2022 19:42:16 -0700 you wrote:
> davinci_mdio.c uses mdio bitbang APIs, so it should select
> MDIO_BITBANG to prevent build errors.
>
> arm-linux-gnueabi-ld: drivers/net/ethernet/ti/davinci_mdio.o: in function `davinci_mdio_remove':
> drivers/net/ethernet/ti/davinci_mdio.c:649: undefined reference to `free_mdio_bitbang'
> arm-linux-gnueabi-ld: drivers/net/ethernet/ti/davinci_mdio.o: in function `davinci_mdio_probe':
> drivers/net/ethernet/ti/davinci_mdio.c:545: undefined reference to `alloc_mdio_bitbang'
> arm-linux-gnueabi-ld: drivers/net/ethernet/ti/davinci_mdio.o: in function `davinci_mdiobb_read':
> drivers/net/ethernet/ti/davinci_mdio.c:236: undefined reference to `mdiobb_read'
> arm-linux-gnueabi-ld: drivers/net/ethernet/ti/davinci_mdio.o: in function `davinci_mdiobb_write':
> drivers/net/ethernet/ti/davinci_mdio.c:253: undefined reference to `mdiobb_write'
>
> [...]
Here is the summary with links:
- [net-next] net: ethernet: ti: davinci_mdio: fix build for mdio bitbang uses
https://git.kernel.org/netdev/net-next/c/35bbe652c421
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-08-25 2:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-24 2:42 [PATCH net-next] net: ethernet: ti: davinci_mdio: fix build for mdio bitbang uses Randy Dunlap
2022-08-24 5:07 ` [EXTERNAL] " Ravi Gunasekaran
2022-08-25 2:30 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).