* [PATCH net] ipv4: igmp: Remove redundant comparison in igmp_mcf_get_next()
@ 2023-08-28 9:01 Gavrilov Ilia
2023-08-29 2:45 ` David Ahern
0 siblings, 1 reply; 3+ messages in thread
From: Gavrilov Ilia @ 2023-08-28 9:01 UTC (permalink / raw)
To: David S. Miller
Cc: David Ahern, Eric Dumazet, Jakub Kicinski, Paolo Abeni, netdev,
linux-kernel, lvc-project
The 'state->im' value will always be non-zero after
the 'while' statement, so the check can be removed.
Found by InfoTeCS on behalf of Linux Verification Center
(linuxtesting.org) with SVACE.
Signed-off-by: Gavrilov Ilia <Ilia.Gavrilov@infotecs.ru>
---
net/ipv4/igmp.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/net/ipv4/igmp.c b/net/ipv4/igmp.c
index 48ff5f13e797..6ebf06886527 100644
--- a/net/ipv4/igmp.c
+++ b/net/ipv4/igmp.c
@@ -2943,8 +2943,6 @@ static struct ip_sf_list *igmp_mcf_get_next(struct seq_file *seq, struct ip_sf_l
continue;
state->im = rcu_dereference(state->idev->mc_list);
}
- if (!state->im)
- break;
spin_lock_bh(&state->im->lock);
psf = state->im->sources;
}
--
2.39.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net] ipv4: igmp: Remove redundant comparison in igmp_mcf_get_next()
2023-08-28 9:01 [PATCH net] ipv4: igmp: Remove redundant comparison in igmp_mcf_get_next() Gavrilov Ilia
@ 2023-08-29 2:45 ` David Ahern
2023-08-29 6:55 ` Gavrilov Ilia
0 siblings, 1 reply; 3+ messages in thread
From: David Ahern @ 2023-08-29 2:45 UTC (permalink / raw)
To: Gavrilov Ilia, David S. Miller
Cc: Eric Dumazet, Jakub Kicinski, Paolo Abeni, netdev, linux-kernel,
lvc-project
On 8/28/23 3:01 AM, Gavrilov Ilia wrote:
> The 'state->im' value will always be non-zero after
> the 'while' statement, so the check can be removed.
>
> Found by InfoTeCS on behalf of Linux Verification Center
> (linuxtesting.org) with SVACE.
>
> Signed-off-by: Gavrilov Ilia <Ilia.Gavrilov@infotecs.ru>
> ---
> net/ipv4/igmp.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/net/ipv4/igmp.c b/net/ipv4/igmp.c
> index 48ff5f13e797..6ebf06886527 100644
> --- a/net/ipv4/igmp.c
> +++ b/net/ipv4/igmp.c
> @@ -2943,8 +2943,6 @@ static struct ip_sf_list *igmp_mcf_get_next(struct seq_file *seq, struct ip_sf_l
> continue;
> state->im = rcu_dereference(state->idev->mc_list);
> }
> - if (!state->im)
> - break;
> spin_lock_bh(&state->im->lock);
> psf = state->im->sources;
> }
Same with this one: agree the check is not needed, but I also believe it
does not need to be backported. Since net-next is closed, resubmit after
9/11.
--
pw-bot: defer
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net] ipv4: igmp: Remove redundant comparison in igmp_mcf_get_next()
2023-08-29 2:45 ` David Ahern
@ 2023-08-29 6:55 ` Gavrilov Ilia
0 siblings, 0 replies; 3+ messages in thread
From: Gavrilov Ilia @ 2023-08-29 6:55 UTC (permalink / raw)
To: David Ahern, David S. Miller
Cc: Eric Dumazet, Jakub Kicinski, Paolo Abeni, netdev, linux-kernel,
lvc-project
On 8/29/23 05:45, David Ahern wrote:
> On 8/28/23 3:01 AM, Gavrilov Ilia wrote:
>> The 'state->im' value will always be non-zero after
>> the 'while' statement, so the check can be removed.
>>
>> Found by InfoTeCS on behalf of Linux Verification Center
>> (linuxtesting.org) with SVACE.
>>
>> Signed-off-by: Gavrilov Ilia <Ilia.Gavrilov@infotecs.ru>
>> ---
>> net/ipv4/igmp.c | 2 --
>> 1 file changed, 2 deletions(-)
>>
>> diff --git a/net/ipv4/igmp.c b/net/ipv4/igmp.c
>> index 48ff5f13e797..6ebf06886527 100644
>> --- a/net/ipv4/igmp.c
>> +++ b/net/ipv4/igmp.c
>> @@ -2943,8 +2943,6 @@ static struct ip_sf_list *igmp_mcf_get_next(struct seq_file *seq, struct ip_sf_l
>> continue;
>> state->im = rcu_dereference(state->idev->mc_list);
>> }
>> - if (!state->im)
>> - break;
>> spin_lock_bh(&state->im->lock);
>> psf = state->im->sources;
>> }
>
> Same with this one: agree the check is not needed, but I also believe it
> does not need to be backported. Since net-next is closed, resubmit after
> 9/11.
>
> --
> pw-bot: defer
I'll resend it after 9/11.
Thank you for the review!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-08-29 6:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-28 9:01 [PATCH net] ipv4: igmp: Remove redundant comparison in igmp_mcf_get_next() Gavrilov Ilia
2023-08-29 2:45 ` David Ahern
2023-08-29 6:55 ` Gavrilov Ilia
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).