From: Andreas Mohr <andim2@users.sourceforge.net>
To: andi@lisas.de
Cc: rjw@sisk.pl, e1000-devel@lists.sourceforge.net,
Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: e100 kills S2R on my box, plus network drops dead
Date: Wed, 3 Jun 2009 08:30:25 +0200 [thread overview]
Message-ID: <20090603063025.GA32600@rhlx01.hs-esslingen.de> (raw)
In-Reply-To: <20090603060123.GA17558@rhlx01.hs-esslingen.de>
Hi,
On Wed, Jun 03, 2009 at 08:01:23AM +0200, Andreas Mohr wrote:
> IOW, we have _two_ issues:
>
> - that PM suspend part here doesn't support non-PM PCI cards
> - PM suspend breaks networking stuff (or is that caused by incomplete reinitialization of my card,
> thus it's not network-suitable after resume and hangs on some network APIs?)
>
> What to do?
>
> (I should have provided some SysRq-T(?) lock traces I guess, will record that now)
Those were not too useful methinks, but I can provide them if need be.
> Oh, and I will test whether eepro100 S2R works on that machine, and if
> so what that driver does to avoid trouble.
Well, yes, eepro100 (2.6.28.10) does achieve successful S2R,
and I _do_ have working network even after resume (which is not too astonishing
since it almost takes active measures to NOT make this card work,
given that it's fully auto-configuring on the transceiver side)
static int eepro100_suspend(struct pci_dev *pdev, pm_message_t state)
{
struct net_device *dev = pci_get_drvdata (pdev);
struct speedo_private *sp = netdev_priv(dev);
void __iomem *ioaddr = sp->regs;
pci_save_state(pdev);
if (!netif_running(dev))
return 0;
del_timer_sync(&sp->timer);
netif_device_detach(dev);
iowrite32(PortPartialReset, ioaddr + SCBPort);
/* XXX call pci_set_power_state ()? */
pci_disable_device(pdev);
pci_set_power_state (pdev, PCI_D3hot);
return 0;
}
That's pretty boring code, linearily executing stuff without checking
results, thus it's unsurprising that it does not prevent suspend
on a non-PM PCI card.
So, what to do to fix those suspend issues on the e100 side of things?
And do we perhaps have similar non-PM PCI card support issues
with other drivers?
Thanks,
Andreas Mohr
------------------------------------------------------------------------------
OpenSolaris 2009.06 is a cutting edge operating system for enterprises
looking to deploy the next generation of Solaris that includes the latest
innovations from Sun and the OpenSource community. Download a copy and
enjoy capabilities such as Networking, Storage and Virtualization.
Go to: http://p.sf.net/sfu/opensolaris-get
next prev parent reply other threads:[~2009-06-03 6:30 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-28 8:01 [GIT]: Networking David Miller
2008-12-29 10:25 ` Andreas Mohr
2008-12-29 17:17 ` Andrew Morton
2008-12-29 21:09 ` Johannes Berg
2008-12-30 11:05 ` Andreas Mohr
2008-12-29 23:15 ` Jeff Kirsher
2008-12-30 12:07 ` Andreas Mohr
2009-02-28 20:37 ` 2.6.29 e100.c non-MII support status? (Re: [GIT]: Networking) Andreas Mohr
2009-03-01 10:57 ` Jeff Kirsher
2009-03-01 21:24 ` Andreas Mohr
2009-06-02 21:48 ` [PATCH] Add non-MII PHY support to e100 (Re: 2.6.29 e100.c non-MII support status? (Re: [GIT]: Networking)) Andreas Mohr
2009-06-03 6:01 ` e100 kills S2R on my box, plus network drops dead Andreas Mohr
2009-06-03 6:30 ` Andreas Mohr [this message]
2009-06-13 19:19 ` [PATCH] Make e100 suspend handler support PCI cards lacking PM capability Andreas Mohr
2009-06-13 22:28 ` Rafael J. Wysocki
2009-06-13 22:45 ` Rafael J. Wysocki
2009-06-14 12:51 ` Andreas Mohr
2009-06-14 14:06 ` Rafael J. Wysocki
2009-06-14 16:31 ` Rafael J. Wysocki
2009-06-14 16:46 ` Andreas Mohr
2009-06-14 17:09 ` Rafael J. Wysocki
2009-06-14 17:20 ` Andreas Mohr
2009-06-19 8:00 ` Andreas Mohr
2009-06-14 19:46 ` [PATCH] Net / e100: Fix suspend of devices that cannot be power managed Rafael J. Wysocki
2009-06-18 2:03 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090603063025.GA32600@rhlx01.hs-esslingen.de \
--to=andim2@users.sourceforge.net \
--cc=andi@lisas.de \
--cc=e1000-devel@lists.sourceforge.net \
--cc=jeffrey.t.kirsher@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).