* [PATCH] bridge: Add missing include for in6_addr
@ 2013-04-18 9:17 Sven Eckelmann
2013-04-18 11:04 ` Sven Eckelmann
2013-04-18 17:51 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Sven Eckelmann @ 2013-04-18 9:17 UTC (permalink / raw)
To: bridge; +Cc: stephen, netdev, Sven Eckelmann
ee07c6e7a6f8a25c18f0a6b18152fbd7499245f6 ("bridge: export multicast database
via netlink") added "struct br_mdb_entry" which includes an element using the
type "struct in6_addr". The file linux/if_bridge.h is part of the uapi and not
defining this type in this file or its includes causes build failures in
userspace applications.
Signed-off-by: Sven Eckelmann <sven@open-mesh.com>
---
include/uapi/linux/if_bridge.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/uapi/linux/if_bridge.h b/include/uapi/linux/if_bridge.h
index 2d70d79..8e3f287 100644
--- a/include/uapi/linux/if_bridge.h
+++ b/include/uapi/linux/if_bridge.h
@@ -14,6 +14,7 @@
#define _UAPI_LINUX_IF_BRIDGE_H
#include <linux/types.h>
+#include <linux/in6.h>
#define SYSFS_BRIDGE_ATTR "bridge"
#define SYSFS_BRIDGE_FDB "brforward"
--
1.8.2.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] bridge: Add missing include for in6_addr
2013-04-18 9:17 [PATCH] bridge: Add missing include for in6_addr Sven Eckelmann
@ 2013-04-18 11:04 ` Sven Eckelmann
2013-04-18 17:51 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Sven Eckelmann @ 2013-04-18 11:04 UTC (permalink / raw)
To: bridge; +Cc: stephen, netdev
[-- Attachment #1: Type: text/plain, Size: 599 bytes --]
On Thursday 18 April 2013 02:17:38 Sven Eckelmann wrote:
> ee07c6e7a6f8a25c18f0a6b18152fbd7499245f6 ("bridge: export multicast database
> via netlink") added "struct br_mdb_entry" which includes an element using
> the type "struct in6_addr". The file linux/if_bridge.h is part of the uapi
> and not defining this type in this file or its includes causes build
> failures in userspace applications.
It seems this one was already dropped [1]. So, I think it will not be
different this time.
Just ignore it.
Kind regards,
Sven
[1] http://lkml.indiana.edu/hypermail/linux/kernel/1301.1/03024.html
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] bridge: Add missing include for in6_addr
2013-04-18 9:17 [PATCH] bridge: Add missing include for in6_addr Sven Eckelmann
2013-04-18 11:04 ` Sven Eckelmann
@ 2013-04-18 17:51 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2013-04-18 17:51 UTC (permalink / raw)
To: sven; +Cc: stephen, netdev, bridge
From: Sven Eckelmann <sven@open-mesh.com>
Date: Thu, 18 Apr 2013 11:17:38 +0200
> ee07c6e7a6f8a25c18f0a6b18152fbd7499245f6 ("bridge: export multicast database
> via netlink") added "struct br_mdb_entry" which includes an element using the
> type "struct in6_addr". The file linux/if_bridge.h is part of the uapi and not
> defining this type in this file or its includes causes build failures in
> userspace applications.
>
> Signed-off-by: Sven Eckelmann <sven@open-mesh.com>
This will conflict with the in6_addr defined by the libc headers, we're
screwed either way here, so we might as well require userspace to include
the libc header that defines this type.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-04-18 17:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-04-18 9:17 [PATCH] bridge: Add missing include for in6_addr Sven Eckelmann
2013-04-18 11:04 ` Sven Eckelmann
2013-04-18 17:51 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).