From: Francois Romieu <romieu@fr.zoreil.com>
To: Peter Wu <lekensteyn@gmail.com>
Cc: netdev@vger.kernel.org,
Realtek linux nic maintainers <nic_swsd@realtek.com>
Subject: Re: [r8169] About the "PHY reset until link up" warning
Date: Mon, 22 Jul 2013 23:43:58 +0200 [thread overview]
Message-ID: <20130722214358.GA4997@electric-eye.fr.zoreil.com> (raw)
In-Reply-To: <2215813.0syAhGCZsc@al>
Peter Wu <lekensteyn@gmail.com> :
[...]
> If this is a (hardware) bug workaround, can't it be restricted to that
> specific hardware or removed altogether (perhaps firmware / other updates
> fixed it already?).
It tastes of QA nightmare. It can't be proven safe easily.
Link failure sucks. If nowhere else, I'll play safe, shamanic with the phy
and I want big pesky messages when something goes unusual.
> Otherwise, what about removing this debug message?
It can be disabled with the msglvl option of ethtool.
It should stop after a few seconds if runtime power management is enabled.
I can change my mind but I haven't seen much need for a policy change yet.
--
Ueimor
next prev parent reply other threads:[~2013-07-22 21:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-22 10:42 [r8169] About the "PHY reset until link up" warning Peter Wu
2013-07-22 21:43 ` Francois Romieu [this message]
2013-07-22 21:48 ` David Miller
2013-07-22 22:45 ` Francois Romieu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130722214358.GA4997@electric-eye.fr.zoreil.com \
--to=romieu@fr.zoreil.com \
--cc=lekensteyn@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).