From: Francois Romieu <romieu@fr.zoreil.com>
To: David Miller <davem@davemloft.net>
Cc: lekensteyn@gmail.com, netdev@vger.kernel.org, nic_swsd@realtek.com
Subject: Re: [r8169] About the "PHY reset until link up" warning
Date: Tue, 23 Jul 2013 00:45:43 +0200 [thread overview]
Message-ID: <20130722224543.GA6268@electric-eye.fr.zoreil.com> (raw)
In-Reply-To: <20130722.144850.493762080108085770.davem@davemloft.net>
David Miller <davem@davemloft.net> :
> From: Francois Romieu <romieu@fr.zoreil.com>
[...]
> > I can change my mind but I haven't seen much need for a policy
> > change yet.
>
> In every case where this issue has popped up, we have decided that
> printing messages when the cable is simply unplugged is very
> undesirable.
I could agree if there had not been any progress made with runtime
power management.
> I used to print messages on link failure in all the early drivers I
> wrote, it was a bad decision.
I know something is very wrong when it repeats itself a lot in a PR.
Feel free to take any message silenting patch if someone feels it
worth.
--
Ueimor
prev parent reply other threads:[~2013-07-22 22:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-22 10:42 [r8169] About the "PHY reset until link up" warning Peter Wu
2013-07-22 21:43 ` Francois Romieu
2013-07-22 21:48 ` David Miller
2013-07-22 22:45 ` Francois Romieu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130722224543.GA6268@electric-eye.fr.zoreil.com \
--to=romieu@fr.zoreil.com \
--cc=davem@davemloft.net \
--cc=lekensteyn@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).