netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* linux-next: build failure after merge of the final tree (netnext-tree related)
@ 2013-07-29  6:25 Stephen Rothwell
  2013-07-29  7:47 ` David Miller
  0 siblings, 1 reply; 3+ messages in thread
From: Stephen Rothwell @ 2013-07-29  6:25 UTC (permalink / raw)
  To: David Miller, netdev; +Cc: linux-next, linux-kernel, Thomas Graf

[-- Attachment #1: Type: text/plain, Size: 1509 bytes --]

Hi all,

After merging the final tree, today's linux-next build (powerpc
allyesconfig) failed like this:

net/core/pktgen.c: In function 'fill_packet_ipv6':
net/core/pktgen.c:2906:3: error: implicit declaration of function 'csum_ipv6_magic' [-Werror=implicit-function-declaration]
   udph->check = ~csum_ipv6_magic(&iph->saddr, &iph->daddr, udplen, IPPROTO_UDP, 0);
   ^

Caused by commit c26bf4a51308 ("pktgen: Add UDPCSUM flag to support UDP checksums") from the net-next tree.

I added this commit:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 29 Jul 2013 16:21:26 +1000
Subject: [PATCH] pktgen: add needed include file

Fixes this on PowerPC (at least):

net/core/pktgen.c: In function 'fill_packet_ipv6':
net/core/pktgen.c:2906:3: error: implicit declaration of function 'csum_ipv6_magic' [-Werror=implicit-function-declaration]
   udph->check = ~csum_ipv6_magic(&iph->saddr, &iph->daddr, udplen, IPPROTO_UDP, 0);
   ^

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 net/core/pktgen.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/core/pktgen.c b/net/core/pktgen.c
index 2dec6f1..261357a 100644
--- a/net/core/pktgen.c
+++ b/net/core/pktgen.c
@@ -161,6 +161,7 @@
 #include <net/checksum.h>
 #include <net/ipv6.h>
 #include <net/udp.h>
+#include <net/ip6_checksum.h>
 #include <net/addrconf.h>
 #ifdef CONFIG_XFRM
 #include <net/xfrm.h>
-- 
1.8.4.rc0

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: linux-next: build failure after merge of the final tree (netnext-tree related)
  2013-07-29  6:25 linux-next: build failure after merge of the final tree (netnext-tree related) Stephen Rothwell
@ 2013-07-29  7:47 ` David Miller
  2013-07-29  8:13   ` Thomas Graf
  0 siblings, 1 reply; 3+ messages in thread
From: David Miller @ 2013-07-29  7:47 UTC (permalink / raw)
  To: sfr; +Cc: netdev, linux-next, linux-kernel, tgraf

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 29 Jul 2013 16:25:44 +1000

> After merging the final tree, today's linux-next build (powerpc
> allyesconfig) failed like this:

Sorry about that.

> I added this commit:

Applied, thanks Stephen.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: linux-next: build failure after merge of the final tree (netnext-tree related)
  2013-07-29  7:47 ` David Miller
@ 2013-07-29  8:13   ` Thomas Graf
  0 siblings, 0 replies; 3+ messages in thread
From: Thomas Graf @ 2013-07-29  8:13 UTC (permalink / raw)
  To: David Miller; +Cc: sfr, netdev, linux-next, linux-kernel

On 07/29/13 at 12:47am, David Miller wrote:
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Mon, 29 Jul 2013 16:25:44 +1000
> 
> > After merging the final tree, today's linux-next build (powerpc
> > allyesconfig) failed like this:
> 
> Sorry about that.
> 
> > I added this commit:
> 
> Applied, thanks Stephen.

Thanks for the fix-up Stephen, the include is needed on archs that
don't provide an optimized csum_ipv6_magic().

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2013-07-29  8:13 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-07-29  6:25 linux-next: build failure after merge of the final tree (netnext-tree related) Stephen Rothwell
2013-07-29  7:47 ` David Miller
2013-07-29  8:13   ` Thomas Graf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).