* No more checkpatch "fixes" from newer developers.
@ 2013-08-21 6:44 David Miller
0 siblings, 0 replies; only message in thread
From: David Miller @ 2013-08-21 6:44 UTC (permalink / raw)
To: dingtianhong; +Cc: netdev
I've really had it with "checkpatch" fixes that break things.
Case in point, the recent ipv6 checkpatch fixes did this:
/* first try to inherit the link-local address from the link device */
- if (idev->dev->iflink &&
- (link_dev = __dev_get_by_index(net, idev->dev->iflink))) {
- if (!ipv6_inherit_linklocal(idev, link_dev))
+ if (idev->dev->iflink)
+ link_dev = __dev_get_by_index(net, idev->dev->iflink);
+ if (link_dev && !ipv6_inherit_linklocal(idev, link_dev))
return;
- }
+
Are you kidding me? The openning and closing curly braces that create
the basic block were erroneously removed. Now the value of link_dev
is not defined.
I'm reverting this, and don't bother submitting these kinds of changes
any more, I'm going to ignore them.
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2013-08-21 6:44 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-08-21 6:44 No more checkpatch "fixes" from newer developers David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).