netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] drivers: ssb: Remove unused function ssb_sdio_func_to_bus() in main.c
@ 2013-12-17 12:13 Rashika Kheria
  2013-12-17 16:33 ` Josh Triplett
  0 siblings, 1 reply; 2+ messages in thread
From: Rashika Kheria @ 2013-12-17 12:13 UTC (permalink / raw)
  To: linux-kernel; +Cc: Michael Buesch, netdev, josh

Remove unused function ssb_sdio_func_to_bus() in main.c.

This eliminates the following warning in main.c:
drivers/ssb/main.c:94:17: warning: no previous prototype for ‘ssb_sdio_func_to_bus’ [-Wmissing-prototypes]

Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
---
 drivers/ssb/main.c |   19 -------------------
 1 file changed, 19 deletions(-)

diff --git a/drivers/ssb/main.c b/drivers/ssb/main.c
index 32a811d..8138952 100644
--- a/drivers/ssb/main.c
+++ b/drivers/ssb/main.c
@@ -90,25 +90,6 @@ found:
 }
 #endif /* CONFIG_SSB_PCMCIAHOST */
 
-#ifdef CONFIG_SSB_SDIOHOST
-struct ssb_bus *ssb_sdio_func_to_bus(struct sdio_func *func)
-{
-	struct ssb_bus *bus;
-
-	ssb_buses_lock();
-	list_for_each_entry(bus, &buses, list) {
-		if (bus->bustype == SSB_BUSTYPE_SDIO &&
-		    bus->host_sdio == func)
-			goto found;
-	}
-	bus = NULL;
-found:
-	ssb_buses_unlock();
-
-	return bus;
-}
-#endif /* CONFIG_SSB_SDIOHOST */
-
 int ssb_for_each_bus_call(unsigned long data,
 			  int (*func)(struct ssb_bus *bus, unsigned long data))
 {
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] drivers: ssb: Remove unused function ssb_sdio_func_to_bus() in main.c
  2013-12-17 12:13 [PATCH] drivers: ssb: Remove unused function ssb_sdio_func_to_bus() in main.c Rashika Kheria
@ 2013-12-17 16:33 ` Josh Triplett
  0 siblings, 0 replies; 2+ messages in thread
From: Josh Triplett @ 2013-12-17 16:33 UTC (permalink / raw)
  To: Rashika Kheria; +Cc: linux-kernel, Michael Buesch, netdev

On Tue, Dec 17, 2013 at 05:43:14PM +0530, Rashika Kheria wrote:
> Remove unused function ssb_sdio_func_to_bus() in main.c.
> 
> This eliminates the following warning in main.c:
> drivers/ssb/main.c:94:17: warning: no previous prototype for ‘ssb_sdio_func_to_bus’ [-Wmissing-prototypes]
> 
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>

Reviewed-by: Josh Triplett <josh@joshtriplett.org>

>  drivers/ssb/main.c |   19 -------------------
>  1 file changed, 19 deletions(-)
> 
> diff --git a/drivers/ssb/main.c b/drivers/ssb/main.c
> index 32a811d..8138952 100644
> --- a/drivers/ssb/main.c
> +++ b/drivers/ssb/main.c
> @@ -90,25 +90,6 @@ found:
>  }
>  #endif /* CONFIG_SSB_PCMCIAHOST */
>  
> -#ifdef CONFIG_SSB_SDIOHOST
> -struct ssb_bus *ssb_sdio_func_to_bus(struct sdio_func *func)
> -{
> -	struct ssb_bus *bus;
> -
> -	ssb_buses_lock();
> -	list_for_each_entry(bus, &buses, list) {
> -		if (bus->bustype == SSB_BUSTYPE_SDIO &&
> -		    bus->host_sdio == func)
> -			goto found;
> -	}
> -	bus = NULL;
> -found:
> -	ssb_buses_unlock();
> -
> -	return bus;
> -}
> -#endif /* CONFIG_SSB_SDIOHOST */
> -
>  int ssb_for_each_bus_call(unsigned long data,
>  			  int (*func)(struct ssb_bus *bus, unsigned long data))
>  {
> -- 
> 1.7.9.5
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-12-17 16:33 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-12-17 12:13 [PATCH] drivers: ssb: Remove unused function ssb_sdio_func_to_bus() in main.c Rashika Kheria
2013-12-17 16:33 ` Josh Triplett

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).