* [PATCH] xen-netback: Include header for vmalloc
@ 2014-01-05 15:24 Josh Boyer
2014-01-05 22:22 ` Wei Liu
0 siblings, 1 reply; 3+ messages in thread
From: Josh Boyer @ 2014-01-05 15:24 UTC (permalink / raw)
To: Paul Durrant, David S. Miller
Cc: netdev, ian.campbell, wei.liu2, linux-kernel
Commit ac3d5ac27735 ("xen-netback: fix guest-receive-side array sizes")
added calls to vmalloc and vfree in the interface.c file without including
<linux/vmalloc.h>. This causes build failures if the
-Werror=implicit-function-declaration flag is passed.
Signed-off-by: Josh Boyer <jwboyer@fedoraproject.org>
---
drivers/net/xen-netback/interface.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/xen-netback/interface.c b/drivers/net/xen-netback/interface.c
index 34ca4e5..fff8cdd 100644
--- a/drivers/net/xen-netback/interface.c
+++ b/drivers/net/xen-netback/interface.c
@@ -34,6 +34,7 @@
#include <linux/ethtool.h>
#include <linux/rtnetlink.h>
#include <linux/if_vlan.h>
+#include <linux/vmalloc.h>
#include <xen/events.h>
#include <asm/xen/hypercall.h>
--
1.8.4.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] xen-netback: Include header for vmalloc
2014-01-05 15:24 [PATCH] xen-netback: Include header for vmalloc Josh Boyer
@ 2014-01-05 22:22 ` Wei Liu
2014-01-06 1:35 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Wei Liu @ 2014-01-05 22:22 UTC (permalink / raw)
To: Josh Boyer
Cc: Paul Durrant, David S. Miller, netdev, ian.campbell, wei.liu2,
linux-kernel
On Sun, Jan 05, 2014 at 10:24:01AM -0500, Josh Boyer wrote:
> Commit ac3d5ac27735 ("xen-netback: fix guest-receive-side array sizes")
> added calls to vmalloc and vfree in the interface.c file without including
> <linux/vmalloc.h>. This causes build failures if the
> -Werror=implicit-function-declaration flag is passed.
>
> Signed-off-by: Josh Boyer <jwboyer@fedoraproject.org>
Acked-by: Wei Liu <wei.liu2@citrix.com>
Thanks
Wei.
> ---
> drivers/net/xen-netback/interface.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/xen-netback/interface.c b/drivers/net/xen-netback/interface.c
> index 34ca4e5..fff8cdd 100644
> --- a/drivers/net/xen-netback/interface.c
> +++ b/drivers/net/xen-netback/interface.c
> @@ -34,6 +34,7 @@
> #include <linux/ethtool.h>
> #include <linux/rtnetlink.h>
> #include <linux/if_vlan.h>
> +#include <linux/vmalloc.h>
>
> #include <xen/events.h>
> #include <asm/xen/hypercall.h>
> --
> 1.8.4.2
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] xen-netback: Include header for vmalloc
2014-01-05 22:22 ` Wei Liu
@ 2014-01-06 1:35 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2014-01-06 1:35 UTC (permalink / raw)
To: wei.liu2; +Cc: jwboyer, Paul.Durrant, netdev, ian.campbell, linux-kernel
From: Wei Liu <wei.liu2@citrix.com>
Date: Sun, 5 Jan 2014 22:22:21 +0000
> On Sun, Jan 05, 2014 at 10:24:01AM -0500, Josh Boyer wrote:
>> Commit ac3d5ac27735 ("xen-netback: fix guest-receive-side array sizes")
>> added calls to vmalloc and vfree in the interface.c file without including
>> <linux/vmalloc.h>. This causes build failures if the
>> -Werror=implicit-function-declaration flag is passed.
>>
>> Signed-off-by: Josh Boyer <jwboyer@fedoraproject.org>
>
> Acked-by: Wei Liu <wei.liu2@citrix.com>
Applied, thanks everyone.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-01-06 1:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-01-05 15:24 [PATCH] xen-netback: Include header for vmalloc Josh Boyer
2014-01-05 22:22 ` Wei Liu
2014-01-06 1:35 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).