* [PATCH] ipv6: ila: select CONFIG_DST_CACHE
@ 2018-07-18 8:48 Arnd Bergmann
2018-07-18 17:25 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2018-07-18 8:48 UTC (permalink / raw)
To: David S. Miller, Alexey Kuznetsov, Hideaki YOSHIFUJI
Cc: Arnd Bergmann, Tom Herbert, David Lebrun, Mathieu Xhonneux,
Daniel Borkmann, Yuval Mintz, Georg Hofmann, netdev,
linux-kernel
My randconfig builds came across an old missing dependency for ILA:
ERROR: "dst_cache_set_ip6" [net/ipv6/ila/ila.ko] undefined!
ERROR: "dst_cache_get" [net/ipv6/ila/ila.ko] undefined!
ERROR: "dst_cache_init" [net/ipv6/ila/ila.ko] undefined!
ERROR: "dst_cache_destroy" [net/ipv6/ila/ila.ko] undefined!
We almost never run into this by accident because randconfig builds
end up selecting DST_CACHE from some other tunnel protocol, and this
one appears to be the only one missing the explicit 'select'.
>From all I can tell, this problem first appeared in linux-4.9
when dst_cache support got added to ILA.
Fixes: 79ff2fc31e0f ("ila: Cache a route to translated address")
Cc: Tom Herbert <tom@herbertland.com>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
net/ipv6/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/ipv6/Kconfig b/net/ipv6/Kconfig
index 0eff75525da1..b3885ca22d6f 100644
--- a/net/ipv6/Kconfig
+++ b/net/ipv6/Kconfig
@@ -108,6 +108,7 @@ config IPV6_MIP6
config IPV6_ILA
tristate "IPv6: Identifier Locator Addressing (ILA)"
depends on NETFILTER
+ select DST_CACHE
select LWTUNNEL
---help---
Support for IPv6 Identifier Locator Addressing (ILA).
--
2.9.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ipv6: ila: select CONFIG_DST_CACHE
2018-07-18 8:48 [PATCH] ipv6: ila: select CONFIG_DST_CACHE Arnd Bergmann
@ 2018-07-18 17:25 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2018-07-18 17:25 UTC (permalink / raw)
To: arnd
Cc: kuznet, yoshfuji, tom, david.lebrun, m.xhonneux, daniel, yuvalm,
georg, netdev, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
Date: Wed, 18 Jul 2018 10:48:56 +0200
> My randconfig builds came across an old missing dependency for ILA:
>
> ERROR: "dst_cache_set_ip6" [net/ipv6/ila/ila.ko] undefined!
> ERROR: "dst_cache_get" [net/ipv6/ila/ila.ko] undefined!
> ERROR: "dst_cache_init" [net/ipv6/ila/ila.ko] undefined!
> ERROR: "dst_cache_destroy" [net/ipv6/ila/ila.ko] undefined!
>
> We almost never run into this by accident because randconfig builds
> end up selecting DST_CACHE from some other tunnel protocol, and this
> one appears to be the only one missing the explicit 'select'.
>
> From all I can tell, this problem first appeared in linux-4.9
> when dst_cache support got added to ILA.
>
> Fixes: 79ff2fc31e0f ("ila: Cache a route to translated address")
> Cc: Tom Herbert <tom@herbertland.com>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied, thanks Arnd.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-07-18 17:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-18 8:48 [PATCH] ipv6: ila: select CONFIG_DST_CACHE Arnd Bergmann
2018-07-18 17:25 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).