* [PATCH net-next] net: usb: rtl8150: remove set but not used variable 'rx_stat'
@ 2019-01-18 2:06 YueHaibing
2019-01-18 14:30 ` Petko Manolov
2019-01-19 18:30 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: YueHaibing @ 2019-01-18 2:06 UTC (permalink / raw)
To: Petko Manolov, David S. Miller
Cc: Yue Haibing, linux-usb, netdev, kernel-janitors
From: Yue Haibing <yuehaibing@huawei.com>
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/net/usb/rtl8150.c: In function 'read_bulk_callback':
drivers/net/usb/rtl8150.c:391:6: warning:
variable 'rx_stat' set but not used [-Wunused-but-set-variable]
Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
---
drivers/net/usb/rtl8150.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/usb/rtl8150.c b/drivers/net/usb/rtl8150.c
index 80373a9..3f145e4 100644
--- a/drivers/net/usb/rtl8150.c
+++ b/drivers/net/usb/rtl8150.c
@@ -388,7 +388,6 @@ static void read_bulk_callback(struct urb *urb)
unsigned pkt_len, res;
struct sk_buff *skb;
struct net_device *netdev;
- u16 rx_stat;
int status = urb->status;
int result;
unsigned long flags;
@@ -424,7 +423,6 @@ static void read_bulk_callback(struct urb *urb)
goto goon;
res = urb->actual_length;
- rx_stat = le16_to_cpu(*(__le16 *)(urb->transfer_buffer + res - 4));
pkt_len = res - 4;
skb_put(dev->rx_skb, pkt_len);
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: usb: rtl8150: remove set but not used variable 'rx_stat'
2019-01-18 2:06 [PATCH net-next] net: usb: rtl8150: remove set but not used variable 'rx_stat' YueHaibing
@ 2019-01-18 14:30 ` Petko Manolov
2019-01-19 18:30 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Petko Manolov @ 2019-01-18 14:30 UTC (permalink / raw)
To: YueHaibing; +Cc: David S. Miller, linux-usb, netdev, kernel-janitors
On 19-01-18 02:06:49, YueHaibing wrote:
> From: Yue Haibing <yuehaibing@huawei.com>
>
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/net/usb/rtl8150.c: In function 'read_bulk_callback':
> drivers/net/usb/rtl8150.c:391:6: warning:
> variable 'rx_stat' set but not used [-Wunused-but-set-variable]
Good catch, thanks.
Petko
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
> ---
> drivers/net/usb/rtl8150.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/net/usb/rtl8150.c b/drivers/net/usb/rtl8150.c
> index 80373a9..3f145e4 100644
> --- a/drivers/net/usb/rtl8150.c
> +++ b/drivers/net/usb/rtl8150.c
> @@ -388,7 +388,6 @@ static void read_bulk_callback(struct urb *urb)
> unsigned pkt_len, res;
> struct sk_buff *skb;
> struct net_device *netdev;
> - u16 rx_stat;
> int status = urb->status;
> int result;
> unsigned long flags;
> @@ -424,7 +423,6 @@ static void read_bulk_callback(struct urb *urb)
> goto goon;
>
> res = urb->actual_length;
> - rx_stat = le16_to_cpu(*(__le16 *)(urb->transfer_buffer + res - 4));
> pkt_len = res - 4;
>
> skb_put(dev->rx_skb, pkt_len);
>
>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: usb: rtl8150: remove set but not used variable 'rx_stat'
2019-01-18 2:06 [PATCH net-next] net: usb: rtl8150: remove set but not used variable 'rx_stat' YueHaibing
2019-01-18 14:30 ` Petko Manolov
@ 2019-01-19 18:30 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2019-01-19 18:30 UTC (permalink / raw)
To: yuehaibing; +Cc: petkan, linux-usb, netdev, kernel-janitors
From: YueHaibing <yuehaibing@huawei.com>
Date: Fri, 18 Jan 2019 02:06:49 +0000
> From: Yue Haibing <yuehaibing@huawei.com>
>
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/net/usb/rtl8150.c: In function 'read_bulk_callback':
> drivers/net/usb/rtl8150.c:391:6: warning:
> variable 'rx_stat' set but not used [-Wunused-but-set-variable]
>
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-01-19 18:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-18 2:06 [PATCH net-next] net: usb: rtl8150: remove set but not used variable 'rx_stat' YueHaibing
2019-01-18 14:30 ` Petko Manolov
2019-01-19 18:30 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).