From: Michal Kubecek <mkubecek@suse.cz>
To: netdev@vger.kernel.org
Cc: Andrew Lunn <andrew@lunn.ch>, Shannon Nelson <snelson@pensando.io>
Subject: Re: [PATCH v3 net-next 13/19] ionic: Add initial ethtool support
Date: Tue, 9 Jul 2019 07:15:01 +0200 [thread overview]
Message-ID: <20190709051501.GA16610@unicorn.suse.cz> (raw)
In-Reply-To: <20190708220406.GB17857@lunn.ch>
On Tue, Jul 09, 2019 at 12:04:06AM +0200, Andrew Lunn wrote:
> > +static int ionic_get_link_ksettings(struct net_device *netdev,
> > + struct ethtool_link_ksettings *ks)
> > +{
> > + struct lif *lif = netdev_priv(netdev);
> > + struct ionic_dev *idev = &lif->ionic->idev;
> > + int copper_seen = 0;
> > +
> > + ethtool_link_ksettings_zero_link_mode(ks, supported);
> > + ethtool_link_ksettings_zero_link_mode(ks, advertising);
> > +
> > + switch (le16_to_cpu(idev->port_info->status.xcvr.pid)) {
> > + /* Copper */
> > + case XCVR_PID_QSFP_100G_CR4:
> > + ethtool_link_ksettings_add_link_mode(ks, supported,
> > + 100000baseCR4_Full);
> > + copper_seen++;
> > + break;
> > + case XCVR_PID_QSFP_40GBASE_CR4:
> > + ethtool_link_ksettings_add_link_mode(ks, supported,
> > + 40000baseCR4_Full);
> > + copper_seen++;
> > + break;
> > + case XCVR_PID_SFP_25GBASE_CR_S:
> > + case XCVR_PID_SFP_25GBASE_CR_L:
> > + case XCVR_PID_SFP_25GBASE_CR_N:
> > + ethtool_link_ksettings_add_link_mode(ks, supported,
> > + 25000baseCR_Full);
> > + copper_seen++;
> > + break;
> > + case XCVR_PID_SFP_10GBASE_AOC:
> > + case XCVR_PID_SFP_10GBASE_CU:
> > + ethtool_link_ksettings_add_link_mode(ks, supported,
> > + 10000baseCR_Full);
> > + copper_seen++;
> > + break;
> > +
> > + /* Fibre */
> > + case XCVR_PID_QSFP_100G_SR4:
> > + case XCVR_PID_QSFP_100G_AOC:
> > + ethtool_link_ksettings_add_link_mode(ks, supported,
> > + 100000baseSR4_Full);
> > + break;
> > + case XCVR_PID_QSFP_100G_LR4:
> > + ethtool_link_ksettings_add_link_mode(ks, supported,
> > + 100000baseLR4_ER4_Full);
> > + break;
> > + case XCVR_PID_QSFP_100G_ER4:
> > + ethtool_link_ksettings_add_link_mode(ks, supported,
> > + 100000baseLR4_ER4_Full);
> > + break;
> > + case XCVR_PID_QSFP_40GBASE_SR4:
> > + case XCVR_PID_QSFP_40GBASE_AOC:
> > + ethtool_link_ksettings_add_link_mode(ks, supported,
> > + 40000baseSR4_Full);
> > + break;
> > + case XCVR_PID_QSFP_40GBASE_LR4:
> > + ethtool_link_ksettings_add_link_mode(ks, supported,
> > + 40000baseLR4_Full);
> > + break;
> > + case XCVR_PID_SFP_25GBASE_SR:
> > + case XCVR_PID_SFP_25GBASE_AOC:
> > + ethtool_link_ksettings_add_link_mode(ks, supported,
> > + 25000baseSR_Full);
> > + break;
> > + case XCVR_PID_SFP_10GBASE_SR:
> > + ethtool_link_ksettings_add_link_mode(ks, supported,
> > + 10000baseSR_Full);
> > + break;
> > + case XCVR_PID_SFP_10GBASE_LR:
> > + ethtool_link_ksettings_add_link_mode(ks, supported,
> > + 10000baseLR_Full);
> > + break;
> > + case XCVR_PID_SFP_10GBASE_LRM:
> > + ethtool_link_ksettings_add_link_mode(ks, supported,
> > + 10000baseLRM_Full);
> > + break;
> > + case XCVR_PID_SFP_10GBASE_ER:
> > + ethtool_link_ksettings_add_link_mode(ks, supported,
> > + 10000baseER_Full);
> > + break;
>
> I don't know these link modes too well. But only setting a single bit
> seems odd. What i do know is that an SFP which supports 2500BaseX
> should also be able to support 1000BaseX. So should a 100G SFP also
> support 40G, 25G, 10G etc? The SERDES just runs a slower bitstream
> over the basic bitpipe?
>
> > + case XCVR_PID_QSFP_100G_ACC:
> > + case XCVR_PID_QSFP_40GBASE_ER4:
> > + case XCVR_PID_SFP_25GBASE_LR:
> > + case XCVR_PID_SFP_25GBASE_ER:
> > + dev_info(lif->ionic->dev, "no decode bits for xcvr type pid=%d / 0x%x\n",
> > + idev->port_info->status.xcvr.pid,
> > + idev->port_info->status.xcvr.pid);
> > + break;
>
> Why not add them?
>
>
> > + memcpy(ks->link_modes.advertising, ks->link_modes.supported,
> > + sizeof(ks->link_modes.advertising));
>
> bitmap_copy() would be a better way to do this. You could consider
> adding a helper to ethtool.h.
Also, there is no need to zero initialize ks->link_modes.advertising
above if it's going to be rewritten here anyway.
Michal
next prev parent reply other threads:[~2019-07-09 5:15 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-08 19:25 [PATCH v3 net-next 00/19] Add ionic driver Shannon Nelson
2019-07-08 19:25 ` [PATCH v3 net-next 01/19] ionic: Add basic framework for IONIC Network device driver Shannon Nelson
2019-07-08 19:25 ` [PATCH v3 net-next 02/19] ionic: Add hardware init and device commands Shannon Nelson
2019-07-08 19:25 ` [PATCH v3 net-next 03/19] ionic: Add port management commands Shannon Nelson
2019-07-08 19:25 ` [PATCH v3 net-next 04/19] ionic: Add basic lif support Shannon Nelson
2019-07-08 19:25 ` [PATCH v3 net-next 05/19] ionic: Add interrupts and doorbells Shannon Nelson
2019-07-08 19:25 ` [PATCH v3 net-next 06/19] ionic: Add basic adminq support Shannon Nelson
2019-07-08 19:25 ` [PATCH v3 net-next 07/19] ionic: Add adminq action Shannon Nelson
2019-07-08 19:25 ` [PATCH v3 net-next 08/19] ionic: Add notifyq support Shannon Nelson
2019-07-08 19:25 ` [PATCH v3 net-next 09/19] ionic: Add the basic NDO callbacks for netdev support Shannon Nelson
2019-07-08 19:25 ` [PATCH v3 net-next 10/19] ionic: Add management of rx filters Shannon Nelson
2019-07-08 19:25 ` [PATCH v3 net-next 11/19] ionic: Add Rx filter and rx_mode ndo support Shannon Nelson
2019-07-08 19:25 ` [PATCH v3 net-next 12/19] ionic: Add async link status check and basic stats Shannon Nelson
2019-07-08 19:25 ` [PATCH v3 net-next 13/19] ionic: Add initial ethtool support Shannon Nelson
2019-07-08 22:04 ` Andrew Lunn
2019-07-09 5:15 ` Michal Kubecek [this message]
2019-07-09 22:35 ` Shannon Nelson
2019-07-11 19:10 ` Shannon Nelson
2019-07-09 2:14 ` Andrew Lunn
2019-07-13 5:16 ` Shannon Nelson
2019-07-18 3:28 ` Andrew Lunn
2019-07-19 0:12 ` Shannon Nelson
2019-07-19 2:40 ` Andrew Lunn
2019-07-19 18:41 ` Shannon Nelson
2019-07-19 19:07 ` Andrew Lunn
2019-07-19 20:20 ` Shannon Nelson
2019-07-09 2:27 ` Andrew Lunn
2019-07-09 22:42 ` Shannon Nelson
2019-07-18 3:21 ` Andrew Lunn
2019-07-18 17:05 ` Shannon Nelson
2019-07-18 17:28 ` Andrew Lunn
2019-07-18 17:54 ` Shannon Nelson
2019-07-09 2:30 ` Andrew Lunn
2019-07-13 5:32 ` Shannon Nelson
2019-07-18 3:31 ` Andrew Lunn
2019-07-18 17:14 ` Shannon Nelson
2019-07-09 5:25 ` Michal Kubecek
2019-07-09 22:34 ` Shannon Nelson
2019-07-08 19:25 ` [PATCH v3 net-next 14/19] ionic: Add Tx and Rx handling Shannon Nelson
2019-07-08 19:25 ` [PATCH v3 net-next 15/19] ionic: Add netdev-event handling Shannon Nelson
2019-07-08 19:25 ` [PATCH v3 net-next 16/19] ionic: Add driver stats Shannon Nelson
2019-07-08 19:25 ` [PATCH v3 net-next 17/19] ionic: Add RSS support Shannon Nelson
2019-07-08 19:25 ` [PATCH v3 net-next 18/19] ionic: Add coalesce and other features Shannon Nelson
2019-07-08 19:25 ` [PATCH v3 net-next 19/19] ionic: Add basic devlink interface Shannon Nelson
2019-07-08 19:34 ` Jiri Pirko
2019-07-08 19:58 ` Shannon Nelson
2019-07-08 20:03 ` Jiri Pirko
2019-07-08 22:58 ` Shannon Nelson
2019-07-09 6:56 ` Jiri Pirko
2019-07-09 19:13 ` Shannon Nelson
2019-07-10 6:48 ` Jiri Pirko
2019-07-10 17:06 ` Shannon Nelson
2019-07-09 1:26 ` Jakub Kicinski
2019-07-09 19:06 ` Shannon Nelson
2019-07-09 2:58 ` [PATCH v3 net-next 00/19] Add ionic driver David Miller
2019-07-09 3:01 ` Shannon Nelson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190709051501.GA16610@unicorn.suse.cz \
--to=mkubecek@suse.cz \
--cc=andrew@lunn.ch \
--cc=netdev@vger.kernel.org \
--cc=snelson@pensando.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).