* [PATCH net-next] net/ncsi: update response packet length for GCPS/GNS/GNPTS commands
@ 2019-08-21 22:08 Ben Wei
2019-08-21 22:25 ` Justin.Lee1
2019-08-23 2:28 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Ben Wei @ 2019-08-21 22:08 UTC (permalink / raw)
To: sam, davem, netdev, linux-kernel, openbmc; +Cc: Ben Wei
Update response packet length for the following commands per NC-SI spec
- Get Controller Packet Statistics
- Get NC-SI Statistics
- Get NC-SI Pass-through Statistics command
Signed-off-by: Ben Wei <benwei@fb.com>
---
net/ncsi/ncsi-rsp.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/net/ncsi/ncsi-rsp.c b/net/ncsi/ncsi-rsp.c index 7581bf919885..5254004f2b42 100644
--- a/net/ncsi/ncsi-rsp.c
+++ b/net/ncsi/ncsi-rsp.c
@@ -1083,9 +1083,9 @@ static struct ncsi_rsp_handler {
{ NCSI_PKT_RSP_GVI, 40, ncsi_rsp_handler_gvi },
{ NCSI_PKT_RSP_GC, 32, ncsi_rsp_handler_gc },
{ NCSI_PKT_RSP_GP, -1, ncsi_rsp_handler_gp },
- { NCSI_PKT_RSP_GCPS, 172, ncsi_rsp_handler_gcps },
- { NCSI_PKT_RSP_GNS, 172, ncsi_rsp_handler_gns },
- { NCSI_PKT_RSP_GNPTS, 172, ncsi_rsp_handler_gnpts },
+ { NCSI_PKT_RSP_GCPS, 204, ncsi_rsp_handler_gcps },
+ { NCSI_PKT_RSP_GNS, 32, ncsi_rsp_handler_gns },
+ { NCSI_PKT_RSP_GNPTS, 48, ncsi_rsp_handler_gnpts },
{ NCSI_PKT_RSP_GPS, 8, ncsi_rsp_handler_gps },
{ NCSI_PKT_RSP_OEM, -1, ncsi_rsp_handler_oem },
{ NCSI_PKT_RSP_PLDM, 0, NULL },
--
2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH net-next] net/ncsi: update response packet length for GCPS/GNS/GNPTS commands
2019-08-21 22:08 [PATCH net-next] net/ncsi: update response packet length for GCPS/GNS/GNPTS commands Ben Wei
@ 2019-08-21 22:25 ` Justin.Lee1
2019-08-23 2:28 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Justin.Lee1 @ 2019-08-21 22:25 UTC (permalink / raw)
To: benwei, sam, davem, netdev, linux-kernel, openbmc
Hi Ben,
Those are correct adjustment and I had tested previously.
Thanks,
Justin
Reviewed-by: Justin Lee <justin.lee1@dell.com>
> Update response packet length for the following commands per NC-SI spec
> - Get Controller Packet Statistics
> - Get NC-SI Statistics
> - Get NC-SI Pass-through Statistics command
>
> Signed-off-by: Ben Wei <benwei@fb.com>
> ---
> net/ncsi/ncsi-rsp.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/net/ncsi/ncsi-rsp.c b/net/ncsi/ncsi-rsp.c index 7581bf919885..5254004f2b42 100644
> --- a/net/ncsi/ncsi-rsp.c
> +++ b/net/ncsi/ncsi-rsp.c
> @@ -1083,9 +1083,9 @@ static struct ncsi_rsp_handler {
> { NCSI_PKT_RSP_GVI, 40, ncsi_rsp_handler_gvi },
> { NCSI_PKT_RSP_GC, 32, ncsi_rsp_handler_gc },
> { NCSI_PKT_RSP_GP, -1, ncsi_rsp_handler_gp },
> - { NCSI_PKT_RSP_GCPS, 172, ncsi_rsp_handler_gcps },
> - { NCSI_PKT_RSP_GNS, 172, ncsi_rsp_handler_gns },
> - { NCSI_PKT_RSP_GNPTS, 172, ncsi_rsp_handler_gnpts },
> + { NCSI_PKT_RSP_GCPS, 204, ncsi_rsp_handler_gcps },
> + { NCSI_PKT_RSP_GNS, 32, ncsi_rsp_handler_gns },
> + { NCSI_PKT_RSP_GNPTS, 48, ncsi_rsp_handler_gnpts },
> { NCSI_PKT_RSP_GPS, 8, ncsi_rsp_handler_gps },
> { NCSI_PKT_RSP_OEM, -1, ncsi_rsp_handler_oem },
> { NCSI_PKT_RSP_PLDM, 0, NULL },
> --
> 2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net/ncsi: update response packet length for GCPS/GNS/GNPTS commands
2019-08-21 22:08 [PATCH net-next] net/ncsi: update response packet length for GCPS/GNS/GNPTS commands Ben Wei
2019-08-21 22:25 ` Justin.Lee1
@ 2019-08-23 2:28 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2019-08-23 2:28 UTC (permalink / raw)
To: benwei; +Cc: sam, netdev, linux-kernel, openbmc
From: Ben Wei <benwei@fb.com>
Date: Wed, 21 Aug 2019 22:08:49 +0000
> Update response packet length for the following commands per NC-SI spec
> - Get Controller Packet Statistics
> - Get NC-SI Statistics
> - Get NC-SI Pass-through Statistics command
>
> Signed-off-by: Ben Wei <benwei@fb.com>
Applied, thanks Ben.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-08-23 2:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-21 22:08 [PATCH net-next] net/ncsi: update response packet length for GCPS/GNS/GNPTS commands Ben Wei
2019-08-21 22:25 ` Justin.Lee1
2019-08-23 2:28 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).