netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Vladimir Oltean <olteanv@gmail.com>
Cc: "Nishad Kamdar" <nishadkamdar@gmail.com>,
	"Vivien Didelot" <vivien.didelot@gmail.com>,
	"Florian Fainelli" <f.fainelli@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Joe Perches" <joe@perches.com>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	netdev <netdev@vger.kernel.org>,
	lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] net: dsa: sja1105: Use the correct style for SPDX License Identifier
Date: Mon, 14 Oct 2019 15:00:16 +0200	[thread overview]
Message-ID: <20191014130016.GD19861@lunn.ch> (raw)
In-Reply-To: <CA+h21hr=Wg7ydqcTLk85rrRGhx_LCxu2Ch3dWCt1-d1XtPaAcA@mail.gmail.com>

On Mon, Oct 14, 2019 at 01:46:26PM +0300, Vladimir Oltean wrote:
> Hi Nishad,
> 
> On Sat, 12 Oct 2019 at 15:39, Nishad Kamdar <nishadkamdar@gmail.com> wrote:
> >
> > This patch corrects the SPDX License Identifier style
> > in header files related to Distributed Switch Architecture
> > drivers for NXP SJA1105 series Ethernet switch support.
> > For C header files Documentation/process/license-rules.rst
> > mandates C-like comments (opposed to C source files where
> > C++ style should be used)
> >
> > Changes made by using a script provided by Joe Perches here:
> > https://lkml.org/lkml/2019/2/7/46.
> >
> > Suggested-by: Joe Perches <joe@perches.com>
> > Signed-off-by: Nishad Kamdar <nishadkamdar@gmail.com>
> > ---
> 
> Your commit message has nothing to do with what you're fixing, but
> whatever. The SPDX identifiers _are_ using C-like comments.

Agreed. Please fix the commit message, and maybe make the script
generating the commit message, so future uses of it will get the
message correct.

Thanks
	Andrew

  reply	other threads:[~2019-10-14 13:00 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-12 12:39 [PATCH] net: dsa: sja1105: Use the correct style for SPDX License Identifier Nishad Kamdar
2019-10-14 10:46 ` Vladimir Oltean
2019-10-14 13:00   ` Andrew Lunn [this message]
2019-10-14 15:36     ` Nishad Kamdar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191014130016.GD19861@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=f.fainelli@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nishadkamdar@gmail.com \
    --cc=olteanv@gmail.com \
    --cc=u.kleine-koenig@pengutronix.de \
    --cc=vivien.didelot@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).