From: Vladimir Oltean <olteanv@gmail.com>
To: Nishad Kamdar <nishadkamdar@gmail.com>
Cc: "Andrew Lunn" <andrew@lunn.ch>,
"Vivien Didelot" <vivien.didelot@gmail.com>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Joe Perches" <joe@perches.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
netdev <netdev@vger.kernel.org>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] net: dsa: sja1105: Use the correct style for SPDX License Identifier
Date: Mon, 14 Oct 2019 13:46:26 +0300 [thread overview]
Message-ID: <CA+h21hr=Wg7ydqcTLk85rrRGhx_LCxu2Ch3dWCt1-d1XtPaAcA@mail.gmail.com> (raw)
In-Reply-To: <20191012123938.GA6865@nishad>
Hi Nishad,
On Sat, 12 Oct 2019 at 15:39, Nishad Kamdar <nishadkamdar@gmail.com> wrote:
>
> This patch corrects the SPDX License Identifier style
> in header files related to Distributed Switch Architecture
> drivers for NXP SJA1105 series Ethernet switch support.
> For C header files Documentation/process/license-rules.rst
> mandates C-like comments (opposed to C source files where
> C++ style should be used)
>
> Changes made by using a script provided by Joe Perches here:
> https://lkml.org/lkml/2019/2/7/46.
>
> Suggested-by: Joe Perches <joe@perches.com>
> Signed-off-by: Nishad Kamdar <nishadkamdar@gmail.com>
> ---
Your commit message has nothing to do with what you're fixing, but
whatever. The SPDX identifiers _are_ using C-like comments.
Acked-by: Vladimir Oltean <olteanv@gmail.com>
> drivers/net/dsa/sja1105/sja1105.h | 4 ++--
> drivers/net/dsa/sja1105/sja1105_dynamic_config.h | 4 ++--
> drivers/net/dsa/sja1105/sja1105_ptp.h | 4 ++--
> drivers/net/dsa/sja1105/sja1105_static_config.h | 4 ++--
> drivers/net/dsa/sja1105/sja1105_tas.h | 4 ++--
> 5 files changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/net/dsa/sja1105/sja1105.h b/drivers/net/dsa/sja1105/sja1105.h
> index 8681ff9d1a76..fb7a6fff643f 100644
> --- a/drivers/net/dsa/sja1105/sja1105.h
> +++ b/drivers/net/dsa/sja1105/sja1105.h
> @@ -1,5 +1,5 @@
> -/* SPDX-License-Identifier: GPL-2.0
> - * Copyright (c) 2018, Sensor-Technik Wiedemann GmbH
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/* Copyright (c) 2018, Sensor-Technik Wiedemann GmbH
> * Copyright (c) 2018-2019, Vladimir Oltean <olteanv@gmail.com>
> */
> #ifndef _SJA1105_H
> diff --git a/drivers/net/dsa/sja1105/sja1105_dynamic_config.h b/drivers/net/dsa/sja1105/sja1105_dynamic_config.h
> index 740dadf43f01..4f64adb2d26a 100644
> --- a/drivers/net/dsa/sja1105/sja1105_dynamic_config.h
> +++ b/drivers/net/dsa/sja1105/sja1105_dynamic_config.h
> @@ -1,5 +1,5 @@
> -/* SPDX-License-Identifier: GPL-2.0
> - * Copyright (c) 2019, Vladimir Oltean <olteanv@gmail.com>
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/* Copyright (c) 2019, Vladimir Oltean <olteanv@gmail.com>
> */
> #ifndef _SJA1105_DYNAMIC_CONFIG_H
> #define _SJA1105_DYNAMIC_CONFIG_H
> diff --git a/drivers/net/dsa/sja1105/sja1105_ptp.h b/drivers/net/dsa/sja1105/sja1105_ptp.h
> index af456b0a4d27..c7e598fd1504 100644
> --- a/drivers/net/dsa/sja1105/sja1105_ptp.h
> +++ b/drivers/net/dsa/sja1105/sja1105_ptp.h
> @@ -1,5 +1,5 @@
> -/* SPDX-License-Identifier: GPL-2.0
> - * Copyright (c) 2019, Vladimir Oltean <olteanv@gmail.com>
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/* Copyright (c) 2019, Vladimir Oltean <olteanv@gmail.com>
> */
> #ifndef _SJA1105_PTP_H
> #define _SJA1105_PTP_H
> diff --git a/drivers/net/dsa/sja1105/sja1105_static_config.h b/drivers/net/dsa/sja1105/sja1105_static_config.h
> index 7f87022a2d61..ee66fae6128b 100644
> --- a/drivers/net/dsa/sja1105/sja1105_static_config.h
> +++ b/drivers/net/dsa/sja1105/sja1105_static_config.h
> @@ -1,5 +1,5 @@
> -/* SPDX-License-Identifier: BSD-3-Clause
> - * Copyright (c) 2016-2018, NXP Semiconductors
> +/* SPDX-License-Identifier: BSD-3-Clause */
> +/* Copyright (c) 2016-2018, NXP Semiconductors
> * Copyright (c) 2018-2019, Vladimir Oltean <olteanv@gmail.com>
> */
> #ifndef _SJA1105_STATIC_CONFIG_H
> diff --git a/drivers/net/dsa/sja1105/sja1105_tas.h b/drivers/net/dsa/sja1105/sja1105_tas.h
> index 0b803c30e640..c3ea7be52b9c 100644
> --- a/drivers/net/dsa/sja1105/sja1105_tas.h
> +++ b/drivers/net/dsa/sja1105/sja1105_tas.h
> @@ -1,5 +1,5 @@
> -/* SPDX-License-Identifier: GPL-2.0
> - * Copyright (c) 2019, Vladimir Oltean <olteanv@gmail.com>
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/* Copyright (c) 2019, Vladimir Oltean <olteanv@gmail.com>
> */
> #ifndef _SJA1105_TAS_H
> #define _SJA1105_TAS_H
> --
> 2.17.1
>
next prev parent reply other threads:[~2019-10-14 10:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-12 12:39 [PATCH] net: dsa: sja1105: Use the correct style for SPDX License Identifier Nishad Kamdar
2019-10-14 10:46 ` Vladimir Oltean [this message]
2019-10-14 13:00 ` Andrew Lunn
2019-10-14 15:36 ` Nishad Kamdar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+h21hr=Wg7ydqcTLk85rrRGhx_LCxu2Ch3dWCt1-d1XtPaAcA@mail.gmail.com' \
--to=olteanv@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nishadkamdar@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).