* [PATCH] net: add missing semicolon in net_dev_template
@ 2019-11-11 14:17 Tony Lu
2019-11-11 23:12 ` Steven Rostedt
0 siblings, 1 reply; 3+ messages in thread
From: Tony Lu @ 2019-11-11 14:17 UTC (permalink / raw)
To: rostedt, mingo; +Cc: sanagi.koki, davem, netdev, linux-kernel
This patch adds missing semicolon in the end of net_dev_template.
Fixes: cf66ba58b5cb ("netdev: Add tracepoints to netdev layer")
Signed-off-by: Tony Lu <tonylu@linux.alibaba.com>
---
include/trace/events/net.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/trace/events/net.h b/include/trace/events/net.h
index 2399073c3afc..3b28843652d2 100644
--- a/include/trace/events/net.h
+++ b/include/trace/events/net.h
@@ -138,7 +138,7 @@ DECLARE_EVENT_CLASS(net_dev_template,
TP_printk("dev=%s skbaddr=%p len=%u",
__get_str(name), __entry->skbaddr, __entry->len)
-)
+);
DEFINE_EVENT(net_dev_template, net_dev_queue,
--
2.24.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] net: add missing semicolon in net_dev_template
2019-11-11 14:17 [PATCH] net: add missing semicolon in net_dev_template Tony Lu
@ 2019-11-11 23:12 ` Steven Rostedt
2019-11-12 7:01 ` Tony Lu
0 siblings, 1 reply; 3+ messages in thread
From: Steven Rostedt @ 2019-11-11 23:12 UTC (permalink / raw)
To: Tony Lu
Cc: mingo, sanagi.koki, davem, netdev, linux-kernel, Mathieu Desnoyers
On Mon, 11 Nov 2019 22:17:53 +0800
Tony Lu <tonylu@linux.alibaba.com> wrote:
> This patch adds missing semicolon in the end of net_dev_template.
>
> Fixes: cf66ba58b5cb ("netdev: Add tracepoints to netdev layer")
> Signed-off-by: Tony Lu <tonylu@linux.alibaba.com>
> ---
> include/trace/events/net.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/trace/events/net.h b/include/trace/events/net.h
> index 2399073c3afc..3b28843652d2 100644
> --- a/include/trace/events/net.h
> +++ b/include/trace/events/net.h
> @@ -138,7 +138,7 @@ DECLARE_EVENT_CLASS(net_dev_template,
>
> TP_printk("dev=%s skbaddr=%p len=%u",
> __get_str(name), __entry->skbaddr, __entry->len)
> -)
> +);
Actually, we are thinking of making a sweeping patch set to remove all
these semicolons, as they are not needed, and would also allow more
flexible processing of the trace event macros.
-- Steve
>
> DEFINE_EVENT(net_dev_template, net_dev_queue,
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net: add missing semicolon in net_dev_template
2019-11-11 23:12 ` Steven Rostedt
@ 2019-11-12 7:01 ` Tony Lu
0 siblings, 0 replies; 3+ messages in thread
From: Tony Lu @ 2019-11-12 7:01 UTC (permalink / raw)
To: Steven Rostedt
Cc: mingo, sanagi.koki, davem, netdev, linux-kernel, Mathieu Desnoyers
On Mon, Nov 11, 2019 at 06:12:28PM -0500, Steven Rostedt wrote:
> On Mon, 11 Nov 2019 22:17:53 +0800
> Tony Lu <tonylu@linux.alibaba.com> wrote:
>
> > This patch adds missing semicolon in the end of net_dev_template.
> >
> > Fixes: cf66ba58b5cb ("netdev: Add tracepoints to netdev layer")
> > Signed-off-by: Tony Lu <tonylu@linux.alibaba.com>
> > ---
> > include/trace/events/net.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/include/trace/events/net.h b/include/trace/events/net.h
> > index 2399073c3afc..3b28843652d2 100644
> > --- a/include/trace/events/net.h
> > +++ b/include/trace/events/net.h
> > @@ -138,7 +138,7 @@ DECLARE_EVENT_CLASS(net_dev_template,
> >
> > TP_printk("dev=%s skbaddr=%p len=%u",
> > __get_str(name), __entry->skbaddr, __entry->len)
> > -)
> > +);
>
> Actually, we are thinking of making a sweeping patch set to remove all
> these semicolons, as they are not needed, and would also allow more
> flexible processing of the trace event macros.
>
> -- Steve
Thanks for your reply, it's great to take actions to sweep them for a
unified code style. I just found a different place in the code :-)
Cheers
Tony Lu
>
> >
> > DEFINE_EVENT(net_dev_template, net_dev_queue,
> >
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-11-12 7:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-11 14:17 [PATCH] net: add missing semicolon in net_dev_template Tony Lu
2019-11-11 23:12 ` Steven Rostedt
2019-11-12 7:01 ` Tony Lu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).