From: Andrew Lunn <andrew@lunn.ch>
To: Vladimir Oltean <olteanv@gmail.com>
Cc: f.fainelli@gmail.com, vivien.didelot@gmail.com,
davem@davemloft.net, jakub.kicinski@netronome.com,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next 1/3] net: dsa: Configure the MTU for switch ports
Date: Sun, 24 Nov 2019 23:48:27 +0100 [thread overview]
Message-ID: <20191124224827.GD6009@lunn.ch> (raw)
In-Reply-To: <20191123194844.9508-2-olteanv@gmail.com>
> The CPU port is called with an MTU equal to the largest configured MTU
> of the slave ports. The assumption is that the user might want to
> sustain a bidirectional conversation with a partner over any switch
> port.
There is an assumption here that the MTU is enforced before the DSA
header is applied on the egress patch. And MRU is also applied once
the header is removed on ingress. I've no idea if this is true for
all the switches we support in DSA.
We should clearly document that if the switch need the header to be
included, the function to set the MTU needs to add it.
Andrew
next prev parent reply other threads:[~2019-11-24 22:48 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-23 19:48 [PATCH net-next 0/3] Configure the MTU on DSA switches Vladimir Oltean
2019-11-23 19:48 ` [PATCH net-next 1/3] net: dsa: Configure the MTU for switch ports Vladimir Oltean
2019-11-23 20:27 ` Florian Fainelli
2019-11-23 20:46 ` Vladimir Oltean
2019-11-23 21:14 ` Florian Fainelli
2019-11-23 21:29 ` Vladimir Oltean
2019-11-23 21:47 ` Florian Fainelli
2019-11-23 21:54 ` Vladimir Oltean
2019-11-24 22:43 ` Andrew Lunn
2019-11-23 20:51 ` Vladimir Oltean
2019-11-23 21:09 ` Florian Fainelli
2019-11-24 22:48 ` Andrew Lunn [this message]
2019-11-23 19:48 ` [PATCH net-next 2/3] net: dsa: sja1105: Implement the port MTU callbacks Vladimir Oltean
2019-11-23 20:30 ` Florian Fainelli
2019-11-23 20:48 ` Vladimir Oltean
2019-11-23 19:48 ` [PATCH net-next 3/3] net: dsa: vsc73xx: Make the MTU configurable Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191124224827.GD6009@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=jakub.kicinski@netronome.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).