* [PATCH 1/2] net: ethernet: stmmac: demote warnings about missing optional clocks
@ 2020-02-24 17:29 Ahmad Fatoum
2020-02-24 17:29 ` [PATCH 2/2] net: ethernet: stmmac: don't warn about missing optional wakeup IRQ Ahmad Fatoum
2020-02-24 23:39 ` [PATCH 1/2] net: ethernet: stmmac: demote warnings about missing optional clocks David Miller
0 siblings, 2 replies; 4+ messages in thread
From: Ahmad Fatoum @ 2020-02-24 17:29 UTC (permalink / raw)
To: Giuseppe Cavallaro, Alexandre Torgue, Jose Abreu, Maxime Coquelin
Cc: kernel, Ahmad Fatoum, David S. Miller, netdev, linux-stm32,
linux-arm-kernel, linux-kernel
The specification of a "eth-ck" and a "ptp_ref" clock is optional per
the binding and the driver handles them gracefully.
Demote the output to an info message accordingly.
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
drivers/net/ethernet/stmicro/stmmac/dwmac-stm32.c | 2 +-
drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-stm32.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-stm32.c
index 9b7be996d07b..dc84e5066bf8 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac-stm32.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-stm32.c
@@ -304,7 +304,7 @@ static int stm32mp1_parse_data(struct stm32_dwmac *dwmac,
/* Get ETH_CLK clocks */
dwmac->clk_eth_ck = devm_clk_get(dev, "eth-ck");
if (IS_ERR(dwmac->clk_eth_ck)) {
- dev_warn(dev, "No phy clock provided...\n");
+ dev_info(dev, "No phy clock provided...\n");
dwmac->clk_eth_ck = NULL;
}
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
index d10ac54bf385..165958c9f069 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
@@ -588,7 +588,7 @@ stmmac_probe_config_dt(struct platform_device *pdev, const char **mac)
if (IS_ERR(plat->clk_ptp_ref)) {
plat->clk_ptp_rate = clk_get_rate(plat->stmmac_clk);
plat->clk_ptp_ref = NULL;
- dev_warn(&pdev->dev, "PTP uses main clock\n");
+ dev_info(&pdev->dev, "PTP uses main clock\n");
} else {
plat->clk_ptp_rate = clk_get_rate(plat->clk_ptp_ref);
dev_dbg(&pdev->dev, "PTP rate %d\n", plat->clk_ptp_rate);
--
2.25.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] net: ethernet: stmmac: don't warn about missing optional wakeup IRQ
2020-02-24 17:29 [PATCH 1/2] net: ethernet: stmmac: demote warnings about missing optional clocks Ahmad Fatoum
@ 2020-02-24 17:29 ` Ahmad Fatoum
2020-02-24 23:39 ` David Miller
2020-02-24 23:39 ` [PATCH 1/2] net: ethernet: stmmac: demote warnings about missing optional clocks David Miller
1 sibling, 1 reply; 4+ messages in thread
From: Ahmad Fatoum @ 2020-02-24 17:29 UTC (permalink / raw)
To: Giuseppe Cavallaro, Alexandre Torgue, Jose Abreu, Maxime Coquelin
Cc: kernel, Ahmad Fatoum, David S. Miller, netdev, linux-stm32,
linux-arm-kernel, linux-kernel
The "stm32_pwr_wakeup" is optional per the binding and the driver
handles its absence gracefully. Request it with
platform_get_irq_byname_optional, so its absence doesn't needlessly
clutter the log.
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
drivers/net/ethernet/stmicro/stmmac/dwmac-stm32.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-stm32.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-stm32.c
index dc84e5066bf8..b2dc99289687 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac-stm32.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-stm32.c
@@ -324,7 +324,7 @@ static int stm32mp1_parse_data(struct stm32_dwmac *dwmac,
/* Get IRQ information early to have an ability to ask for deferred
* probe if needed before we went too far with resource allocation.
*/
- dwmac->irq_pwr_wakeup = platform_get_irq_byname(pdev,
+ dwmac->irq_pwr_wakeup = platform_get_irq_byname_optional(pdev,
"stm32_pwr_wakeup");
if (dwmac->irq_pwr_wakeup == -EPROBE_DEFER)
return -EPROBE_DEFER;
--
2.25.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] net: ethernet: stmmac: demote warnings about missing optional clocks
2020-02-24 17:29 [PATCH 1/2] net: ethernet: stmmac: demote warnings about missing optional clocks Ahmad Fatoum
2020-02-24 17:29 ` [PATCH 2/2] net: ethernet: stmmac: don't warn about missing optional wakeup IRQ Ahmad Fatoum
@ 2020-02-24 23:39 ` David Miller
1 sibling, 0 replies; 4+ messages in thread
From: David Miller @ 2020-02-24 23:39 UTC (permalink / raw)
To: a.fatoum
Cc: peppe.cavallaro, alexandre.torgue, joabreu, mcoquelin.stm32,
kernel, netdev, linux-stm32, linux-arm-kernel, linux-kernel
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
Date: Mon, 24 Feb 2020 18:29:54 +0100
> The specification of a "eth-ck" and a "ptp_ref" clock is optional per
> the binding and the driver handles them gracefully.
> Demote the output to an info message accordingly.
>
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
Applied.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] net: ethernet: stmmac: don't warn about missing optional wakeup IRQ
2020-02-24 17:29 ` [PATCH 2/2] net: ethernet: stmmac: don't warn about missing optional wakeup IRQ Ahmad Fatoum
@ 2020-02-24 23:39 ` David Miller
0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2020-02-24 23:39 UTC (permalink / raw)
To: a.fatoum
Cc: peppe.cavallaro, alexandre.torgue, joabreu, mcoquelin.stm32,
kernel, netdev, linux-stm32, linux-arm-kernel, linux-kernel
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
Date: Mon, 24 Feb 2020 18:29:55 +0100
> The "stm32_pwr_wakeup" is optional per the binding and the driver
> handles its absence gracefully. Request it with
> platform_get_irq_byname_optional, so its absence doesn't needlessly
> clutter the log.
>
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
Applied.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-02-24 23:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-24 17:29 [PATCH 1/2] net: ethernet: stmmac: demote warnings about missing optional clocks Ahmad Fatoum
2020-02-24 17:29 ` [PATCH 2/2] net: ethernet: stmmac: don't warn about missing optional wakeup IRQ Ahmad Fatoum
2020-02-24 23:39 ` David Miller
2020-02-24 23:39 ` [PATCH 1/2] net: ethernet: stmmac: demote warnings about missing optional clocks David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).