[PATCH] xshared.h - include sys/time.h to fix lack of struct timeval declaration

[PATCH] xshared.h - include sys/time.h to fix lack of struct timeval declaration

[Maciej Żenczykowski]

From: Maciej Żenczykowski <maze@google.com>

This fixes compiler warnings:

iptables/xshared.h:176:50: error: declaration of 'struct timeval' will not be visible outside of this function [-Werror,-Wvisibility]
extern int xtables_lock_or_exit(int wait, struct timeval *tv);
                                                 ^
iptables/xshared.h:179:57: error: declaration of 'struct timeval' will not be visible outside of this function [-Werror,-Wvisibility]
void parse_wait_interval(int argc, char *argv[], struct timeval *wait_interval);
                                                        ^

Test: builds with less warnings
Signed-off-by: Maciej Żenczykowski <maze@google.com>
---
 iptables/xshared.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/iptables/xshared.h b/iptables/xshared.h
index 490b19ad..c41bd054 100644
--- a/iptables/xshared.h
+++ b/iptables/xshared.h
@@ -6,6 +6,7 @@
 #include <stdint.h>
 #include <netinet/in.h>
 #include <net/if.h>
+#include <sys/time.h>
 #include <linux/netfilter_arp/arp_tables.h>
 #include <linux/netfilter_ipv4/ip_tables.h>
 #include <linux/netfilter_ipv6/ip6_tables.h>
-- 
2.26.1.301.g55bc3eb7cb9-goog

Re: [PATCH] xshared.h - include sys/time.h to fix lack of struct timeval declaration

[Pablo Neira Ayuso]

On Tue, Apr 21, 2020 at 01:15:34AM -0700, Maciej Żenczykowski wrote:
> From: Maciej Żenczykowski <maze@google.com>
> 
> This fixes compiler warnings:
> 
> iptables/xshared.h:176:50: error: declaration of 'struct timeval' will not be visible outside of this function [-Werror,-Wvisibility]
> extern int xtables_lock_or_exit(int wait, struct timeval *tv);
>                                                  ^
> iptables/xshared.h:179:57: error: declaration of 'struct timeval' will not be visible outside of this function [-Werror,-Wvisibility]
> void parse_wait_interval(int argc, char *argv[], struct timeval *wait_interval);
>                                                         ^

Applied.