From: Jakub Kicinski <kuba@kernel.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Ido Schimmel <idosch@idosch.org>,
netdev@vger.kernel.org, davem@davemloft.net, jiri@nvidia.com,
danieller@nvidia.com, andrew@lunn.ch, f.fainelli@gmail.com,
mkubecek@suse.cz, mlxsw@nvidia.com,
Ido Schimmel <idosch@nvidia.com>
Subject: Re: [PATCH net-next 1/6] ethtool: Extend link modes settings uAPI with lanes
Date: Mon, 12 Oct 2020 13:08:42 -0700 [thread overview]
Message-ID: <20201012130842.5f498631@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <52f7e2d98ae575f353c6f519065c85ba782168be.camel@sipsolutions.net>
On Mon, 12 Oct 2020 21:10:53 +0200 Johannes Berg wrote:
> Hi,
>
> Sorry, somehow didn't see this until now.
>
> > > +/* Lanes, 1, 2, 4 or 8. */
> > > +#define ETHTOOL_LANES_1 1
> > > +#define ETHTOOL_LANES_2 2
> > > +#define ETHTOOL_LANES_4 4
> > > +#define ETHTOOL_LANES_8 8
> >
> > Not an extremely useful set of defines, not sure Michal would agree.
> >
> > > +#define ETHTOOL_LANES_UNKNOWN 0
> > > struct link_mode_info {
> > > int speed;
> > > + int lanes;
> >
> > why signed?
> >
> > > u8 duplex;
> > > };
> > > @@ -274,16 +277,17 @@ const struct nla_policy ethnl_linkmodes_set_policy[] = {
> > > [ETHTOOL_A_LINKMODES_SPEED] = { .type = NLA_U32 },
> > > [ETHTOOL_A_LINKMODES_DUPLEX] = { .type = NLA_U8 },
> > > [ETHTOOL_A_LINKMODES_MASTER_SLAVE_CFG] = { .type = NLA_U8 },
> > > + [ETHTOOL_A_LINKMODES_LANES] = { .type = NLA_U32 },
> >
> > NLA_POLICY_VALIDATE_FN(), not sure why the types for this
> > validation_type are limited.. Johannes, just an abundance of caution?
>
> So let me see if I got this right - you're saying you'd like to use
> NLA_POLICY_VALIDATE_FN() for an NLA_U32, to validate against the _LANES
> being 1, 2, 4 or 8?
>
> First of all, you _can_, no? I mean, it's limited by
>
> #define NLA_ENSURE_NO_VALIDATION_PTR(tp) \
> (__NLA_ENSURE(tp != NLA_BITFIELD32 && \
> tp != NLA_REJECT && \
> tp != NLA_NESTED && \
> tp != NLA_NESTED_ARRAY) + tp)
>
> and the reason is sort of encoded in that - the types listed here
> already use the pointer *regardless of the validation_type*, so you
> can't have a pointer to the function in the same union.
>
> But not sure I understood :-)
Yes, you're right. Sorry for the noise, one day I'll learn to read..
next prev parent reply other threads:[~2020-10-12 20:08 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-10 15:41 [PATCH net-next 0/6] Support setting lanes via ethtool Ido Schimmel
2020-10-10 15:41 ` [PATCH net-next 1/6] ethtool: Extend link modes settings uAPI with lanes Ido Schimmel
2020-10-11 22:37 ` Jakub Kicinski
2020-10-12 15:33 ` Danielle Ratson
2020-10-12 15:58 ` Jakub Kicinski
2020-10-13 14:29 ` Danielle Ratson
2020-10-13 15:43 ` Jakub Kicinski
2020-10-16 22:15 ` Andrew Lunn
2020-10-19 7:19 ` Danielle Ratson
2020-10-19 11:04 ` Michal Kubecek
2020-10-19 12:26 ` Jiri Pirko
2020-10-19 13:24 ` Michal Kubecek
2020-10-20 7:39 ` Danielle Ratson
2020-10-21 7:08 ` Michal Kubecek
2020-10-21 7:20 ` Danielle Ratson
2020-10-21 8:47 ` Michal Kubecek
2020-10-22 6:15 ` Danielle Ratson
2020-10-22 16:27 ` Michal Kubecek
2020-11-23 9:47 ` Danielle Ratson
2020-11-24 22:12 ` Michal Kubecek
2020-11-25 10:35 ` Danielle Ratson
2020-11-26 21:07 ` Michal Kubecek
2020-12-01 17:22 ` Danielle Ratson
2020-12-02 0:52 ` Edwin Peer
2020-12-02 1:17 ` Edwin Peer
2020-10-19 12:24 ` Jiri Pirko
2020-10-19 12:38 ` Andrew Lunn
2020-10-12 16:40 ` Michal Kubecek
2020-10-12 19:10 ` Johannes Berg
2020-10-12 20:08 ` Jakub Kicinski [this message]
2020-10-12 17:03 ` Michal Kubecek
2020-11-19 20:38 ` Edwin Peer
2020-11-23 9:40 ` Jiri Pirko
2020-11-30 17:01 ` Edwin Peer
2020-11-30 17:14 ` Jiri Pirko
2020-11-30 18:00 ` Edwin Peer
2020-12-01 11:22 ` Jiri Pirko
2020-12-02 0:32 ` Edwin Peer
2020-12-02 10:09 ` Jiri Pirko
2020-12-02 17:53 ` Edwin Peer
2020-10-10 15:41 ` [PATCH net-next 2/6] ethtool: Expose the number of lanes in use Ido Schimmel
2020-10-10 15:41 ` [PATCH net-next 3/6] mlxsw: ethtool: Remove max lanes filtering Ido Schimmel
2020-10-10 15:41 ` [PATCH net-next 4/6] mlxsw: ethtool: Add support for setting lanes when autoneg is off Ido Schimmel
2020-10-10 15:41 ` [PATCH net-next 5/6] mlxsw: ethtool: Expose the number of lanes in use Ido Schimmel
2020-10-10 15:41 ` [PATCH net-next 6/6] net: selftests: Add lanes setting test Ido Schimmel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201012130842.5f498631@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=danieller@nvidia.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=idosch@idosch.org \
--cc=idosch@nvidia.com \
--cc=jiri@nvidia.com \
--cc=johannes@sipsolutions.net \
--cc=mkubecek@suse.cz \
--cc=mlxsw@nvidia.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).