From: "Pali Rohár" <pali@kernel.org>
To: Russell King - ARM Linux admin <linux@armlinux.org.uk>
Cc: "Andrew Lunn" <andrew@lunn.ch>,
"Heiner Kallweit" <hkallweit1@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
"Jakub Kicinski" <kuba@kernel.org>,
"Marek Behún" <kabel@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] net: sfp: assume that LOS is not implemented if both LOS normal and inverted is set
Date: Wed, 30 Dec 2020 17:57:58 +0100 [thread overview]
Message-ID: <20201230165758.jqezvxnl44cvvodw@pali> (raw)
In-Reply-To: <20201230161310.GT1551@shell.armlinux.org.uk>
On Wednesday 30 December 2020 16:13:10 Russell King - ARM Linux admin wrote:
> On Wed, Dec 30, 2020 at 04:47:54PM +0100, Pali Rohár wrote:
> > Some GPON SFP modules (e.g. Ubiquiti U-Fiber Instant) have set both
> > SFP_OPTIONS_LOS_INVERTED and SFP_OPTIONS_LOS_NORMAL bits in their EEPROM.
> >
> > Such combination of bits is meaningless so assume that LOS signal is not
> > implemented.
> >
> > This patch fixes link carrier for GPON SFP module Ubiquiti U-Fiber Instant.
> >
> > Co-developed-by: Russell King <rmk+kernel@armlinux.org.uk>
> > Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
>
> No, this is not co-developed. The patch content is exactly what _I_
> sent you, only the commit description is your own.
Sorry, in this case I misunderstood usage of this Co-developed-by tag.
I will remove it in next iteration of patches.
> > Signed-off-by: Pali Rohár <pali@kernel.org>
> > ---
> > drivers/net/phy/sfp.c | 36 ++++++++++++++++++++++--------------
> > 1 file changed, 22 insertions(+), 14 deletions(-)
> >
> > diff --git a/drivers/net/phy/sfp.c b/drivers/net/phy/sfp.c
> > index 73f3ecf15260..d47485ed239c 100644
> > --- a/drivers/net/phy/sfp.c
> > +++ b/drivers/net/phy/sfp.c
> > @@ -1475,15 +1475,19 @@ static void sfp_sm_link_down(struct sfp *sfp)
> >
> > static void sfp_sm_link_check_los(struct sfp *sfp)
> > {
> > - unsigned int los = sfp->state & SFP_F_LOS;
> > + const __be16 los_inverted = cpu_to_be16(SFP_OPTIONS_LOS_INVERTED);
> > + const __be16 los_normal = cpu_to_be16(SFP_OPTIONS_LOS_NORMAL);
> > + __be16 los_options = sfp->id.ext.options & (los_inverted | los_normal);
> > + bool los = false;
> >
> > /* If neither SFP_OPTIONS_LOS_INVERTED nor SFP_OPTIONS_LOS_NORMAL
> > - * are set, we assume that no LOS signal is available.
> > + * are set, we assume that no LOS signal is available. If both are
> > + * set, we assume LOS is not implemented (and is meaningless.)
> > */
> > - if (sfp->id.ext.options & cpu_to_be16(SFP_OPTIONS_LOS_INVERTED))
> > - los ^= SFP_F_LOS;
> > - else if (!(sfp->id.ext.options & cpu_to_be16(SFP_OPTIONS_LOS_NORMAL)))
> > - los = 0;
> > + if (los_options == los_inverted)
> > + los = !(sfp->state & SFP_F_LOS);
> > + else if (los_options == los_normal)
> > + los = !!(sfp->state & SFP_F_LOS);
> >
> > if (los)
> > sfp_sm_next(sfp, SFP_S_WAIT_LOS, 0);
> > @@ -1493,18 +1497,22 @@ static void sfp_sm_link_check_los(struct sfp *sfp)
> >
> > static bool sfp_los_event_active(struct sfp *sfp, unsigned int event)
> > {
> > - return (sfp->id.ext.options & cpu_to_be16(SFP_OPTIONS_LOS_INVERTED) &&
> > - event == SFP_E_LOS_LOW) ||
> > - (sfp->id.ext.options & cpu_to_be16(SFP_OPTIONS_LOS_NORMAL) &&
> > - event == SFP_E_LOS_HIGH);
> > + const __be16 los_inverted = cpu_to_be16(SFP_OPTIONS_LOS_INVERTED);
> > + const __be16 los_normal = cpu_to_be16(SFP_OPTIONS_LOS_NORMAL);
> > + __be16 los_options = sfp->id.ext.options & (los_inverted | los_normal);
> > +
> > + return (los_options == los_inverted && event == SFP_E_LOS_LOW) ||
> > + (los_options == los_normal && event == SFP_E_LOS_HIGH);
> > }
> >
> > static bool sfp_los_event_inactive(struct sfp *sfp, unsigned int event)
> > {
> > - return (sfp->id.ext.options & cpu_to_be16(SFP_OPTIONS_LOS_INVERTED) &&
> > - event == SFP_E_LOS_HIGH) ||
> > - (sfp->id.ext.options & cpu_to_be16(SFP_OPTIONS_LOS_NORMAL) &&
> > - event == SFP_E_LOS_LOW);
> > + const __be16 los_inverted = cpu_to_be16(SFP_OPTIONS_LOS_INVERTED);
> > + const __be16 los_normal = cpu_to_be16(SFP_OPTIONS_LOS_NORMAL);
> > + __be16 los_options = sfp->id.ext.options & (los_inverted | los_normal);
> > +
> > + return (los_options == los_inverted && event == SFP_E_LOS_HIGH) ||
> > + (los_options == los_normal && event == SFP_E_LOS_LOW);
> > }
> >
> > static void sfp_sm_fault(struct sfp *sfp, unsigned int next_state, bool warn)
> > --
> > 2.20.1
> >
> >
>
> --
> RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
> FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2020-12-30 16:58 UTC|newest]
Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-30 15:47 [PATCH 0/4] net: sfp: add support for GPON RTL8672/RTL9601C and Ubiquiti U-Fiber Pali Rohár
2020-12-30 15:47 ` [PATCH 1/4] net: sfp: add workaround for Realtek RTL8672 and RTL9601C chips Pali Rohár
2020-12-30 16:10 ` Russell King - ARM Linux admin
2020-12-30 16:56 ` Pali Rohár
2020-12-30 17:05 ` Russell King - ARM Linux admin
2020-12-30 17:13 ` Andrew Lunn
2020-12-30 17:43 ` Pali Rohár
2020-12-30 19:09 ` Russell King - ARM Linux admin
2020-12-30 19:49 ` Andrew Lunn
2020-12-31 12:14 ` Pali Rohár
2020-12-31 15:09 ` Andrew Lunn
2020-12-31 15:40 ` Pali Rohár
2020-12-31 15:30 ` Andrew Lunn
2020-12-31 17:00 ` Pali Rohár
2020-12-31 17:13 ` Andrew Lunn
2021-01-02 1:49 ` Pali Rohár
2021-01-03 2:25 ` Thomas Schreiber
2021-01-03 2:41 ` Pali Rohár
2021-01-06 14:55 ` Pali Rohár
2021-01-06 15:21 ` Russell King - ARM Linux admin
2021-01-06 15:23 ` Russell King - ARM Linux admin
2021-01-06 15:27 ` Russell King - ARM Linux admin
2021-01-06 15:35 ` Pali Rohár
2020-12-30 19:30 ` Andrew Lunn
2020-12-30 19:39 ` Russell King - ARM Linux admin
2020-12-30 17:31 ` Pali Rohár
2020-12-30 19:18 ` Russell King - ARM Linux admin
2020-12-30 15:47 ` [PATCH 2/4] net: sfp: allow to use also SFP modules which are detected as SFF Pali Rohár
2020-12-30 16:11 ` Russell King - ARM Linux admin
2020-12-30 17:06 ` Pali Rohár
2020-12-30 17:27 ` Marek Behún
2020-12-30 19:12 ` Russell King - ARM Linux admin
2020-12-31 13:52 ` Pali Rohár
2020-12-30 15:47 ` [PATCH 3/4] net: sfp: assume that LOS is not implemented if both LOS normal and inverted is set Pali Rohár
2020-12-30 16:13 ` Russell King - ARM Linux admin
2020-12-30 16:57 ` Pali Rohár [this message]
2020-12-30 17:06 ` Russell King - ARM Linux admin
2020-12-30 17:17 ` Andrew Lunn
2020-12-30 17:32 ` Pali Rohár
2020-12-30 15:47 ` [PATCH 4/4] net: sfp: add mode quirk for GPON module Ubiquiti U-Fiber Instant Pali Rohár
2021-01-06 15:37 ` [PATCH v2 0/3] net: sfp: add support for GPON RTL8672/RTL9601C and Ubiquiti U-Fiber Pali Rohár
2021-01-06 15:37 ` [PATCH v2 1/3] net: sfp: add workaround for Realtek RTL8672 and RTL9601C chips Pali Rohár
2021-01-07 2:02 ` Andrew Lunn
2021-01-07 9:08 ` Pali Rohár
2021-01-07 17:19 ` Andrew Lunn
2021-01-07 17:40 ` Russell King - ARM Linux admin
2021-01-07 19:18 ` Pali Rohár
2021-01-07 19:17 ` Pali Rohár
2021-01-07 19:45 ` Russell King - ARM Linux admin
2021-01-07 20:21 ` Marek Behún
2021-01-08 0:49 ` Pali Rohár
2021-01-06 15:37 ` [PATCH v2 2/3] net: sfp: assume that LOS is not implemented if both LOS normal and inverted is set Pali Rohár
2021-01-07 16:54 ` Andrew Lunn
2021-01-09 15:46 ` Russell King - ARM Linux admin
2021-01-09 15:54 ` Andrew Lunn
2021-01-09 16:27 ` Russell King - ARM Linux admin
2021-01-09 19:14 ` Pali Rohár
2021-01-09 23:19 ` Russell King - ARM Linux admin
2021-01-09 23:50 ` Pali Rohár
2021-01-06 15:37 ` [PATCH v2 3/3] net: sfp: add mode quirk for GPON module Ubiquiti U-Fiber Instant Pali Rohár
2021-01-07 16:51 ` Andrew Lunn
2021-01-11 11:39 ` [PATCH v3 0/2] net: sfp: add support for GPON RTL8672/RTL9601C and Ubiquiti U-Fiber Pali Rohár
2021-01-11 11:39 ` [PATCH v3 1/2] net: sfp: add workaround for Realtek RTL8672 and RTL9601C chips Pali Rohár
2021-01-11 15:28 ` Marek Behún
2021-01-11 11:39 ` [PATCH v3 2/2] net: sfp: add mode quirk for GPON module Ubiquiti U-Fiber Instant Pali Rohár
2021-01-11 15:32 ` Marek Behún
2021-01-12 13:33 ` [PATCH v3 0/2] net: sfp: add support for GPON RTL8672/RTL9601C and Ubiquiti U-Fiber Pali Rohár
2021-01-18 9:34 ` Pali Rohár
2021-01-25 14:09 ` Pali Rohár
2021-01-25 14:16 ` Russell King - ARM Linux admin
2021-01-25 14:23 ` Pali Rohár
2021-01-25 14:42 ` Russell King - ARM Linux admin
2021-01-25 14:47 ` Pali Rohár
2021-01-25 15:41 ` Andrew Lunn
2021-01-25 15:02 ` [PATCH v4 " Pali Rohár
2021-01-25 15:02 ` [PATCH v4 1/2] net: sfp: add workaround for Realtek RTL8672 and RTL9601C chips Pali Rohár
2021-01-25 15:02 ` [PATCH v4 2/2] net: sfp: add mode quirk for GPON module Ubiquiti U-Fiber Instant Pali Rohár
2021-01-28 21:50 ` [PATCH v4 0/2] net: sfp: add support for GPON RTL8672/RTL9601C and Ubiquiti U-Fiber patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201230165758.jqezvxnl44cvvodw@pali \
--to=pali@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=kabel@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).