From: "Pali Rohár" <pali@kernel.org>
To: Russell King - ARM Linux admin <linux@armlinux.org.uk>
Cc: "Marek Behún" <kabel@kernel.org>, "Andrew Lunn" <andrew@lunn.ch>,
"Heiner Kallweit" <hkallweit1@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
"Jakub Kicinski" <kuba@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] net: sfp: allow to use also SFP modules which are detected as SFF
Date: Thu, 31 Dec 2020 14:52:43 +0100 [thread overview]
Message-ID: <20201231135243.tvzkre2sddhdxfbq@pali> (raw)
In-Reply-To: <20201230191240.GX1551@shell.armlinux.org.uk>
On Wednesday 30 December 2020 19:12:40 Russell King - ARM Linux admin wrote:
> On Wed, Dec 30, 2020 at 06:27:07PM +0100, Marek Behún wrote:
> > On Wed, 30 Dec 2020 18:06:52 +0100
> > Pali Rohár <pali@kernel.org> wrote:
> >
> > > if (!sfp->type->module_supported(&id) &&
> > > (memcmp(id.base.vendor_name, "UBNT ", 16) ||
> > > memcmp(id.base.vendor_pn, "UF-INSTANT ", 16)))
> >
> > I would rather add a quirk member (bitfield) to the sfp structure and do
> > something like this
> >
> > if (!sfp->type->module_supported(&id) &&
> > !(sfp->quirks & SFP_QUIRK_BAD_PHYS_ID))
> >
> > or maybe put this check into the module_supported method.
>
> Sorry, definitely not. If you've ever looked at the SDHCI driver with
> its multiple "quirks" bitfields, doing this is a recipe for creating
> a very horrid hard to understand mess.
>
> What you suggest just results in yet more complexity.
Should I rather put this vendor name/pn check into the
sfp_module_supported() function?
static bool sfp_module_supported(const struct sfp_eeprom_id *id)
{
if (id->base.phys_id == SFF8024_ID_SFP &&
id->base.phys_ext_id == SFP_PHYS_EXT_ID_SFP)
return true;
if (id->base.phys_id == SFF8024_ID_SFF_8472 &&
id->base.phys_ext_id == SFP_PHYS_EXT_ID_SFP &&
!memcmp(id->base.vendor_name, "UBNT ", 16) &&
!memcmp(id->base.vendor_pn, "UF-INSTANT ", 16))
return true;
return false;
}
next prev parent reply other threads:[~2020-12-31 13:53 UTC|newest]
Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-30 15:47 [PATCH 0/4] net: sfp: add support for GPON RTL8672/RTL9601C and Ubiquiti U-Fiber Pali Rohár
2020-12-30 15:47 ` [PATCH 1/4] net: sfp: add workaround for Realtek RTL8672 and RTL9601C chips Pali Rohár
2020-12-30 16:10 ` Russell King - ARM Linux admin
2020-12-30 16:56 ` Pali Rohár
2020-12-30 17:05 ` Russell King - ARM Linux admin
2020-12-30 17:13 ` Andrew Lunn
2020-12-30 17:43 ` Pali Rohár
2020-12-30 19:09 ` Russell King - ARM Linux admin
2020-12-30 19:49 ` Andrew Lunn
2020-12-31 12:14 ` Pali Rohár
2020-12-31 15:09 ` Andrew Lunn
2020-12-31 15:40 ` Pali Rohár
2020-12-31 15:30 ` Andrew Lunn
2020-12-31 17:00 ` Pali Rohár
2020-12-31 17:13 ` Andrew Lunn
2021-01-02 1:49 ` Pali Rohár
2021-01-03 2:25 ` Thomas Schreiber
2021-01-03 2:41 ` Pali Rohár
2021-01-06 14:55 ` Pali Rohár
2021-01-06 15:21 ` Russell King - ARM Linux admin
2021-01-06 15:23 ` Russell King - ARM Linux admin
2021-01-06 15:27 ` Russell King - ARM Linux admin
2021-01-06 15:35 ` Pali Rohár
2020-12-30 19:30 ` Andrew Lunn
2020-12-30 19:39 ` Russell King - ARM Linux admin
2020-12-30 17:31 ` Pali Rohár
2020-12-30 19:18 ` Russell King - ARM Linux admin
2020-12-30 15:47 ` [PATCH 2/4] net: sfp: allow to use also SFP modules which are detected as SFF Pali Rohár
2020-12-30 16:11 ` Russell King - ARM Linux admin
2020-12-30 17:06 ` Pali Rohár
2020-12-30 17:27 ` Marek Behún
2020-12-30 19:12 ` Russell King - ARM Linux admin
2020-12-31 13:52 ` Pali Rohár [this message]
2020-12-30 15:47 ` [PATCH 3/4] net: sfp: assume that LOS is not implemented if both LOS normal and inverted is set Pali Rohár
2020-12-30 16:13 ` Russell King - ARM Linux admin
2020-12-30 16:57 ` Pali Rohár
2020-12-30 17:06 ` Russell King - ARM Linux admin
2020-12-30 17:17 ` Andrew Lunn
2020-12-30 17:32 ` Pali Rohár
2020-12-30 15:47 ` [PATCH 4/4] net: sfp: add mode quirk for GPON module Ubiquiti U-Fiber Instant Pali Rohár
2021-01-06 15:37 ` [PATCH v2 0/3] net: sfp: add support for GPON RTL8672/RTL9601C and Ubiquiti U-Fiber Pali Rohár
2021-01-06 15:37 ` [PATCH v2 1/3] net: sfp: add workaround for Realtek RTL8672 and RTL9601C chips Pali Rohár
2021-01-07 2:02 ` Andrew Lunn
2021-01-07 9:08 ` Pali Rohár
2021-01-07 17:19 ` Andrew Lunn
2021-01-07 17:40 ` Russell King - ARM Linux admin
2021-01-07 19:18 ` Pali Rohár
2021-01-07 19:17 ` Pali Rohár
2021-01-07 19:45 ` Russell King - ARM Linux admin
2021-01-07 20:21 ` Marek Behún
2021-01-08 0:49 ` Pali Rohár
2021-01-06 15:37 ` [PATCH v2 2/3] net: sfp: assume that LOS is not implemented if both LOS normal and inverted is set Pali Rohár
2021-01-07 16:54 ` Andrew Lunn
2021-01-09 15:46 ` Russell King - ARM Linux admin
2021-01-09 15:54 ` Andrew Lunn
2021-01-09 16:27 ` Russell King - ARM Linux admin
2021-01-09 19:14 ` Pali Rohár
2021-01-09 23:19 ` Russell King - ARM Linux admin
2021-01-09 23:50 ` Pali Rohár
2021-01-06 15:37 ` [PATCH v2 3/3] net: sfp: add mode quirk for GPON module Ubiquiti U-Fiber Instant Pali Rohár
2021-01-07 16:51 ` Andrew Lunn
2021-01-11 11:39 ` [PATCH v3 0/2] net: sfp: add support for GPON RTL8672/RTL9601C and Ubiquiti U-Fiber Pali Rohár
2021-01-11 11:39 ` [PATCH v3 1/2] net: sfp: add workaround for Realtek RTL8672 and RTL9601C chips Pali Rohár
2021-01-11 15:28 ` Marek Behún
2021-01-11 11:39 ` [PATCH v3 2/2] net: sfp: add mode quirk for GPON module Ubiquiti U-Fiber Instant Pali Rohár
2021-01-11 15:32 ` Marek Behún
2021-01-12 13:33 ` [PATCH v3 0/2] net: sfp: add support for GPON RTL8672/RTL9601C and Ubiquiti U-Fiber Pali Rohár
2021-01-18 9:34 ` Pali Rohár
2021-01-25 14:09 ` Pali Rohár
2021-01-25 14:16 ` Russell King - ARM Linux admin
2021-01-25 14:23 ` Pali Rohár
2021-01-25 14:42 ` Russell King - ARM Linux admin
2021-01-25 14:47 ` Pali Rohár
2021-01-25 15:41 ` Andrew Lunn
2021-01-25 15:02 ` [PATCH v4 " Pali Rohár
2021-01-25 15:02 ` [PATCH v4 1/2] net: sfp: add workaround for Realtek RTL8672 and RTL9601C chips Pali Rohár
2021-01-25 15:02 ` [PATCH v4 2/2] net: sfp: add mode quirk for GPON module Ubiquiti U-Fiber Instant Pali Rohár
2021-01-28 21:50 ` [PATCH v4 0/2] net: sfp: add support for GPON RTL8672/RTL9601C and Ubiquiti U-Fiber patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201231135243.tvzkre2sddhdxfbq@pali \
--to=pali@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=kabel@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).