[PATCH drivers/net] #ifdef mdio_bus_phy_suspend() and mdio_bus_phy_suspend()

* [PATCH drivers/net] #ifdef mdio_bus_phy_suspend() and mdio_bus_phy_suspend()
@ 2021-03-03 17:53 Paul E. McKenney
  2021-03-03 18:04 ` Russell King - ARM Linux admin
  0 siblings, 1 reply; 3+ messages in thread
From: Paul E. McKenney @ 2021-03-03 17:53 UTC (permalink / raw)
  To: andrew, hkallweit1, linux, davem, kuba; +Cc: netdev, linux-kernel, kernel-team

drivers/net: #ifdef mdio_bus_phy_suspend() and mdio_bus_phy_suspend()

The following build error is emitted by rcutorture builds of v5.12-rc1:

drivers/net/phy/phy_device.c:293:12: warning: ‘mdio_bus_phy_resume’ defined but not used [-Wunused-function]
drivers/net/phy/phy_device.c:273:12: warning: ‘mdio_bus_phy_suspend’ defined but not used [-Wunused-function]

The problem is that these functions are only used by SIMPLE_DEV_PM_OPS(),
which creates a dev_pm_ops structure only in CONFIG_PM_SLEEP=y kernels.
Therefore, the mdio_bus_phy_suspend() and mdio_bus_phy_suspend() functions
will be used only in CONFIG_PM_SLEEP=y kernels.  This commit therefore
wraps them in #ifdef CONFIG_PM_SLEEP.

Cc: Andrew Lunn <andrew@lunn.ch>
Cc: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Russell King <linux@armlinux.org.uk>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: <netdev@vger.kernel.org>
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>

diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c
index ce49547..d6fb6e7 100644
--- a/drivers/net/phy/phy_device.c
+++ b/drivers/net/phy/phy_device.c
@@ -270,6 +270,8 @@ static bool mdio_bus_phy_may_suspend(struct phy_device *phydev)
 	return !phydev->suspended;
 }
 
+#ifdef CONFIG_PM_SLEEP
+
 static int mdio_bus_phy_suspend(struct device *dev)
 {
 	struct phy_device *phydev = to_phy_device(dev);
@@ -314,6 +316,8 @@ static int mdio_bus_phy_resume(struct device *dev)
 	return 0;
 }
 
+#endif
+
 static SIMPLE_DEV_PM_OPS(mdio_bus_phy_pm_ops, mdio_bus_phy_suspend,
 			 mdio_bus_phy_resume);
 #endif /* CONFIG_PM */

^ permalink raw reply related	[flat|nested] 3+ messages in thread