From: Lucas De Marchi <lucas.demarchi@intel.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: "Sakari Ailus" <sakari.ailus@linux.intel.com>,
"Emma Anholt" <emma@anholt.net>,
"David Airlie" <airlied@linux.ie>,
nouveau@lists.freedesktop.org,
"Rasmus Villemoes" <linux@rasmusvillemoes.dk>,
dri-devel@lists.freedesktop.org,
"Chris Wilson" <chris@chris-wilson.co.uk>,
"Vishal Kulkarni" <vishal@chelsio.com>,
"Francis Laniel" <laniel_francis@privacyrequired.com>,
"Kentaro Takeda" <takedakn@nttdata.co.jp>,
"Mikita Lipski" <mikita.lipski@amd.com>,
amd-gfx@lists.freedesktop.org,
"Andy Shevchenko" <andy.shevchenko@gmail.com>,
"Ben Skeggs" <bskeggs@redhat.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Harry Wentland" <harry.wentland@amd.com>,
"Petr Mladek" <pmladek@suse.com>, "Leo Li" <sunpeng.li@amd.com>,
intel-gfx@lists.freedesktop.org,
"Raju Rangoju" <rajur@chelsio.com>,
"Julia Lawall" <julia.lawall@lip6.fr>,
"Rahul Lakkireddy" <rahul.lakkireddy@chelsio.com>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Eryk Brol" <eryk.brol@amd.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org,
"Christian König" <christian.koenig@amd.com>,
"Sergey Senozhatsky" <sergey.senozhatsky@gmail.com>,
linux-security-module@vger.kernel.org, netdev@vger.kernel.org,
"Alex Deucher" <alexander.deucher@amd.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
"David S . Miller" <davem@davemloft.net>
Subject: Re: [Intel-gfx] [PATCH 1/3] lib/string_helpers: Consolidate yesno() implementation
Date: Wed, 19 Jan 2022 12:43:56 -0800 [thread overview]
Message-ID: <20220119204356.vizlstcs6wi6kn4b@ldmartin-desk2> (raw)
In-Reply-To: <20220119100635.6c45372b@gandalf.local.home>
On Wed, Jan 19, 2022 at 10:06:35AM -0500, Steven Rostedt wrote:
>On Wed, 19 Jan 2022 11:18:59 +0200
>Sakari Ailus <sakari.ailus@linux.intel.com> wrote:
>
>> On Tue, Jan 18, 2022 at 11:24:48PM -0800, Lucas De Marchi wrote:
>> > @@ -1354,8 +1345,7 @@ static bool tomoyo_print_condition(struct tomoyo_io_buffer *head,
>> > case 3:
>> > if (cond->grant_log != TOMOYO_GRANTLOG_AUTO)
>> > tomoyo_io_printf(head, " grant_log=%s",
>> > - tomoyo_yesno(cond->grant_log ==
>> > - TOMOYO_GRANTLOG_YES));
>> > + yesno(cond->grant_log == TOMOYO_GRANTLOG_YES));
>>
>> This would be better split on two lines.
>
>Really? Yuck!
>
>I thought the "max line size" guideline was going to grow to a 100, but I
>still see it as 80. But anyway...
Checking that: docs still say 80, but checkpatch was changed to warn
only on 100. Commit bdc48fa11e46 ("checkpatch/coding-style: deprecate
80-column warning") is clear why the discrepancy.
Lucas De Marchi
>
> cond->grant_log ==
> TOMOYO_GRANTLOG_YES
>
>is not readable at all. Not compared to
>
> cond->grant_log == TOMOYO_GRANTLOG_YES
>
>I say keep it one line!
>
>Reviewed-by: Steven Rostedt (Google) <rostedt@goodmis.org>
>
>-- Steve
>
>>
>> Then,
>>
>> Reviewed-by: Sakari Ailus <sakari.ailus@linux.intel.com>
>
next prev parent reply other threads:[~2022-01-19 20:44 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-19 7:24 [PATCH 0/3] lib/string_helpers: Add a few string helpers Lucas De Marchi
2022-01-19 7:24 ` [PATCH 1/3] lib/string_helpers: Consolidate yesno() implementation Lucas De Marchi
2022-01-19 9:18 ` Sakari Ailus
2022-01-19 15:06 ` Steven Rostedt
2022-01-19 19:25 ` Andy Shevchenko
2022-01-19 21:00 ` Steven Rostedt
2022-01-19 21:04 ` Andy Shevchenko
2022-01-21 1:37 ` Joe Perches
2022-01-19 20:43 ` Lucas De Marchi [this message]
[not found] ` <CAHp75Vf5QOD_UtDK8VbxNApEBuJvzUic0NkzDNmRo3Q7Ud+=qw@mail.gmail.com>
2022-01-19 15:01 ` Steven Rostedt
2022-01-19 16:37 ` David Laight
2022-01-19 16:38 ` David Laight
2022-01-19 19:22 ` Andy Shevchenko
2022-01-19 20:58 ` Steven Rostedt
2022-01-19 22:25 ` David Laight
2022-01-19 7:24 ` [PATCH 2/3] lib/string_helpers: Add helpers for enable[d]/disable[d] Lucas De Marchi
[not found] ` <CAHp75Vc4bdu1OTi2t-fHeHkmnVgd6LCdeotnGEH_+q4EGk3OmQ@mail.gmail.com>
2022-01-19 9:42 ` Lucas De Marchi
2022-01-19 7:24 ` [PATCH 3/3] drm: Convert open yes/no strings to yesno() Lucas De Marchi
2022-01-19 19:30 ` Andy Shevchenko
2022-01-26 9:05 ` Lucas De Marchi
2022-01-19 8:02 ` [PATCH 0/3] lib/string_helpers: Add a few string helpers Jani Nikula
2022-01-19 13:18 ` Petr Mladek
2022-01-19 14:16 ` Jani Nikula
2022-01-19 16:15 ` Daniel Vetter
2022-01-19 20:53 ` [Intel-gfx] " Lucas De Marchi
2022-01-19 21:07 ` Andy Shevchenko
2022-01-20 8:38 ` Petr Mladek
2022-01-20 9:12 ` David Laight
2022-01-20 9:12 ` Jani Nikula
2022-01-20 10:45 ` Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220119204356.vizlstcs6wi6kn4b@ldmartin-desk2 \
--to=lucas.demarchi@intel.com \
--cc=airlied@linux.ie \
--cc=akpm@linux-foundation.org \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=bskeggs@redhat.com \
--cc=chris@chris-wilson.co.uk \
--cc=christian.koenig@amd.com \
--cc=davem@davemloft.net \
--cc=dri-devel@lists.freedesktop.org \
--cc=emma@anholt.net \
--cc=eryk.brol@amd.com \
--cc=gregkh@linuxfoundation.org \
--cc=harry.wentland@amd.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=julia.lawall@lip6.fr \
--cc=kuba@kernel.org \
--cc=laniel_francis@privacyrequired.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=mikita.lipski@amd.com \
--cc=netdev@vger.kernel.org \
--cc=nouveau@lists.freedesktop.org \
--cc=pmladek@suse.com \
--cc=rahul.lakkireddy@chelsio.com \
--cc=rajur@chelsio.com \
--cc=rostedt@goodmis.org \
--cc=sakari.ailus@linux.intel.com \
--cc=sergey.senozhatsky@gmail.com \
--cc=sunpeng.li@amd.com \
--cc=takedakn@nttdata.co.jp \
--cc=vishal@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).