From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org,
dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org,
linux-security-module@vger.kernel.org,
nouveau@lists.freedesktop.org, netdev@vger.kernel.org,
"Alex Deucher" <alexander.deucher@amd.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Ben Skeggs" <bskeggs@redhat.com>,
"Christian König" <christian.koenig@amd.com>,
"Chris Wilson" <chris@chris-wilson.co.uk>,
"Daniel Vetter" <daniel@ffwll.ch>,
"David Airlie" <airlied@linux.ie>,
"David S . Miller" <davem@davemloft.net>,
"Emma Anholt" <emma@anholt.net>, "Eryk Brol" <eryk.brol@amd.com>,
"Francis Laniel" <laniel_francis@privacyrequired.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Harry Wentland" <harry.wentland@amd.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Jani Nikula" <jani.nikula@linux.intel.com>,
"Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>,
"Julia Lawall" <julia.lawall@lip6.fr>,
"Kentaro Takeda" <takedakn@nttdata.co.jp>,
"Leo Li" <sunpeng.li@amd.com>,
"Mikita Lipski" <mikita.lipski@amd.com>,
"Petr Mladek" <pmladek@suse.com>,
"Rahul Lakkireddy" <rahul.lakkireddy@chelsio.com>,
"Raju Rangoju" <rajur@chelsio.com>,
"Rasmus Villemoes" <linux@rasmusvillemoes.dk>,
"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
"Sakari Ailus" <sakari.ailus@linux.intel.com>,
"Sergey Senozhatsky" <sergey.senozhatsky@gmail.com>,
"Steven Rostedt" <rostedt@goodmis.org>,
"Vishal Kulkarni" <vishal@chelsio.com>
Subject: Re: [PATCH 3/3] drm: Convert open yes/no strings to yesno()
Date: Wed, 19 Jan 2022 21:30:47 +0200 [thread overview]
Message-ID: <Yehm5/DJ5Ljo1EWs@smile.fi.intel.com> (raw)
In-Reply-To: <20220119072450.2890107-4-lucas.demarchi@intel.com>
On Tue, Jan 18, 2022 at 11:24:50PM -0800, Lucas De Marchi wrote:
> linux/string_helpers.h provides a helper to return "yes"/"no"
> strings. Replace the open coded versions with yesno(). The places were
> identified with the following semantic patch:
>
> @@
> expression b;
> @@
>
> - b ? "yes" : "no"
> + yesno(b)
>
> Then the includes were added, so we include-what-we-use, and parenthesis
> adjusted in drivers/gpu/drm/v3d/v3d_debugfs.c. After the conversion we
> still see the same binary sizes:
>
> text data bss dec hex filename
> 1442171 60344 800 1503315 16f053 ./drivers/gpu/drm/radeon/radeon.ko
> 1442171 60344 800 1503315 16f053 ./drivers/gpu/drm/radeon/radeon.ko.old
> 5985991 324439 33808 6344238 60ce2e ./drivers/gpu/drm/amd/amdgpu/amdgpu.ko
> 5985991 324439 33808 6344238 60ce2e ./drivers/gpu/drm/amd/amdgpu/amdgpu.ko.old
> 411986 10490 6176 428652 68a6c ./drivers/gpu/drm/drm.ko
> 411986 10490 6176 428652 68a6c ./drivers/gpu/drm/drm.ko.old
> 1970292 109515 2352 2082159 1fc56f ./drivers/gpu/drm/nouveau/nouveau.ko
> 1970292 109515 2352 2082159 1fc56f ./drivers/gpu/drm/nouveau/nouveau.ko.old
...
> #include <linux/module.h>
> #include <linux/sched.h>
> #include <linux/slab.h>
> +#include <linux/string_helpers.h>
+ blank line?
> +#include <linux/string_helpers.h>
...
> seq_printf(m, "\tDP branch device present: %s\n",
> - branch_device ? "yes" : "no");
> + yesno(branch_device));
Now it's possible to keep this on one line.
...
> drm_printf_indent(p, indent, "imported=%s\n",
> - obj->import_attach ? "yes" : "no");
> + yesno(obj->import_attach));
81 here, but anyway, ditto!
...
> */
+blank line here?
> +#include <linux/string_helpers.h>
> +
> #include "aux.h"
> #include "pad.h"
...
> seq_printf(m, "MMU: %s\n",
> - (ident2 & V3D_HUB_IDENT2_WITH_MMU) ? "yes" : "no");
> + yesno(ident2 & V3D_HUB_IDENT2_WITH_MMU));
> seq_printf(m, "TFU: %s\n",
> - (ident1 & V3D_HUB_IDENT1_WITH_TFU) ? "yes" : "no");
> + yesno(ident1 & V3D_HUB_IDENT1_WITH_TFU));
> seq_printf(m, "TSY: %s\n",
> - (ident1 & V3D_HUB_IDENT1_WITH_TSY) ? "yes" : "no");
> + yesno(ident1 & V3D_HUB_IDENT1_WITH_TSY));
> seq_printf(m, "MSO: %s\n",
> - (ident1 & V3D_HUB_IDENT1_WITH_MSO) ? "yes" : "no");
> + yesno(ident1 & V3D_HUB_IDENT1_WITH_MSO));
> seq_printf(m, "L3C: %s (%dkb)\n",
> - (ident1 & V3D_HUB_IDENT1_WITH_L3C) ? "yes" : "no",
> + yesno(ident1 & V3D_HUB_IDENT1_WITH_L3C),
> V3D_GET_FIELD(ident2, V3D_HUB_IDENT2_L3C_NKB));
I believe it's fine to join back to have less LOCs (yes, it will be 83 or so,
but I believe in these cases it's very much okay).
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-01-19 19:36 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-19 7:24 [PATCH 0/3] lib/string_helpers: Add a few string helpers Lucas De Marchi
2022-01-19 7:24 ` [PATCH 1/3] lib/string_helpers: Consolidate yesno() implementation Lucas De Marchi
2022-01-19 9:18 ` Sakari Ailus
2022-01-19 15:06 ` Steven Rostedt
2022-01-19 19:25 ` Andy Shevchenko
2022-01-19 21:00 ` Steven Rostedt
2022-01-19 21:04 ` Andy Shevchenko
2022-01-21 1:37 ` Joe Perches
2022-01-19 20:43 ` [Intel-gfx] " Lucas De Marchi
[not found] ` <CAHp75Vf5QOD_UtDK8VbxNApEBuJvzUic0NkzDNmRo3Q7Ud+=qw@mail.gmail.com>
2022-01-19 15:01 ` Steven Rostedt
2022-01-19 16:37 ` David Laight
2022-01-19 16:38 ` David Laight
2022-01-19 19:22 ` Andy Shevchenko
2022-01-19 20:58 ` Steven Rostedt
2022-01-19 22:25 ` David Laight
2022-01-19 7:24 ` [PATCH 2/3] lib/string_helpers: Add helpers for enable[d]/disable[d] Lucas De Marchi
[not found] ` <CAHp75Vc4bdu1OTi2t-fHeHkmnVgd6LCdeotnGEH_+q4EGk3OmQ@mail.gmail.com>
2022-01-19 9:42 ` Lucas De Marchi
2022-01-19 7:24 ` [PATCH 3/3] drm: Convert open yes/no strings to yesno() Lucas De Marchi
2022-01-19 19:30 ` Andy Shevchenko [this message]
2022-01-26 9:05 ` Lucas De Marchi
2022-01-19 8:02 ` [PATCH 0/3] lib/string_helpers: Add a few string helpers Jani Nikula
2022-01-19 13:18 ` Petr Mladek
2022-01-19 14:16 ` Jani Nikula
2022-01-19 16:15 ` Daniel Vetter
2022-01-19 20:53 ` [Intel-gfx] " Lucas De Marchi
2022-01-19 21:07 ` Andy Shevchenko
2022-01-20 8:38 ` Petr Mladek
2022-01-20 9:12 ` David Laight
2022-01-20 9:12 ` Jani Nikula
2022-01-20 10:45 ` Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yehm5/DJ5Ljo1EWs@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=airlied@linux.ie \
--cc=akpm@linux-foundation.org \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=bskeggs@redhat.com \
--cc=chris@chris-wilson.co.uk \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=davem@davemloft.net \
--cc=dri-devel@lists.freedesktop.org \
--cc=emma@anholt.net \
--cc=eryk.brol@amd.com \
--cc=gregkh@linuxfoundation.org \
--cc=harry.wentland@amd.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=julia.lawall@lip6.fr \
--cc=kuba@kernel.org \
--cc=laniel_francis@privacyrequired.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=lucas.demarchi@intel.com \
--cc=mikita.lipski@amd.com \
--cc=netdev@vger.kernel.org \
--cc=nouveau@lists.freedesktop.org \
--cc=pmladek@suse.com \
--cc=rahul.lakkireddy@chelsio.com \
--cc=rajur@chelsio.com \
--cc=rodrigo.vivi@intel.com \
--cc=rostedt@goodmis.org \
--cc=sakari.ailus@linux.intel.com \
--cc=sergey.senozhatsky@gmail.com \
--cc=sunpeng.li@amd.com \
--cc=takedakn@nttdata.co.jp \
--cc=vishal@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).