* [PATCH net-next] gve: Unify duplicate GQ min pkt desc size constants
@ 2023-04-07 18:48 Shailend Chand
2023-04-08 3:24 ` Jakub Kicinski
2023-04-11 13:50 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Shailend Chand @ 2023-04-07 18:48 UTC (permalink / raw)
To: netdev; +Cc: davem, kuba, Shailend Chand
The two constants accomplish the same thing.
Signed-off-by: Shailend Chand <shailend@google.com>
---
drivers/net/ethernet/google/gve/gve.h | 2 --
drivers/net/ethernet/google/gve/gve_tx.c | 4 ++--
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/google/gve/gve.h b/drivers/net/ethernet/google/gve/gve.h
index 4d01c66d2d65..98eb78d98e9f 100644
--- a/drivers/net/ethernet/google/gve/gve.h
+++ b/drivers/net/ethernet/google/gve/gve.h
@@ -49,8 +49,6 @@
#define GVE_XDP_ACTIONS 5
-#define GVE_TX_MAX_HEADER_SIZE 182
-
#define GVE_GQ_TX_MIN_PKT_DESC_BYTES 182
/* Each slot in the desc ring has a 1:1 mapping to a slot in the data ring */
diff --git a/drivers/net/ethernet/google/gve/gve_tx.c b/drivers/net/ethernet/google/gve/gve_tx.c
index fe6b933e1df1..813da572abca 100644
--- a/drivers/net/ethernet/google/gve/gve_tx.c
+++ b/drivers/net/ethernet/google/gve/gve_tx.c
@@ -730,7 +730,7 @@ static int gve_tx_fill_xdp(struct gve_priv *priv, struct gve_tx_ring *tx,
u32 reqi = tx->req;
pad = gve_tx_fifo_pad_alloc_one_frag(&tx->tx_fifo, len);
- if (pad >= GVE_TX_MAX_HEADER_SIZE)
+ if (pad >= GVE_GQ_TX_MIN_PKT_DESC_BYTES)
pad = 0;
info = &tx->info[reqi & tx->mask];
info->xdp_frame = frame_p;
@@ -810,7 +810,7 @@ int gve_xdp_xmit_one(struct gve_priv *priv, struct gve_tx_ring *tx,
{
int nsegs;
- if (!gve_can_tx(tx, len + GVE_TX_MAX_HEADER_SIZE - 1))
+ if (!gve_can_tx(tx, len + GVE_GQ_TX_MIN_PKT_DESC_BYTES - 1))
return -EBUSY;
nsegs = gve_tx_fill_xdp(priv, tx, data, len, frame_p, false);
--
2.40.0.577.gac1e443424-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] gve: Unify duplicate GQ min pkt desc size constants
2023-04-07 18:48 [PATCH net-next] gve: Unify duplicate GQ min pkt desc size constants Shailend Chand
@ 2023-04-08 3:24 ` Jakub Kicinski
2023-04-11 13:50 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Jakub Kicinski @ 2023-04-08 3:24 UTC (permalink / raw)
To: Shailend Chand; +Cc: netdev, davem
On Fri, 7 Apr 2023 11:48:30 -0700 Shailend Chand wrote:
> The two constants accomplish the same thing.
>
> Signed-off-by: Shailend Chand <shailend@google.com>
Reviewed-by: Jakub Kicinski <kuba@kernel.org>
Thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] gve: Unify duplicate GQ min pkt desc size constants
2023-04-07 18:48 [PATCH net-next] gve: Unify duplicate GQ min pkt desc size constants Shailend Chand
2023-04-08 3:24 ` Jakub Kicinski
@ 2023-04-11 13:50 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-04-11 13:50 UTC (permalink / raw)
To: Shailend Chand; +Cc: netdev, davem, kuba
Hello:
This patch was applied to netdev/net-next.git (main)
by Paolo Abeni <pabeni@redhat.com>:
On Fri, 7 Apr 2023 11:48:30 -0700 you wrote:
> The two constants accomplish the same thing.
>
> Signed-off-by: Shailend Chand <shailend@google.com>
> ---
> drivers/net/ethernet/google/gve/gve.h | 2 --
> drivers/net/ethernet/google/gve/gve_tx.c | 4 ++--
> 2 files changed, 2 insertions(+), 4 deletions(-)
Here is the summary with links:
- [net-next] gve: Unify duplicate GQ min pkt desc size constants
https://git.kernel.org/netdev/net-next/c/4de00f0acc72
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-04-11 13:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-04-07 18:48 [PATCH net-next] gve: Unify duplicate GQ min pkt desc size constants Shailend Chand
2023-04-08 3:24 ` Jakub Kicinski
2023-04-11 13:50 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).