* [PATCH] net: hyperv: select CONFIG_NLS for mac address setting
@ 2023-04-17 20:55 Arnd Bergmann
2023-04-19 3:54 ` Jakub Kicinski
2023-04-19 19:25 ` Simon Horman
0 siblings, 2 replies; 3+ messages in thread
From: Arnd Bergmann @ 2023-04-17 20:55 UTC (permalink / raw)
To: K. Y. Srinivasan, Haiyang Zhang, Wei Liu, Dexuan Cui,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Saurabh Sengar, Michael Kelley
Cc: Arnd Bergmann, linux-hyperv, netdev, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
A rare randconfig build error happens when this driver is
enabled, but nothing else enables NLS support:
x86_64-linux-ld: drivers/net/hyperv/rndis_filter.o: in function `rndis_filter_set_device_mac':
rndis_filter.c:(.text+0x1536): undefined reference to `utf8s_to_utf16s'
This is normally selected by PCI, USB, ACPI, or common file systems.
Since the dependency on ACPI is now gone, NLS has to be selected
here directly.
Fixes: 38299f300c12 ("Driver: VMBus: Add Devicetree support")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/net/hyperv/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/hyperv/Kconfig b/drivers/net/hyperv/Kconfig
index ca7bf7f897d3..924dad26ad47 100644
--- a/drivers/net/hyperv/Kconfig
+++ b/drivers/net/hyperv/Kconfig
@@ -2,6 +2,7 @@
config HYPERV_NET
tristate "Microsoft Hyper-V virtual network driver"
depends on HYPERV
+ select NLS
select UCS2_STRING
help
Select this option to enable the Hyper-V virtual network driver.
--
2.39.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] net: hyperv: select CONFIG_NLS for mac address setting
2023-04-17 20:55 [PATCH] net: hyperv: select CONFIG_NLS for mac address setting Arnd Bergmann
@ 2023-04-19 3:54 ` Jakub Kicinski
2023-04-19 19:25 ` Simon Horman
1 sibling, 0 replies; 3+ messages in thread
From: Jakub Kicinski @ 2023-04-19 3:54 UTC (permalink / raw)
To: Arnd Bergmann
Cc: K. Y. Srinivasan, Haiyang Zhang, Wei Liu, Dexuan Cui,
David S. Miller, Eric Dumazet, Paolo Abeni, Saurabh Sengar,
Michael Kelley, Arnd Bergmann, linux-hyperv, netdev,
linux-kernel
On Mon, 17 Apr 2023 22:55:48 +0200 Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> A rare randconfig build error happens when this driver is
> enabled, but nothing else enables NLS support:
>
> x86_64-linux-ld: drivers/net/hyperv/rndis_filter.o: in function `rndis_filter_set_device_mac':
> rndis_filter.c:(.text+0x1536): undefined reference to `utf8s_to_utf16s'
>
> This is normally selected by PCI, USB, ACPI, or common file systems.
> Since the dependency on ACPI is now gone, NLS has to be selected
> here directly.
>
> Fixes: 38299f300c12 ("Driver: VMBus: Add Devicetree support")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
I'm assuming Wei will take this since the offending commit doesn't
exist in netdev, yet:
Acked-by: Jakub Kicinski <kuba@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net: hyperv: select CONFIG_NLS for mac address setting
2023-04-17 20:55 [PATCH] net: hyperv: select CONFIG_NLS for mac address setting Arnd Bergmann
2023-04-19 3:54 ` Jakub Kicinski
@ 2023-04-19 19:25 ` Simon Horman
1 sibling, 0 replies; 3+ messages in thread
From: Simon Horman @ 2023-04-19 19:25 UTC (permalink / raw)
To: Arnd Bergmann
Cc: K. Y. Srinivasan, Haiyang Zhang, Wei Liu, Dexuan Cui,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Saurabh Sengar, Michael Kelley, Arnd Bergmann, linux-hyperv,
netdev, linux-kernel
On Mon, Apr 17, 2023 at 10:55:48PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> A rare randconfig build error happens when this driver is
> enabled, but nothing else enables NLS support:
>
> x86_64-linux-ld: drivers/net/hyperv/rndis_filter.o: in function `rndis_filter_set_device_mac':
> rndis_filter.c:(.text+0x1536): undefined reference to `utf8s_to_utf16s'
>
> This is normally selected by PCI, USB, ACPI, or common file systems.
> Since the dependency on ACPI is now gone, NLS has to be selected
> here directly.
>
> Fixes: 38299f300c12 ("Driver: VMBus: Add Devicetree support")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-04-19 19:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-04-17 20:55 [PATCH] net: hyperv: select CONFIG_NLS for mac address setting Arnd Bergmann
2023-04-19 3:54 ` Jakub Kicinski
2023-04-19 19:25 ` Simon Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).