From: Hao Chen <chenh@yusur.tech>
To: "Michael S. Tsirkin" <mst@redhat.com>,
Jason Wang <jasowang@redhat.com>,
Xuan Zhuo <xuanzhuo@linux.alibaba.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
virtualization@lists.linux-foundation.org (open list:VIRTIO CORE
AND NET DRIVERS),
netdev@vger.kernel.org (open list:NETWORKING DRIVERS),
linux-kernel@vger.kernel.org (open list)
Cc: huangml@yusur.tech, zy@yusur.tech
Subject: [PATCH] virtio_net: set default mtu to 1500 when 'Device maximum MTU' bigger than 1500
Date: Sat, 6 May 2023 10:15:29 +0800 [thread overview]
Message-ID: <20230506021529.396812-1-chenh@yusur.tech> (raw)
When VIRTIO_NET_F_MTU(3) Device maximum MTU reporting is supported.
If offered by the device, device advises driver about the value of its
maximum MTU. If negotiated, the driver uses mtu as the maximum
MTU value. But there the driver also uses it as default mtu,
some devices may have a maximum MTU greater than 1500, this may
cause some large packages to be discarded, so I changed the MTU to a more
general 1500 when 'Device maximum MTU' bigger than 1500.
Signed-off-by: Hao Chen <chenh@yusur.tech>
---
drivers/net/virtio_net.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
index 8d8038538fc4..e71c7d1b5f29 100644
--- a/drivers/net/virtio_net.c
+++ b/drivers/net/virtio_net.c
@@ -4040,7 +4040,10 @@ static int virtnet_probe(struct virtio_device *vdev)
goto free;
}
- dev->mtu = mtu;
+ if (mtu > 1500)
+ dev->mtu = 1500;
+ else
+ dev->mtu = mtu;
dev->max_mtu = mtu;
}
--
2.27.0
next reply other threads:[~2023-05-06 2:15 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-06 2:15 Hao Chen [this message]
2023-05-06 2:50 ` [PATCH] virtio_net: set default mtu to 1500 when 'Device maximum MTU' bigger than 1500 Xuan Zhuo
2023-05-06 8:56 ` Hao Chen
2023-05-07 8:58 ` Michael S. Tsirkin
2023-05-08 2:01 ` Xuan Zhuo
2023-05-08 6:15 ` Michael S. Tsirkin
2023-05-08 6:18 ` Xuan Zhuo
2023-05-08 6:43 ` Michael S. Tsirkin
2023-05-08 7:41 ` Xuan Zhuo
2023-05-08 10:30 ` Michael S. Tsirkin
2023-05-08 16:25 ` Stephen Hemminger
2023-05-08 18:10 ` Michael S. Tsirkin
2023-05-09 1:51 ` Xuan Zhuo
2023-05-07 9:31 ` David Woodhouse
2023-05-07 13:38 ` Michael S. Tsirkin
2023-05-07 5:59 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230506021529.396812-1-chenh@yusur.tech \
--to=chenh@yusur.tech \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=huangml@yusur.tech \
--cc=jasowang@redhat.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=xuanzhuo@linux.alibaba.com \
--cc=zy@yusur.tech \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).