From: "Michael S. Tsirkin" <mst@redhat.com>
To: David Woodhouse <dwmw2@infradead.org>
Cc: Hao Chen <chenh@yusur.tech>,
Xuan Zhuo <xuanzhuo@linux.alibaba.com>,
huangml@yusur.tech, zy@yusur.tech,
Jason Wang <jasowang@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
"open list:VIRTIO CORE AND NET DRIVERS"
<virtualization@lists.linux-foundation.org>,
"open list:NETWORKING DRIVERS" <netdev@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] virtio_net: set default mtu to 1500 when 'Device maximum MTU' bigger than 1500
Date: Sun, 7 May 2023 09:38:13 -0400 [thread overview]
Message-ID: <20230507093502-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <49455AA8-0606-447E-B455-F905EA184E42@infradead.org>
On Sun, May 07, 2023 at 10:31:34AM +0100, David Woodhouse wrote:
>
>
> On 6 May 2023 09:56:35 BST, Hao Chen <chenh@yusur.tech> wrote:
> >In the current code, if the maximum MTU supported by the virtio net hardware is 9000, the default MTU of the virtio net driver will also be set to 9000. When sending packets through "ping -s 5000", if the peer router does not support negotiating a path MTU through ICMP packets, the packets will be discarded.
>
> That router is just plain broken, and it's going to break all kinds of traffic. Hacking the virtio-net MTU is only a partial workaround.
>
> Surely the correct fix here is to apply percussive education to whatever idiot thought it was OK to block ICMP. Not to hack the default MTU of one device to the lowest common denominator.
Yea I don't understand what does path MTU have to do with it.
MTU has to be set the same for all endpoints on LAN, that's
a fundamental assumption that ethernet makes. Going outside LAN
all best are off.
--
MST
next prev parent reply other threads:[~2023-05-07 13:38 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-06 2:15 [PATCH] virtio_net: set default mtu to 1500 when 'Device maximum MTU' bigger than 1500 Hao Chen
2023-05-06 2:50 ` Xuan Zhuo
2023-05-06 8:56 ` Hao Chen
2023-05-07 8:58 ` Michael S. Tsirkin
2023-05-08 2:01 ` Xuan Zhuo
2023-05-08 6:15 ` Michael S. Tsirkin
2023-05-08 6:18 ` Xuan Zhuo
2023-05-08 6:43 ` Michael S. Tsirkin
2023-05-08 7:41 ` Xuan Zhuo
2023-05-08 10:30 ` Michael S. Tsirkin
2023-05-08 16:25 ` Stephen Hemminger
2023-05-08 18:10 ` Michael S. Tsirkin
2023-05-09 1:51 ` Xuan Zhuo
2023-05-07 9:31 ` David Woodhouse
2023-05-07 13:38 ` Michael S. Tsirkin [this message]
2023-05-07 5:59 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230507093502-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=chenh@yusur.tech \
--cc=davem@davemloft.net \
--cc=dwmw2@infradead.org \
--cc=edumazet@google.com \
--cc=huangml@yusur.tech \
--cc=jasowang@redhat.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=xuanzhuo@linux.alibaba.com \
--cc=zy@yusur.tech \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).