* [PATCH] net: dsa: qca8k: add CONFIG_LEDS_TRIGGERS dependency
@ 2023-06-01 21:31 Arnd Bergmann
2023-06-02 10:00 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2023-06-01 21:31 UTC (permalink / raw)
To: Andrew Lunn, Florian Fainelli, Vladimir Oltean, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, Christian Marangi
Cc: Arnd Bergmann, netdev, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
Without LED triggers, the driver now fails to build:
drivers/net/dsa/qca/qca8k-leds.c: In function 'qca8k_parse_port_leds':
drivers/net/dsa/qca/qca8k-leds.c:403:31: error: 'struct led_classdev' has no member named 'hw_control_is_supported'
403 | port_led->cdev.hw_control_is_supported = qca8k_cled_hw_control_is_supported;
| ^
There is a mix of 'depends on' and 'select' for LEDS_TRIGGERS, so it's
not clear what we should use here, but in general using 'depends on'
causes fewer problems, so use that.
Fixes: e0256648c831a ("net: dsa: qca8k: implement hw_control ops")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/net/dsa/qca/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/dsa/qca/Kconfig b/drivers/net/dsa/qca/Kconfig
index 4347b42c50fd2..de9da469908bc 100644
--- a/drivers/net/dsa/qca/Kconfig
+++ b/drivers/net/dsa/qca/Kconfig
@@ -20,6 +20,7 @@ config NET_DSA_QCA8K_LEDS_SUPPORT
bool "Qualcomm Atheros QCA8K Ethernet switch family LEDs support"
depends on NET_DSA_QCA8K
depends on LEDS_CLASS=y || LEDS_CLASS=NET_DSA_QCA8K
+ depends on LEDS_TRIGGERS
help
This enabled support for LEDs present on the Qualcomm Atheros
QCA8K Ethernet switch chips.
--
2.39.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net: dsa: qca8k: add CONFIG_LEDS_TRIGGERS dependency
2023-06-01 21:31 [PATCH] net: dsa: qca8k: add CONFIG_LEDS_TRIGGERS dependency Arnd Bergmann
@ 2023-06-02 10:00 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-06-02 10:00 UTC (permalink / raw)
To: Arnd Bergmann
Cc: andrew, f.fainelli, olteanv, davem, edumazet, kuba, pabeni,
ansuelsmth, arnd, netdev, linux-kernel
Hello:
This patch was applied to netdev/net.git (main)
by David S. Miller <davem@davemloft.net>:
On Thu, 1 Jun 2023 23:31:04 +0200 you wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> Without LED triggers, the driver now fails to build:
>
> drivers/net/dsa/qca/qca8k-leds.c: In function 'qca8k_parse_port_leds':
> drivers/net/dsa/qca/qca8k-leds.c:403:31: error: 'struct led_classdev' has no member named 'hw_control_is_supported'
> 403 | port_led->cdev.hw_control_is_supported = qca8k_cled_hw_control_is_supported;
> | ^
>
> [...]
Here is the summary with links:
- net: dsa: qca8k: add CONFIG_LEDS_TRIGGERS dependency
https://git.kernel.org/netdev/net/c/37a826d86ff7
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-06-02 10:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-01 21:31 [PATCH] net: dsa: qca8k: add CONFIG_LEDS_TRIGGERS dependency Arnd Bergmann
2023-06-02 10:00 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).