From: Kuniyuki Iwashima <kuniyu@amazon.com>
To: <edumazet@google.com>
Cc: <davem@davemloft.net>, <eric.dumazet@gmail.com>,
<kuba@kernel.org>, <netdev@vger.kernel.org>, <pabeni@redhat.com>,
<kuniyu@amazon.com>
Subject: Re: [PATCH net 1/2] rfs: annotate lockless accesses to sk->sk_rxhash
Date: Fri, 2 Jun 2023 13:20:28 -0700 [thread overview]
Message-ID: <20230602202028.49984-1-kuniyu@amazon.com> (raw)
In-Reply-To: <20230602163141.2115187-2-edumazet@google.com>
From: Eric Dumazet <edumazet@google.com>
Date: Fri, 2 Jun 2023 16:31:40 +0000
> Add READ_ONCE()/WRITE_ONCE() on accesses to sk->sk_rxhash.
>
> This also prevents a (smart ?) compiler to remove the condition in:
>
> if (sk->sk_rxhash != newval)
> sk->sk_rxhash = newval;
>
> We need the condition to avoid dirtying a shared cache line.
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> ---
> include/net/sock.h | 18 +++++++++++++-----
> 1 file changed, 13 insertions(+), 5 deletions(-)
>
> diff --git a/include/net/sock.h b/include/net/sock.h
> index b418425d7230c8cee81df34fcc66d771ea5085e9..bf71855d47feccda716b3cabf259d6055b764a3c 100644
> --- a/include/net/sock.h
> +++ b/include/net/sock.h
> @@ -1152,8 +1152,12 @@ static inline void sock_rps_record_flow(const struct sock *sk)
> * OR an additional socket flag
> * [1] : sk_state and sk_prot are in the same cache line.
> */
> - if (sk->sk_state == TCP_ESTABLISHED)
> - sock_rps_record_flow_hash(sk->sk_rxhash);
> + if (sk->sk_state == TCP_ESTABLISHED) {
> + /* This READ_ONCE() is paired with the WRITE_ONCE()
> + * from sock_rps_save_rxhash() and sock_rps_reset_rxhash().
> + */
> + sock_rps_record_flow_hash(READ_ONCE(sk->sk_rxhash));
> + }
nit: unnecessary \t here
other than that
Reviewed-by: Kuniyuki Iwashima <kuniyu@amazon.com>
Thanks!
> }
> #endif
> }
> @@ -1162,15 +1166,19 @@ static inline void sock_rps_save_rxhash(struct sock *sk,
> const struct sk_buff *skb)
> {
> #ifdef CONFIG_RPS
> - if (unlikely(sk->sk_rxhash != skb->hash))
> - sk->sk_rxhash = skb->hash;
> + /* The following WRITE_ONCE() is paired with the READ_ONCE()
> + * here, and another one in sock_rps_record_flow().
> + */
> + if (unlikely(READ_ONCE(sk->sk_rxhash) != skb->hash))
> + WRITE_ONCE(sk->sk_rxhash, skb->hash);
> #endif
> }
>
> static inline void sock_rps_reset_rxhash(struct sock *sk)
> {
> #ifdef CONFIG_RPS
> - sk->sk_rxhash = 0;
> + /* Paired with READ_ONCE() in sock_rps_record_flow() */
> + WRITE_ONCE(sk->sk_rxhash, 0);
> #endif
> }
>
> --
> 2.41.0.rc0.172.g3f132b7071-goog
next prev parent reply other threads:[~2023-06-02 20:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-02 16:31 [PATCH net 0/2] rfs: annotate lockless accesses Eric Dumazet
2023-06-02 16:31 ` [PATCH net 1/2] rfs: annotate lockless accesses to sk->sk_rxhash Eric Dumazet
2023-06-02 20:20 ` Kuniyuki Iwashima [this message]
2023-06-05 22:52 ` Jakub Kicinski
2023-06-06 7:30 ` Eric Dumazet
2023-06-06 7:43 ` Eric Dumazet
2023-06-06 9:44 ` Simon Horman
2023-06-02 16:31 ` [PATCH net 2/2] rfs: annotate lockless accesses to RFS sock flow table Eric Dumazet
2023-06-02 20:27 ` Kuniyuki Iwashima
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230602202028.49984-1-kuniyu@amazon.com \
--to=kuniyu@amazon.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).