netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric Dumazet <edumazet@google.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: "David S . Miller" <davem@davemloft.net>,
	Paolo Abeni <pabeni@redhat.com>,
	netdev@vger.kernel.org,  eric.dumazet@gmail.com
Subject: Re: [PATCH net 1/2] rfs: annotate lockless accesses to sk->sk_rxhash
Date: Tue, 6 Jun 2023 09:30:12 +0200	[thread overview]
Message-ID: <CANn89iKhSv981L-WHn=479U2XniQXU0qNX=yoAaWBA1LdY4B4g@mail.gmail.com> (raw)
In-Reply-To: <20230605155253.1cedfdb0@kernel.org>

On Tue, Jun 6, 2023 at 12:52 AM Jakub Kicinski <kuba@kernel.org> wrote:
>
> On Fri,  2 Jun 2023 16:31:40 +0000 Eric Dumazet wrote:
> > +             if (sk->sk_state == TCP_ESTABLISHED) {
> > +                     /* This READ_ONCE() is paired with the WRITE_ONCE()
> > +                      * from sock_rps_save_rxhash() and sock_rps_reset_rxhash().
> > +                      */
> > +                     sock_rps_record_flow_hash(READ_ONCE(sk->sk_rxhash));
> > +                     }
>
> Hi Eric, the series got "changes requested", a bit unclear why,
> I'm guessing it's because it lacks Fixes tags.
>
> I also noticed that the closing bracket above looks misaligned.

Right I think Simon gave this feedback.

>
> Would you mind reposting? If you prefer not to add Fixes tag
> a mention that it's intentional in the cover letter is enough.

Yes, I do not think a Fixes: tag is necessary.

I will post a v2 with an aligned closing bracket.

Thanks.

  reply	other threads:[~2023-06-06  7:30 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-02 16:31 [PATCH net 0/2] rfs: annotate lockless accesses Eric Dumazet
2023-06-02 16:31 ` [PATCH net 1/2] rfs: annotate lockless accesses to sk->sk_rxhash Eric Dumazet
2023-06-02 20:20   ` Kuniyuki Iwashima
2023-06-05 22:52   ` Jakub Kicinski
2023-06-06  7:30     ` Eric Dumazet [this message]
2023-06-06  7:43       ` Eric Dumazet
2023-06-06  9:44       ` Simon Horman
2023-06-02 16:31 ` [PATCH net 2/2] rfs: annotate lockless accesses to RFS sock flow table Eric Dumazet
2023-06-02 20:27   ` Kuniyuki Iwashima

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CANn89iKhSv981L-WHn=479U2XniQXU0qNX=yoAaWBA1LdY4B4g@mail.gmail.com' \
    --to=edumazet@google.com \
    --cc=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).