From: Shakeel Butt <shakeelb@google.com>
To: Abel Wu <wuyun.abel@bytedance.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@kernel.org>,
Vladimir Davydov <vdavydov.dev@gmail.com>,
Muchun Song <muchun.song@linux.dev>,
Simon Horman <simon.horman@corigine.com>,
netdev@vger.kernel.org, linux-mm@kvack.org,
cgroups@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v5 3/3] sock: Fix misuse of sk_under_memory_pressure()
Date: Fri, 2 Jun 2023 20:53:22 +0000 [thread overview]
Message-ID: <20230602205322.ehxm2q2mbg5laa5s@google.com> (raw)
In-Reply-To: <20230602081135.75424-4-wuyun.abel@bytedance.com>
On Fri, Jun 02, 2023 at 04:11:35PM +0800, Abel Wu wrote:
> The status of global socket memory pressure is updated when:
>
> a) __sk_mem_raise_allocated():
>
> enter: sk_memory_allocated(sk) > sysctl_mem[1]
> leave: sk_memory_allocated(sk) <= sysctl_mem[0]
>
> b) __sk_mem_reduce_allocated():
>
> leave: sk_under_memory_pressure(sk) &&
> sk_memory_allocated(sk) < sysctl_mem[0]
There is also sk_page_frag_refill() where we can enter the global
protocol memory pressure on actual global memory pressure i.e. page
allocation failed. However this might be irrelevant from this patch's
perspective as the focus is on the leaving part.
>
> So the conditions of leaving global pressure are inconstant, which
*inconsistent
> may lead to the situation that one pressured net-memcg prevents the
> global pressure from being cleared when there is indeed no global
> pressure, thus the global constrains are still in effect unexpectedly
> on the other sockets.
>
> This patch fixes this by ignoring the net-memcg's pressure when
> deciding whether should leave global memory pressure.
>
> Fixes: e1aab161e013 ("socket: initial cgroup code.")
> Signed-off-by: Abel Wu <wuyun.abel@bytedance.com>
This patch looks good.
next prev parent reply other threads:[~2023-06-02 20:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-02 8:11 [PATCH net-next v5 0/3] sock: Improve condition on sockmem pressure Abel Wu
2023-06-02 8:11 ` [PATCH net-next v5 1/3] net-memcg: Fold dependency into memcg pressure cond Abel Wu
2023-06-02 20:25 ` Shakeel Butt
2023-06-05 11:52 ` Abel Wu
2023-06-02 8:11 ` [PATCH net-next v5 2/3] sock: Always take memcg pressure into consideration Abel Wu
2023-06-02 20:41 ` Shakeel Butt
2023-06-04 10:36 ` Willem de Bruijn
2023-06-05 3:44 ` Abel Wu
2023-06-05 8:27 ` Paolo Abeni
2023-06-05 9:57 ` Abel Wu
2023-06-02 8:11 ` [PATCH net-next v5 3/3] sock: Fix misuse of sk_under_memory_pressure() Abel Wu
2023-06-02 20:53 ` Shakeel Butt [this message]
2023-06-05 8:34 ` Abel Wu
2023-06-06 8:39 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230602205322.ehxm2q2mbg5laa5s@google.com \
--to=shakeelb@google.com \
--cc=cgroups@vger.kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hannes@cmpxchg.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=muchun.song@linux.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=simon.horman@corigine.com \
--cc=vdavydov.dev@gmail.com \
--cc=wuyun.abel@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).