netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net-next] dt-bindings: net: bluetooth: qualcomm: document VDD_CH1
@ 2023-06-17 16:57 Krzysztof Kozlowski
  2023-06-17 20:38 ` Conor Dooley
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2023-06-17 16:57 UTC (permalink / raw)
  To: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Balakrishna Godavarthi, Rocky Liao, netdev, devicetree,
	linux-kernel
  Cc: Krzysztof Kozlowski

WCN3990 comes with two chains - CH0 and CH1 - where each takes VDD
regulator.  It seems VDD_CH1 is optional (Linux driver does not care
about it), so document it to fix dtbs_check warnings like:

  sdm850-lenovo-yoga-c630.dtb: bluetooth: 'vddch1-supply' does not match any of the regexes: 'pinctrl-[0-9]+'

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 .../devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml  | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml b/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml
index e3a51d66527c..2735c6a4f336 100644
--- a/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml
+++ b/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml
@@ -52,6 +52,9 @@ properties:
   vddch0-supply:
     description: VDD_CH0 supply regulator handle
 
+  vddch1-supply:
+    description: VDD_CH1 supply regulator handle
+
   vddaon-supply:
     description: VDD_AON supply regulator handle
 
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH net-next] dt-bindings: net: bluetooth: qualcomm: document VDD_CH1
  2023-06-17 16:57 [PATCH net-next] dt-bindings: net: bluetooth: qualcomm: document VDD_CH1 Krzysztof Kozlowski
@ 2023-06-17 20:38 ` Conor Dooley
  2023-06-20 18:14 ` Jakub Kicinski
  2023-06-22  0:00 ` patchwork-bot+netdevbpf
  2 siblings, 0 replies; 6+ messages in thread
From: Conor Dooley @ 2023-06-17 20:38 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Balakrishna Godavarthi, Rocky Liao, netdev, devicetree,
	linux-kernel

[-- Attachment #1: Type: text/plain, Size: 540 bytes --]

On Sat, Jun 17, 2023 at 06:57:16PM +0200, Krzysztof Kozlowski wrote:
> WCN3990 comes with two chains - CH0 and CH1 - where each takes VDD
> regulator.  It seems VDD_CH1 is optional (Linux driver does not care
> about it), so document it to fix dtbs_check warnings like:
> 
>   sdm850-lenovo-yoga-c630.dtb: bluetooth: 'vddch1-supply' does not match any of the regexes: 'pinctrl-[0-9]+'
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Acked-by: Conor Dooley <conor.dooley@microchip.com>

Cheers,
Conor.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH net-next] dt-bindings: net: bluetooth: qualcomm: document VDD_CH1
  2023-06-17 16:57 [PATCH net-next] dt-bindings: net: bluetooth: qualcomm: document VDD_CH1 Krzysztof Kozlowski
  2023-06-17 20:38 ` Conor Dooley
@ 2023-06-20 18:14 ` Jakub Kicinski
  2023-06-21  6:05   ` Krzysztof Kozlowski
  2023-06-22  0:00 ` patchwork-bot+netdevbpf
  2 siblings, 1 reply; 6+ messages in thread
From: Jakub Kicinski @ 2023-06-20 18:14 UTC (permalink / raw)
  To: Luiz Augusto von Dentz
  Cc: Krzysztof Kozlowski, David S. Miller, Eric Dumazet, Paolo Abeni,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Balakrishna Godavarthi, Rocky Liao, netdev, devicetree,
	linux-kernel

On Sat, 17 Jun 2023 18:57:16 +0200 Krzysztof Kozlowski wrote:
> WCN3990 comes with two chains - CH0 and CH1 - where each takes VDD
> regulator.  It seems VDD_CH1 is optional (Linux driver does not care
> about it), so document it to fix dtbs_check warnings like:
> 
>   sdm850-lenovo-yoga-c630.dtb: bluetooth: 'vddch1-supply' does not match any of the regexes: 'pinctrl-[0-9]+'
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Hi Luiz, I don't see you CCed here, should we take it directly 
to net-next?

> diff --git a/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml b/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml
> index e3a51d66527c..2735c6a4f336 100644
> --- a/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml
> +++ b/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml
> @@ -52,6 +52,9 @@ properties:
>    vddch0-supply:
>      description: VDD_CH0 supply regulator handle
>  
> +  vddch1-supply:
> +    description: VDD_CH1 supply regulator handle
> +
>    vddaon-supply:
>      description: VDD_AON supply regulator handle
>  


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH net-next] dt-bindings: net: bluetooth: qualcomm: document VDD_CH1
  2023-06-20 18:14 ` Jakub Kicinski
@ 2023-06-21  6:05   ` Krzysztof Kozlowski
  2023-06-21 23:54     ` Jakub Kicinski
  0 siblings, 1 reply; 6+ messages in thread
From: Krzysztof Kozlowski @ 2023-06-21  6:05 UTC (permalink / raw)
  To: Jakub Kicinski, Luiz Augusto von Dentz
  Cc: David S. Miller, Eric Dumazet, Paolo Abeni, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Balakrishna Godavarthi,
	Rocky Liao, netdev, devicetree, linux-kernel

On 20/06/2023 20:14, Jakub Kicinski wrote:
> On Sat, 17 Jun 2023 18:57:16 +0200 Krzysztof Kozlowski wrote:
>> WCN3990 comes with two chains - CH0 and CH1 - where each takes VDD
>> regulator.  It seems VDD_CH1 is optional (Linux driver does not care
>> about it), so document it to fix dtbs_check warnings like:
>>
>>   sdm850-lenovo-yoga-c630.dtb: bluetooth: 'vddch1-supply' does not match any of the regexes: 'pinctrl-[0-9]+'
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> Hi Luiz, I don't see you CCed here, should we take it directly 
> to net-next?

Bluetooth bindings are not part of BLUETOOTH entry, so obviously no Cc
for bluetooth maintainers. I'll send a patch to update maintainers.

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH net-next] dt-bindings: net: bluetooth: qualcomm: document VDD_CH1
  2023-06-21  6:05   ` Krzysztof Kozlowski
@ 2023-06-21 23:54     ` Jakub Kicinski
  0 siblings, 0 replies; 6+ messages in thread
From: Jakub Kicinski @ 2023-06-21 23:54 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Luiz Augusto von Dentz, David S. Miller, Eric Dumazet,
	Paolo Abeni, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Balakrishna Godavarthi, Rocky Liao, netdev, devicetree,
	linux-kernel

On Wed, 21 Jun 2023 08:05:50 +0200 Krzysztof Kozlowski wrote:
> On 20/06/2023 20:14, Jakub Kicinski wrote:
> > Hi Luiz, I don't see you CCed here, should we take it directly 
> > to net-next?  

Lemme take it, it's trivial enough.

> Bluetooth bindings are not part of BLUETOOTH entry, so obviously no Cc
> for bluetooth maintainers. I'll send a patch to update maintainers.

Thanks!!

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH net-next] dt-bindings: net: bluetooth: qualcomm: document VDD_CH1
  2023-06-17 16:57 [PATCH net-next] dt-bindings: net: bluetooth: qualcomm: document VDD_CH1 Krzysztof Kozlowski
  2023-06-17 20:38 ` Conor Dooley
  2023-06-20 18:14 ` Jakub Kicinski
@ 2023-06-22  0:00 ` patchwork-bot+netdevbpf
  2 siblings, 0 replies; 6+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-06-22  0:00 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: davem, edumazet, kuba, pabeni, robh+dt, krzysztof.kozlowski+dt,
	conor+dt, bgodavar, rjliao, netdev, devicetree, linux-kernel

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Sat, 17 Jun 2023 18:57:16 +0200 you wrote:
> WCN3990 comes with two chains - CH0 and CH1 - where each takes VDD
> regulator.  It seems VDD_CH1 is optional (Linux driver does not care
> about it), so document it to fix dtbs_check warnings like:
> 
>   sdm850-lenovo-yoga-c630.dtb: bluetooth: 'vddch1-supply' does not match any of the regexes: 'pinctrl-[0-9]+'
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> [...]

Here is the summary with links:
  - [net-next] dt-bindings: net: bluetooth: qualcomm: document VDD_CH1
    https://git.kernel.org/netdev/net-next/c/6a0a6dd8df9b

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2023-06-22  0:00 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-17 16:57 [PATCH net-next] dt-bindings: net: bluetooth: qualcomm: document VDD_CH1 Krzysztof Kozlowski
2023-06-17 20:38 ` Conor Dooley
2023-06-20 18:14 ` Jakub Kicinski
2023-06-21  6:05   ` Krzysztof Kozlowski
2023-06-21 23:54     ` Jakub Kicinski
2023-06-22  0:00 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).