[PATCH net-next v1 1/1] wwan: core: Use the bitmap API to allocate bitmaps

[PATCH net-next v1 1/1] wwan: core: Use the bitmap API to allocate bitmaps

[Andy Shevchenko]

Use bitmap_zalloc() and bitmap_free() instead of hand-writing them.
It is less verbose and it improves the type checking and semantic.

While at it, add missing header inclusion (should be bitops.h,
but with the above change it becomes bitmap.h).

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/net/wwan/wwan_core.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wwan/wwan_core.c b/drivers/net/wwan/wwan_core.c
index 284ab1f56391..87df60916960 100644
--- a/drivers/net/wwan/wwan_core.c
+++ b/drivers/net/wwan/wwan_core.c
@@ -1,6 +1,7 @@
 // SPDX-License-Identifier: GPL-2.0-only
 /* Copyright (c) 2021, Linaro Ltd <loic.poulain@linaro.org> */
 
+#include <linux/bitmap.h>
 #include <linux/err.h>
 #include <linux/errno.h>
 #include <linux/debugfs.h>
@@ -395,7 +396,7 @@ static int __wwan_port_dev_assign_name(struct wwan_port *port, const char *fmt)
 	char buf[0x20];
 	int id;
 
-	idmap = (unsigned long *)get_zeroed_page(GFP_KERNEL);
+	idmap = bitmap_zalloc(max_ports, GFP_KERNEL);
 	if (!idmap)
 		return -ENOMEM;
 
@@ -414,7 +415,7 @@ static int __wwan_port_dev_assign_name(struct wwan_port *port, const char *fmt)
 
 	/* Allocate unique id */
 	id = find_first_zero_bit(idmap, max_ports);
-	free_page((unsigned long)idmap);
+	bitmap_free(idmap);
 
 	snprintf(buf, sizeof(buf), fmt, id);	/* Name generation */
 
-- 
2.40.0.1.gaa8946217a0b

Re: [PATCH net-next v1 1/1] wwan: core: Use the bitmap API to allocate bitmaps

[Sergey Ryazanov]

On 28.08.2023 16:19, Andy Shevchenko wrote:
> Use bitmap_zalloc() and bitmap_free() instead of hand-writing them.
> It is less verbose and it improves the type checking and semantic.
> 
> While at it, add missing header inclusion (should be bitops.h,
> but with the above change it becomes bitmap.h).
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Make sense. Thank you.

BTW, any plans to update __dev_alloc_name(), which was used as 
reference, in the same way?

Reviewed-by: Sergey Ryazanov <ryazanov.s.a@gmail.com>

Re: [PATCH net-next v1 1/1] wwan: core: Use the bitmap API to allocate bitmaps

[Jakub Kicinski]

On Mon, 28 Aug 2023 16:19:53 +0300 Andy Shevchenko wrote:
> Use bitmap_zalloc() and bitmap_free() instead of hand-writing them.
> It is less verbose and it improves the type checking and semantic.
> 
> While at it, add missing header inclusion (should be bitops.h,
> but with the above change it becomes bitmap.h).

## Form letter - net-next-closed

The merge window for v6.6 has begun and therefore net-next is closed
for new drivers, features, code refactoring and optimizations.
We are currently accepting bug fixes only.

Please repost when net-next reopens after Sept 11th.

RFC patches sent for review only are obviously welcome at any time.

See: https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#development-cycle
-- 
pw-bot: defer

Re: [PATCH net-next v1 1/1] wwan: core: Use the bitmap API to allocate bitmaps

[Andy Shevchenko]

On Mon, Aug 28, 2023 at 09:06:09PM +0300, Sergey Ryazanov wrote:
> On 28.08.2023 16:19, Andy Shevchenko wrote:
> > Use bitmap_zalloc() and bitmap_free() instead of hand-writing them.
> > It is less verbose and it improves the type checking and semantic.
> > 
> > While at it, add missing header inclusion (should be bitops.h,
> > but with the above change it becomes bitmap.h).
> > 
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> 
> Make sense. Thank you.
> 
> BTW, any plans to update __dev_alloc_name(), which was used as reference, in
> the same way?

Ah, will look at it, thanks for the pointer.

> Reviewed-by: Sergey Ryazanov <ryazanov.s.a@gmail.com>

And thank you for the review!

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH net-next v1 1/1] wwan: core: Use the bitmap API to allocate bitmaps

[Andy Shevchenko]

On Mon, Aug 28, 2023 at 12:45:24PM -0700, Jakub Kicinski wrote:
> On Mon, 28 Aug 2023 16:19:53 +0300 Andy Shevchenko wrote:
> > Use bitmap_zalloc() and bitmap_free() instead of hand-writing them.
> > It is less verbose and it improves the type checking and semantic.
> > 
> > While at it, add missing header inclusion (should be bitops.h,
> > but with the above change it becomes bitmap.h).
> 
> ## Form letter - net-next-closed
> 
> The merge window for v6.6 has begun and therefore net-next is closed
> for new drivers, features, code refactoring and optimizations.
> We are currently accepting bug fixes only.

Sure.

> Please repost when net-next reopens after Sept 11th.

I'm wondering since we have established lore archive along with `b4` or any
analogous tool (since there is an API) why I need to repost. It increases
the SNR in the mailing lists, consumes more resources —> adds into global
climate change.

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH net-next v1 1/1] wwan: core: Use the bitmap API to allocate bitmaps

[Loic Poulain]

On Mon, 28 Aug 2023 at 15:22, Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> Use bitmap_zalloc() and bitmap_free() instead of hand-writing them.
> It is less verbose and it improves the type checking and semantic.
>
> While at it, add missing header inclusion (should be bitops.h,
> but with the above change it becomes bitmap.h).
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Reviewed-by: Loic Poulain <loic.poulain@linaro.org>