* [PATCH v2 net] igb: disable virtualization features on 82580
@ 2023-08-31 12:19 Corinna Vinschen
2023-09-01 13:43 ` Simon Horman
2023-09-03 13:12 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 4+ messages in thread
From: Corinna Vinschen @ 2023-08-31 12:19 UTC (permalink / raw)
To: Tony Nguyen, jesse.brandeburg, intel-wired-lan, netdev
Disable virtualization features on 82580 just as on i210/i211.
This avoids that virt functions are acidentally called on 82850.
Fixes: 55cac248caa4 ("igb: Add full support for 82580 devices")
Signed-off-by: Corinna Vinschen <vinschen@redhat.com>
---
drivers/net/ethernet/intel/igb/igb_main.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c
index 1ab787ed254d..13ba9c74bd84 100644
--- a/drivers/net/ethernet/intel/igb/igb_main.c
+++ b/drivers/net/ethernet/intel/igb/igb_main.c
@@ -3933,8 +3933,9 @@ static void igb_probe_vfs(struct igb_adapter *adapter)
struct pci_dev *pdev = adapter->pdev;
struct e1000_hw *hw = &adapter->hw;
- /* Virtualization features not supported on i210 family. */
- if ((hw->mac.type == e1000_i210) || (hw->mac.type == e1000_i211))
+ /* Virtualization features not supported on i210 and 82580 family. */
+ if ((hw->mac.type == e1000_i210) || (hw->mac.type == e1000_i211) ||
+ (hw->mac.type == e1000_82580))
return;
/* Of the below we really only want the effect of getting
--
2.31.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2 net] igb: disable virtualization features on 82580
2023-08-31 12:19 [PATCH v2 net] igb: disable virtualization features on 82580 Corinna Vinschen
@ 2023-09-01 13:43 ` Simon Horman
2023-09-03 13:12 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 4+ messages in thread
From: Simon Horman @ 2023-09-01 13:43 UTC (permalink / raw)
To: Corinna Vinschen; +Cc: Tony Nguyen, jesse.brandeburg, intel-wired-lan, netdev
On Thu, Aug 31, 2023 at 02:19:13PM +0200, Corinna Vinschen wrote:
> Disable virtualization features on 82580 just as on i210/i211.
> This avoids that virt functions are acidentally called on 82850.
>
> Fixes: 55cac248caa4 ("igb: Add full support for 82580 devices")
> Signed-off-by: Corinna Vinschen <vinschen@redhat.com>
Reviewed-by: Simon Horman <horms@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2 net] igb: disable virtualization features on 82580
2023-08-31 12:19 [PATCH v2 net] igb: disable virtualization features on 82580 Corinna Vinschen
2023-09-01 13:43 ` Simon Horman
@ 2023-09-03 13:12 ` patchwork-bot+netdevbpf
2023-09-04 8:54 ` Corinna Vinschen
1 sibling, 1 reply; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-09-03 13:12 UTC (permalink / raw)
To: Corinna Vinschen
Cc: anthony.l.nguyen, jesse.brandeburg, intel-wired-lan, netdev
Hello:
This patch was applied to netdev/net.git (main)
by David S. Miller <davem@davemloft.net>:
On Thu, 31 Aug 2023 14:19:13 +0200 you wrote:
> Disable virtualization features on 82580 just as on i210/i211.
> This avoids that virt functions are acidentally called on 82850.
>
> Fixes: 55cac248caa4 ("igb: Add full support for 82580 devices")
> Signed-off-by: Corinna Vinschen <vinschen@redhat.com>
> ---
> drivers/net/ethernet/intel/igb/igb_main.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
Here is the summary with links:
- [v2,net] igb: disable virtualization features on 82580
https://git.kernel.org/netdev/net/c/fa09bc40b21a
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2 net] igb: disable virtualization features on 82580
2023-09-03 13:12 ` patchwork-bot+netdevbpf
@ 2023-09-04 8:54 ` Corinna Vinschen
0 siblings, 0 replies; 4+ messages in thread
From: Corinna Vinschen @ 2023-09-04 8:54 UTC (permalink / raw)
To: David S. Miller
Cc: anthony.l.nguyen, jesse.brandeburg, intel-wired-lan, netdev
On Sep 3 13:12, patchwork-bot+netdevbpf@kernel.org wrote:
> Hello:
>
> This patch was applied to netdev/net.git (main)
> by David S. Miller <davem@davemloft.net>:
>
> On Thu, 31 Aug 2023 14:19:13 +0200 you wrote:
> > Disable virtualization features on 82580 just as on i210/i211.
> > This avoids that virt functions are acidentally called on 82850.
> >
> > Fixes: 55cac248caa4 ("igb: Add full support for 82580 devices")
> > Signed-off-by: Corinna Vinschen <vinschen@redhat.com>
> > ---
> > drivers/net/ethernet/intel/igb/igb_main.c | 5 +++--
> > 1 file changed, 3 insertions(+), 2 deletions(-)
>
> Here is the summary with links:
> - [v2,net] igb: disable virtualization features on 82580
> https://git.kernel.org/netdev/net/c/fa09bc40b21a
Thank you! Will my first patch
igb: clean up in all error paths when enabling SR-IOV
https://lore.kernel.org/netdev/20230824091603.3188249-1-vinschen@redhat.com/
get applied as well? While I reproduced this on 82580 only, there might
be some other reason why pci_enable_sriov() fails, independent of the
actual NIC.
Thanks,
Corinna
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-09-04 8:55 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-31 12:19 [PATCH v2 net] igb: disable virtualization features on 82580 Corinna Vinschen
2023-09-01 13:43 ` Simon Horman
2023-09-03 13:12 ` patchwork-bot+netdevbpf
2023-09-04 8:54 ` Corinna Vinschen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).