From: Catalin Popescu <catalin.popescu@leica-geosystems.com>
To: andrew@lunn.ch, hkallweit1@gmail.com, linux@armlinux.org.uk,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
bsp-development.geo@leica-geosystems.com,
m.felsch@pengutronix.de,
Catalin Popescu <catalin.popescu@leica-geosystems.com>
Subject: [PATCH] net: phy: dp83826: disable WOL at init
Date: Fri, 23 Feb 2024 15:31:27 +0100 [thread overview]
Message-ID: <20240223143127.1942129-1-catalin.popescu@leica-geosystems.com> (raw)
Commit d1d77120bc28 ("net: phy: dp83826: support TX data voltage tuning")
introduced a regression in that WOL is not disabled by default for DP83826.
WOL should normally be enabled through ethtool.
Signed-off-by: Catalin Popescu <catalin.popescu@leica-geosystems.com>
---
drivers/net/phy/dp83822.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/phy/dp83822.c b/drivers/net/phy/dp83822.c
index 30f2616ab1c2..ba320dc3df98 100644
--- a/drivers/net/phy/dp83822.c
+++ b/drivers/net/phy/dp83822.c
@@ -528,7 +528,7 @@ static int dp83826_config_init(struct phy_device *phydev)
return ret;
}
- return 0;
+ return dp8382x_disable_wol(phydev);
}
static int dp8382x_config_init(struct phy_device *phydev)
base-commit: 33e1d31873f87d119e5120b88cd350efa68ef276
--
2.34.1
next reply other threads:[~2024-02-23 14:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-23 14:31 Catalin Popescu [this message]
2024-02-26 15:44 ` [PATCH] net: phy: dp83826: disable WOL at init Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240223143127.1942129-1-catalin.popescu@leica-geosystems.com \
--to=catalin.popescu@leica-geosystems.com \
--cc=andrew@lunn.ch \
--cc=bsp-development.geo@leica-geosystems.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=m.felsch@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).