* [PATCH] net: phy: dp83826: disable WOL at init
@ 2024-02-23 14:31 Catalin Popescu
2024-02-26 15:44 ` Andrew Lunn
0 siblings, 1 reply; 2+ messages in thread
From: Catalin Popescu @ 2024-02-23 14:31 UTC (permalink / raw)
To: andrew, hkallweit1, linux, davem, edumazet, kuba, pabeni
Cc: netdev, linux-kernel, bsp-development.geo, m.felsch, Catalin Popescu
Commit d1d77120bc28 ("net: phy: dp83826: support TX data voltage tuning")
introduced a regression in that WOL is not disabled by default for DP83826.
WOL should normally be enabled through ethtool.
Signed-off-by: Catalin Popescu <catalin.popescu@leica-geosystems.com>
---
drivers/net/phy/dp83822.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/phy/dp83822.c b/drivers/net/phy/dp83822.c
index 30f2616ab1c2..ba320dc3df98 100644
--- a/drivers/net/phy/dp83822.c
+++ b/drivers/net/phy/dp83822.c
@@ -528,7 +528,7 @@ static int dp83826_config_init(struct phy_device *phydev)
return ret;
}
- return 0;
+ return dp8382x_disable_wol(phydev);
}
static int dp8382x_config_init(struct phy_device *phydev)
base-commit: 33e1d31873f87d119e5120b88cd350efa68ef276
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net: phy: dp83826: disable WOL at init
2024-02-23 14:31 [PATCH] net: phy: dp83826: disable WOL at init Catalin Popescu
@ 2024-02-26 15:44 ` Andrew Lunn
0 siblings, 0 replies; 2+ messages in thread
From: Andrew Lunn @ 2024-02-26 15:44 UTC (permalink / raw)
To: Catalin Popescu
Cc: hkallweit1, linux, davem, edumazet, kuba, pabeni, netdev,
linux-kernel, bsp-development.geo, m.felsch
On Fri, Feb 23, 2024 at 03:31:27PM +0100, Catalin Popescu wrote:
> Commit d1d77120bc28 ("net: phy: dp83826: support TX data voltage tuning")
> introduced a regression in that WOL is not disabled by default for DP83826.
> WOL should normally be enabled through ethtool.
>
> Signed-off-by: Catalin Popescu <catalin.popescu@leica-geosystems.com>
d1d77120bc28 ("net: phy: dp83826: support TX data voltage tuning") is
only in net-next? So you should set the patch subject to
net-next. See:
https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html#netdev-faq
Please also add a Fixes tag.
The change itself looks O.K.
Andrew
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-02-26 15:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-23 14:31 [PATCH] net: phy: dp83826: disable WOL at init Catalin Popescu
2024-02-26 15:44 ` Andrew Lunn
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).