From: "Arınç ÜNAL via B4 Relay" <devnull+arinc.unal.arinc9.com@kernel.org>
To: Daniel Golle <daniel@makrotopia.org>,
DENG Qingfang <dqfext@gmail.com>,
Sean Wang <sean.wang@mediatek.com>, Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Russell King <linux@armlinux.org.uk>
Cc: mithat.guner@xeront.com, erkin.bozoglu@xeront.com,
"Bartel Eerdekens" <bartel.eerdekens@constell8.be>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
"Arınç ÜNAL" <arinc.unal@arinc9.com>
Subject: [PATCH net-next v3 3/9] net: dsa: mt7530: do not use SW_PHY_RST to reset MT7531 switch
Date: Fri, 01 Mar 2024 12:42:59 +0200 [thread overview]
Message-ID: <20240301-for-netnext-mt7530-improvements-3-v3-3-449f4f166454@arinc9.com> (raw)
In-Reply-To: <20240301-for-netnext-mt7530-improvements-3-v3-0-449f4f166454@arinc9.com>
From: Arınç ÜNAL <arinc.unal@arinc9.com>
According to the document MT7531 Reference Manual for Development Board
v1.0, the SW_PHY_RST bit on the SYS_CTRL register doesn't exist for
MT7531. This is likely why forcing link down on all ports is necessary for
MT7531.
Therefore, do not set SW_PHY_RST on mt7531_setup().
Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com>
---
drivers/net/dsa/mt7530.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/net/dsa/mt7530.c b/drivers/net/dsa/mt7530.c
index 5cfd303b773f..296711fd5c43 100644
--- a/drivers/net/dsa/mt7530.c
+++ b/drivers/net/dsa/mt7530.c
@@ -2451,14 +2451,12 @@ mt7531_setup(struct dsa_switch *ds)
val = mt7530_read(priv, MT7531_TOP_SIG_SR);
priv->p5_sgmii = !!(val & PAD_DUAL_SGMII_EN);
- /* all MACs must be forced link-down before sw reset */
+ /* Force link down on all ports before internal reset */
for (i = 0; i < MT7530_NUM_PORTS; i++)
mt7530_write(priv, MT7530_PMCR_P(i), MT7531_FORCE_LNK);
/* Reset the switch through internal reset */
- mt7530_write(priv, MT7530_SYS_CTRL,
- SYS_CTRL_PHY_RST | SYS_CTRL_SW_RST |
- SYS_CTRL_REG_RST);
+ mt7530_write(priv, MT7530_SYS_CTRL, SYS_CTRL_SW_RST | SYS_CTRL_REG_RST);
if (!priv->p5_sgmii) {
mt7531_pll_setup(priv);
--
2.40.1
next prev parent reply other threads:[~2024-03-01 10:42 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-01 10:42 [PATCH net-next v3 0/9] MT7530 DSA Subdriver Improvements Act III Arınç ÜNAL via B4 Relay
2024-03-01 10:42 ` [PATCH net-next v3 1/9] net: dsa: mt7530: remove .mac_port_config for MT7988 and make it optional Arınç ÜNAL via B4 Relay
2024-03-01 14:49 ` Russell King (Oracle)
2024-03-01 10:42 ` [PATCH net-next v3 2/9] net: dsa: mt7530: set interrupt register only for MT7530 Arınç ÜNAL via B4 Relay
2024-03-01 10:42 ` Arınç ÜNAL via B4 Relay [this message]
2024-03-01 10:43 ` [PATCH net-next v3 4/9] net: dsa: mt7530: get rid of useless error returns on phylink code path Arınç ÜNAL via B4 Relay
2024-03-01 14:52 ` Russell King (Oracle)
2024-03-01 10:43 ` [PATCH net-next v3 5/9] net: dsa: mt7530: get rid of priv->info->cpu_port_config() Arınç ÜNAL via B4 Relay
2024-03-01 10:43 ` [PATCH net-next v3 6/9] net: dsa: mt7530: get rid of mt753x_mac_config() Arınç ÜNAL via B4 Relay
2024-03-01 10:43 ` [PATCH net-next v3 7/9] net: dsa: mt7530: put initialising PCS devices code back to original order Arınç ÜNAL via B4 Relay
2024-03-01 10:43 ` [PATCH net-next v3 8/9] net: dsa: mt7530: sort link settings ops and force link down on all ports Arınç ÜNAL via B4 Relay
2024-03-01 10:43 ` [PATCH net-next v3 9/9] net: dsa: mt7530: simplify link operations Arınç ÜNAL via B4 Relay
2024-03-05 11:30 ` [PATCH net-next v3 0/9] MT7530 DSA Subdriver Improvements Act III Paolo Abeni
2024-03-05 11:36 ` Russell King (Oracle)
2024-03-05 12:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240301-for-netnext-mt7530-improvements-3-v3-3-449f4f166454@arinc9.com \
--to=devnull+arinc.unal.arinc9.com@kernel.org \
--cc=andrew@lunn.ch \
--cc=angelogioacchino.delregno@collabora.com \
--cc=arinc.unal@arinc9.com \
--cc=bartel.eerdekens@constell8.be \
--cc=daniel@makrotopia.org \
--cc=davem@davemloft.net \
--cc=dqfext@gmail.com \
--cc=edumazet@google.com \
--cc=erkin.bozoglu@xeront.com \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=matthias.bgg@gmail.com \
--cc=mithat.guner@xeront.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=sean.wang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).