From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: arinc.unal@arinc9.com
Cc: Daniel Golle <daniel@makrotopia.org>,
DENG Qingfang <dqfext@gmail.com>,
Sean Wang <sean.wang@mediatek.com>, Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
mithat.guner@xeront.com, erkin.bozoglu@xeront.com,
Bartel Eerdekens <bartel.eerdekens@constell8.be>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH net-next v3 4/9] net: dsa: mt7530: get rid of useless error returns on phylink code path
Date: Fri, 1 Mar 2024 14:52:58 +0000 [thread overview]
Message-ID: <ZeHrykYQd1SWJIN/@shell.armlinux.org.uk> (raw)
In-Reply-To: <20240301-for-netnext-mt7530-improvements-3-v3-4-449f4f166454@arinc9.com>
On Fri, Mar 01, 2024 at 12:43:00PM +0200, Arınç ÜNAL via B4 Relay wrote:
> From: Arınç ÜNAL <arinc.unal@arinc9.com>
>
> Remove error returns on the cases where they are already handled with the
> function the mac_port_get_caps member in mt753x_table points to.
>
> mt7531_mac_config() is also called from mt7531_cpu_port_config() outside of
> phylink but the port and interface modes are already handled there.
>
> Change the functions and the mac_port_config function pointer to void now
> that there're no error returns anymore.
>
> Remove mt753x_is_mac_port() that used to help the said error returns.
>
> On mt7531_mac_config(), switch to if statements to simplify the code.
>
> Remove internal phy cases from mt753x_phylink_mac_config(), there is no
> need to check the interface mode as that's already handled with the
> function the mac_port_get_caps member in mt753x_table points to.
>
> Acked-by: Daniel Golle <daniel@makrotopia.org>
> Tested-by: Daniel Golle <daniel@makrotopia.org>
> Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com>
Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Thanks!
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2024-03-01 14:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-01 10:42 [PATCH net-next v3 0/9] MT7530 DSA Subdriver Improvements Act III Arınç ÜNAL via B4 Relay
2024-03-01 10:42 ` [PATCH net-next v3 1/9] net: dsa: mt7530: remove .mac_port_config for MT7988 and make it optional Arınç ÜNAL via B4 Relay
2024-03-01 14:49 ` Russell King (Oracle)
2024-03-01 10:42 ` [PATCH net-next v3 2/9] net: dsa: mt7530: set interrupt register only for MT7530 Arınç ÜNAL via B4 Relay
2024-03-01 10:42 ` [PATCH net-next v3 3/9] net: dsa: mt7530: do not use SW_PHY_RST to reset MT7531 switch Arınç ÜNAL via B4 Relay
2024-03-01 10:43 ` [PATCH net-next v3 4/9] net: dsa: mt7530: get rid of useless error returns on phylink code path Arınç ÜNAL via B4 Relay
2024-03-01 14:52 ` Russell King (Oracle) [this message]
2024-03-01 10:43 ` [PATCH net-next v3 5/9] net: dsa: mt7530: get rid of priv->info->cpu_port_config() Arınç ÜNAL via B4 Relay
2024-03-01 10:43 ` [PATCH net-next v3 6/9] net: dsa: mt7530: get rid of mt753x_mac_config() Arınç ÜNAL via B4 Relay
2024-03-01 10:43 ` [PATCH net-next v3 7/9] net: dsa: mt7530: put initialising PCS devices code back to original order Arınç ÜNAL via B4 Relay
2024-03-01 10:43 ` [PATCH net-next v3 8/9] net: dsa: mt7530: sort link settings ops and force link down on all ports Arınç ÜNAL via B4 Relay
2024-03-01 10:43 ` [PATCH net-next v3 9/9] net: dsa: mt7530: simplify link operations Arınç ÜNAL via B4 Relay
2024-03-05 11:30 ` [PATCH net-next v3 0/9] MT7530 DSA Subdriver Improvements Act III Paolo Abeni
2024-03-05 11:36 ` Russell King (Oracle)
2024-03-05 12:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZeHrykYQd1SWJIN/@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=angelogioacchino.delregno@collabora.com \
--cc=arinc.unal@arinc9.com \
--cc=bartel.eerdekens@constell8.be \
--cc=daniel@makrotopia.org \
--cc=davem@davemloft.net \
--cc=dqfext@gmail.com \
--cc=edumazet@google.com \
--cc=erkin.bozoglu@xeront.com \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mithat.guner@xeront.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=sean.wang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).