From: Jan Kiszka <jan.kiszka@siemens.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Alexandre Torgue <alexandre.torgue@st.com>,
David Miller <davem@davemloft.net>,
Linux Netdev List <netdev@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Su Bao Cheng <baocheng.su@siemens.com>
Subject: Re: [PATCH] stmmac: pci: Adjust IOT2000 matching
Date: Fri, 26 Apr 2019 17:36:44 +0200 [thread overview]
Message-ID: <28d2856b-7fe5-1b42-e1bc-1c3601265dd2@siemens.com> (raw)
In-Reply-To: <CAHp75VddTO890=DMa8pQANBGMMaDtCGgVb_cxCHc_Y1hxNTHwg@mail.gmail.com>
On 26.04.19 16:34, Andy Shevchenko wrote:
> On Thu, Apr 18, 2019 at 12:15 PM Jan Kiszka <jan.kiszka@siemens.com> wrote:
>>
>> From: Su Bao Cheng <baocheng.su@siemens.com>
>>
>> Since there are more IOT2040 variants with identical hardware but
>> different asset tags, the asset tag matching should be adjusted to
>> support them.
>>
>> For the board name "SIMATIC IOT2000", currently there are 2 types of
>> hardware, IOT2020 and IOT2040. The IOT2020 is identified by its unique
>> asset tag. Match on it first. If we then match on the board name only,
>> we will catch all IOT2040 variants. In the future there will be no other
>> devices with the "SIMATIC IOT2000" DMI board name but different
>> hardware.
>>
>> Signed-off-by: Su Bao Cheng <baocheng.su@siemens.com>
>> Reviewed-by: Jan Kiszka <jan.kiszka@siemens.com>
>
>> + /*
>
>> + * There are 2 types of SIMATIC IOT2000: IOT20202 and IOT2040.
>
> 20202 ?
2020...
I can send a fix-up or v2, whatever is preferred.
Thanks,
Jan
>
>> + * The asset tag "6ES7647-0AA00-0YA2" is only for IOT2020 which
>> + * has only one pci network device while other asset tags are
>> + * for IOT2040 which has two.
>> + */
>
>
>
--
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux
next prev parent reply other threads:[~2019-04-26 15:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-18 9:14 [PATCH] stmmac: pci: Adjust IOT2000 matching Jan Kiszka
2019-04-18 17:43 ` David Miller
2019-04-18 18:24 ` Jan Kiszka
2019-04-18 18:48 ` David Miller
2019-04-26 14:34 ` Andy Shevchenko
2019-04-26 15:36 ` Jan Kiszka [this message]
2019-04-26 17:13 ` Andy Shevchenko
2019-04-26 17:14 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=28d2856b-7fe5-1b42-e1bc-1c3601265dd2@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=alexandre.torgue@st.com \
--cc=andy.shevchenko@gmail.com \
--cc=baocheng.su@siemens.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).