From: Jan Kiszka <jan.kiszka@siemens.com>
To: David Miller <davem@davemloft.net>
Cc: peppe.cavallaro@st.com, alexandre.torgue@st.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
baocheng.su@siemens.com, andy.shevchenko@gmail.com
Subject: Re: [PATCH] stmmac: pci: Adjust IOT2000 matching
Date: Thu, 18 Apr 2019 20:24:28 +0200 [thread overview]
Message-ID: <642a6059-8a28-b995-919f-68d03200ee11@siemens.com> (raw)
In-Reply-To: <20190418.104344.957038152341042514.davem@davemloft.net>
On 18.04.19 19:43, David Miller wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
> Date: Thu, 18 Apr 2019 11:14:56 +0200
>
>> @@ -170,8 +176,6 @@ static const struct dmi_system_id quark_pci_dmi[] = {
>> {
>> .matches = {
>> DMI_EXACT_MATCH(DMI_BOARD_NAME, "SIMATIC IOT2000"),
>> - DMI_EXACT_MATCH(DMI_BOARD_ASSET_TAG,
>> - "6ES7647-0AA00-1YA2"),
>> },
>> .driver_data = (void *)&iot2040_stmmac_dmi_data,
>
> So really, every IOT2000 that doesn't have the IOT2020 asset tag will be
> a 2040? Forever?
>
Yes, seriously. The next version won't have all that DMI and ACPI stuff. And if
there will ever be a version with that again, it will not be labeled "IOT2000"
via the board name entry. And it will have more robust hardware discovery as
well. Lesson(s) learned, in fact not only for this product series.
Jan
--
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux
next prev parent reply other threads:[~2019-04-18 18:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-18 9:14 [PATCH] stmmac: pci: Adjust IOT2000 matching Jan Kiszka
2019-04-18 17:43 ` David Miller
2019-04-18 18:24 ` Jan Kiszka [this message]
2019-04-18 18:48 ` David Miller
2019-04-26 14:34 ` Andy Shevchenko
2019-04-26 15:36 ` Jan Kiszka
2019-04-26 17:13 ` Andy Shevchenko
2019-04-26 17:14 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=642a6059-8a28-b995-919f-68d03200ee11@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=alexandre.torgue@st.com \
--cc=andy.shevchenko@gmail.com \
--cc=baocheng.su@siemens.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).