From: Bert Karwatzki <spasswolf@web.de>
To: Simon Horman <simon.horman@corigine.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>,
elder@linaro.org, netdev@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] net: ipa: Use the correct value for IPA_STATUS_SIZE
Date: Tue, 30 May 2023 11:10:19 +0200 [thread overview]
Message-ID: <2b91165f667d3896a0aded39830905f62f725815.camel@web.de> (raw)
In-Reply-To: <ZHWhEiWtEC9VKOS1@corigine.com>
Am Dienstag, dem 30.05.2023 um 09:09 +0200 schrieb Simon Horman:
> On Sat, May 27, 2023 at 10:46:25PM +0200, Bert Karwatzki wrote:
> > commit b8dc7d0eea5a7709bb534f1b3ca70d2d7de0b42c introduced
> > IPA_STATUS_SIZE as a replacement for the size of the removed struct
> > ipa_status. sizeof(struct ipa_status) was sizeof(__le32[8]), use this
> > as IPA_STATUS_SIZE.
> >
> > > From 0623148733819bb5d3648b1ed404d57c8b6b31d8 Mon Sep 17 00:00:00 2001
> > From: Bert Karwatzki <spasswolf@web.de>
> > Date: Sat, 27 May 2023 22:16:52 +0200
> > Subject: [PATCH] Use the correct value for IPA_STATUS_SIZE.
> > IPA_STATUS_SIZE
> > was introduced in commit b8dc7d0eea5a7709bb534f1b3ca70d2d7de0b42c as a
> > replacment for the size of the removed struct ipa_status which had
> > size =
> > sizeof(__le32[8]).
> >
> > Signed-off-by: Bert Karwatzki <spasswolf@web.de>
>
> Hi Bert,
>
> As well as the feedback provided by Jakub elsewhere in this
> thread I think it would be useful to CC the author of the above mentioned
> commit, Alex Elder <elder@linaro.org>. I have CCed him on this email.
> Please consider doing likewise when you post v2.
>
> FWIIW, I did take a look.
> And I do agree with your maths: struct ipa_status was 32 (= 8 x 4) bytes long.
>
> > ---
> > drivers/net/ipa/ipa_endpoint.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/ipa/ipa_endpoint.c
> > b/drivers/net/ipa/ipa_endpoint.c
> > index 2ee80ed140b7..afa1d56d9095 100644
> > --- a/drivers/net/ipa/ipa_endpoint.c
> > +++ b/drivers/net/ipa/ipa_endpoint.c
> > @@ -119,7 +119,7 @@ enum ipa_status_field_id {
> > };
> >
> > /* Size in bytes of an IPA packet status structure */
> > -#define IPA_STATUS_SIZE sizeof(__le32[4])
> > +#define IPA_STATUS_SIZE sizeof(__le32[8])
> >
> > /* IPA status structure decoder; looks up field values for a structure
> > */
> > static u32 ipa_status_extract(struct ipa *ipa, const void *data,
> > --
> > 2.40.1
> >
> > Bert Karwatzki
Here is v2 of the patch, the first one was garbled by the linebreak setting of
evolution.
From: Bert Karwatzki <spasswolf@web.de>
Date: Tue, 30 May 2023 10:55:55 +0200
Subject: [PATCH] IPA_STATUS_SIZE was introduced in commit b8dc7d0eea5a as a
replacement for the size of the removed struct ipa_status of size
sizeof(__le32[8]). Use this value as IPA_STATUS_SIZE.
Signed-off-by: Bert Karwatzki <spasswolf@web.de>
---
drivers/net/ipa/ipa_endpoint.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ipa/ipa_endpoint.c b/drivers/net/ipa/ipa_endpoint.c
index 2ee80ed140b7..afa1d56d9095 100644
--- a/drivers/net/ipa/ipa_endpoint.c
+++ b/drivers/net/ipa/ipa_endpoint.c
@@ -119,7 +119,7 @@ enum ipa_status_field_id {
};
/* Size in bytes of an IPA packet status structure */
-#define IPA_STATUS_SIZE sizeof(__le32[4])
+#define IPA_STATUS_SIZE sizeof(__le32[8])
/* IPA status structure decoder; looks up field values for a structure */
static u32 ipa_status_extract(struct ipa *ipa, const void *data,
--
2.40.1
next prev parent reply other threads:[~2023-05-30 9:10 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-27 20:46 [PATCH net] net: ipa: Use the correct value for IPA_STATUS_SIZE Bert Karwatzki
2023-05-30 5:10 ` Jakub Kicinski
2023-05-30 7:09 ` Simon Horman
2023-05-30 9:10 ` Bert Karwatzki [this message]
2023-05-30 12:29 ` Alex Elder
2023-05-30 18:36 ` Bert Karwatzki
2023-05-30 19:04 ` Alex Elder
2023-05-30 23:25 ` [PATCH net v2] " Bert Karwatzki
2023-05-30 23:43 ` Alex Elder
2023-05-31 0:33 ` Jakub Kicinski
2023-05-31 1:57 ` Alex Elder
2023-05-31 10:36 ` [PATCH net v3] net: ipa: Use " Bert Karwatzki
2023-05-31 22:07 ` Simon Horman
2023-06-01 11:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2b91165f667d3896a0aded39830905f62f725815.camel@web.de \
--to=spasswolf@web.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=elder@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=simon.horman@corigine.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).