From: Simon Horman <simon.horman@corigine.com>
To: Bert Karwatzki <spasswolf@web.de>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, elder@kernel.org, netdev@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net v3] net: ipa: Use correct value for IPA_STATUS_SIZE
Date: Thu, 1 Jun 2023 00:07:39 +0200 [thread overview]
Message-ID: <ZHfFK0+lgv2pSkFb@corigine.com> (raw)
In-Reply-To: <20230531103618.102608-1-spasswolf@web.de>
On Wed, May 31, 2023 at 12:36:19PM +0200, Bert Karwatzki wrote:
> IPA_STATUS_SIZE was introduced in commit b8dc7d0eea5a as a replacement
> for the size of the removed struct ipa_status which had size
> sizeof(__le32[8]). Use this value as IPA_STATUS_SIZE.
>
> Fixes: b8dc7d0eea5a ("net: ipa: stop using sizeof(status)")
> Signed-off-by: Bert Karwatzki <spasswolf@web.de>
> ---
> drivers/net/ipa/ipa_endpoint.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ipa/ipa_endpoint.c b/drivers/net/ipa/ipa_endpoint.c
> index 2ee80ed140b7..afa1d56d9095 100644
> --- a/drivers/net/ipa/ipa_endpoint.c
> +++ b/drivers/net/ipa/ipa_endpoint.c
> @@ -119,7 +119,7 @@ enum ipa_status_field_id {
> };
>
> /* Size in bytes of an IPA packet status structure */
> -#define IPA_STATUS_SIZE sizeof(__le32[4])
> +#define IPA_STATUS_SIZE sizeof(__le32[8])
>
> /* IPA status structure decoder; looks up field values for a structure */
> static u32 ipa_status_extract(struct ipa *ipa, const void *data,
> --
> 2.40.1
>
> As none of you seem to be in Europe, I'll do another attempt, this time
> with git send-email.
This looks good to me.
Reviewed-by: Simon Horman <simon.horman@corigine.com>
(somewhere in Europe)
next prev parent reply other threads:[~2023-05-31 22:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-27 20:46 [PATCH net] net: ipa: Use the correct value for IPA_STATUS_SIZE Bert Karwatzki
2023-05-30 5:10 ` Jakub Kicinski
2023-05-30 7:09 ` Simon Horman
2023-05-30 9:10 ` Bert Karwatzki
2023-05-30 12:29 ` Alex Elder
2023-05-30 18:36 ` Bert Karwatzki
2023-05-30 19:04 ` Alex Elder
2023-05-30 23:25 ` [PATCH net v2] " Bert Karwatzki
2023-05-30 23:43 ` Alex Elder
2023-05-31 0:33 ` Jakub Kicinski
2023-05-31 1:57 ` Alex Elder
2023-05-31 10:36 ` [PATCH net v3] net: ipa: Use " Bert Karwatzki
2023-05-31 22:07 ` Simon Horman [this message]
2023-06-01 11:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZHfFK0+lgv2pSkFb@corigine.com \
--to=simon.horman@corigine.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=elder@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=spasswolf@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).