* New ethtool sub-feature and ethtool-netlink
@ 2019-03-21 21:23 Heiner Kallweit
2019-03-22 7:38 ` Michal Kubecek
0 siblings, 1 reply; 3+ messages in thread
From: Heiner Kallweit @ 2019-03-21 21:23 UTC (permalink / raw)
To: John Linville, Michal Kubecek
Cc: netdev, Linux Kernel Mailing List, Andrew Lunn, Florian Fainelli
Hi Michal / John,
I have an ethtool extension in the pipe that adds one more PHY tunable
sub-feature (for Fast Link Down support). Are smaller extensions still
ok for ethtool, or IOW: When do you think is ethtool-netlink going to
be stable enough so that other developers can add features?
Heiner
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: New ethtool sub-feature and ethtool-netlink
2019-03-21 21:23 New ethtool sub-feature and ethtool-netlink Heiner Kallweit
@ 2019-03-22 7:38 ` Michal Kubecek
2019-03-23 14:32 ` Heiner Kallweit
0 siblings, 1 reply; 3+ messages in thread
From: Michal Kubecek @ 2019-03-22 7:38 UTC (permalink / raw)
To: Heiner Kallweit
Cc: John Linville, netdev, Linux Kernel Mailing List, Andrew Lunn,
Florian Fainelli
On Thu, Mar 21, 2019 at 10:23:36PM +0100, Heiner Kallweit wrote:
> I have an ethtool extension in the pipe that adds one more PHY tunable
> sub-feature (for Fast Link Down support). Are smaller extensions still
> ok for ethtool,
Adding a new PHY tunable is IMHO minor change which doesn't need to wait
for the netlink interface. It's a bit more complicated due to the way
tunables (and PHY tunables) are implemented in ioctl API (which requires
both sides to have a list of tunables and their interpretation) but that
is one of the things I would like to change. :-)
After all, I don't have support for (PHY) tunables in the netlink API
yet (not even in the part which hasn't been submitted yet).
> or IOW: When do you think is ethtool-netlink going to be stable enough
> so that other developers can add features?
I would say that once it reaches mainline and userspace starts to use
it, it will have to be stable (due to "Linus' first commandment"). When
that is going to be, that depends on how the review is going, it's hard
to guess.
Michal
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: New ethtool sub-feature and ethtool-netlink
2019-03-22 7:38 ` Michal Kubecek
@ 2019-03-23 14:32 ` Heiner Kallweit
0 siblings, 0 replies; 3+ messages in thread
From: Heiner Kallweit @ 2019-03-23 14:32 UTC (permalink / raw)
To: Michal Kubecek
Cc: John Linville, netdev, Linux Kernel Mailing List, Andrew Lunn,
Florian Fainelli
On 22.03.2019 08:38, Michal Kubecek wrote:
> On Thu, Mar 21, 2019 at 10:23:36PM +0100, Heiner Kallweit wrote:
>> I have an ethtool extension in the pipe that adds one more PHY tunable
>> sub-feature (for Fast Link Down support). Are smaller extensions still
>> ok for ethtool,
>
> Adding a new PHY tunable is IMHO minor change which doesn't need to wait
> for the netlink interface. It's a bit more complicated due to the way
> tunables (and PHY tunables) are implemented in ioctl API (which requires
> both sides to have a list of tunables and their interpretation) but that
> is one of the things I would like to change. :-)
>
> After all, I don't have support for (PHY) tunables in the netlink API
> yet (not even in the part which hasn't been submitted yet).
>
Thanks a lot, good to know. I think I can submit the new PHY tunable
next week.
>> or IOW: When do you think is ethtool-netlink going to be stable enough
>> so that other developers can add features?
>
> I would say that once it reaches mainline and userspace starts to use
> it, it will have to be stable (due to "Linus' first commandment"). When
> that is going to be, that depends on how the review is going, it's hard
> to guess.
>
> Michal
>
Heiner
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-03-23 14:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-21 21:23 New ethtool sub-feature and ethtool-netlink Heiner Kallweit
2019-03-22 7:38 ` Michal Kubecek
2019-03-23 14:32 ` Heiner Kallweit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).