* [PATCH 6/8] net: xilinx_emaclite: remove unnecessary dev_set_drvdata()
@ 2013-08-21 7:02 Libo Chen
2013-08-21 7:21 ` Michal Simek
0 siblings, 1 reply; 2+ messages in thread
From: Libo Chen @ 2013-08-21 7:02 UTC (permalink / raw)
To: davem
Cc: michal.simek, renner, gregkh, netdev, linux-kernel, lizefan, libo.chen
Unnecessary dev_set_drvdata() is removed, because the driver core
clears the driver data to NULL after device_release or on probe failure.
Signed-off-by: Libo Chen <libo.chen@huawei.com>
---
drivers/net/ethernet/xilinx/xilinx_emaclite.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/net/ethernet/xilinx/xilinx_emaclite.c b/drivers/net/ethernet/xilinx/xilinx_emaclite.c
index 7c1ccbc..4c619ea 100644
--- a/drivers/net/ethernet/xilinx/xilinx_emaclite.c
+++ b/drivers/net/ethernet/xilinx/xilinx_emaclite.c
@@ -1249,7 +1249,6 @@ static int xemaclite_of_remove(struct platform_device *of_dev)
lp->phy_node = NULL;
xemaclite_remove_ndev(ndev, of_dev);
- dev_set_drvdata(dev, NULL);
return 0;
}
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 6/8] net: xilinx_emaclite: remove unnecessary dev_set_drvdata()
2013-08-21 7:02 [PATCH 6/8] net: xilinx_emaclite: remove unnecessary dev_set_drvdata() Libo Chen
@ 2013-08-21 7:21 ` Michal Simek
0 siblings, 0 replies; 2+ messages in thread
From: Michal Simek @ 2013-08-21 7:21 UTC (permalink / raw)
To: Libo Chen
Cc: davem, michal.simek, renner, gregkh, netdev, linux-kernel, lizefan
[-- Attachment #1: Type: text/plain, Size: 1216 bytes --]
On 08/21/2013 09:02 AM, Libo Chen wrote:
> Unnecessary dev_set_drvdata() is removed, because the driver core
> clears the driver data to NULL after device_release or on probe failure.
>
> Signed-off-by: Libo Chen <libo.chen@huawei.com>
> ---
> drivers/net/ethernet/xilinx/xilinx_emaclite.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/ethernet/xilinx/xilinx_emaclite.c b/drivers/net/ethernet/xilinx/xilinx_emaclite.c
> index 7c1ccbc..4c619ea 100644
> --- a/drivers/net/ethernet/xilinx/xilinx_emaclite.c
> +++ b/drivers/net/ethernet/xilinx/xilinx_emaclite.c
> @@ -1249,7 +1249,6 @@ static int xemaclite_of_remove(struct platform_device *of_dev)
> lp->phy_node = NULL;
>
> xemaclite_remove_ndev(ndev, of_dev);
> - dev_set_drvdata(dev, NULL);
>
> return 0;
> }
>
Acked-by: Michal Simek <monstr@monstr.eu>
Thanks,
Michal
--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 263 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-08-21 7:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-08-21 7:02 [PATCH 6/8] net: xilinx_emaclite: remove unnecessary dev_set_drvdata() Libo Chen
2013-08-21 7:21 ` Michal Simek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).