* [PATCH net 0/3] bonding: add port protection for bond_3ad_xxx_change()
@ 2013-12-13 9:29 Ding Tianhong
2013-12-13 22:26 ` Jay Vosburgh
0 siblings, 1 reply; 3+ messages in thread
From: Ding Tianhong @ 2013-12-13 9:29 UTC (permalink / raw)
To: Jay Vosburgh, Andy Gospodarek, David S. Miller, Veaceslav Falico, Netdev
Jay Vosburgh said that the bond_3ad_adapter_speed_changed and
bond_3ad_adapter_duplex_changed is called with RTNL only, and
the functions will modify the port's information with no further
locking, they will not mutex against bond state machine and
incoming LACPDU which do not hold RTNL, So I add port lock to
protect the port information.
But they are not critical bugs, they exist since day one, and till
now they have never been hit and reported, because change for speed
and duplex is very rare, and will not occur critical problem.
The comments in the function is very old, cleanup the comments together.
Ding Tianhong (3):
bonding: protect port for bond_3ad_adapter_speed_changed()
bonding: protect port for bond_3ad_adapter_duplex_changed()
bonding: protect port for bond_3ad_handle_link_change()
drivers/net/bonding/bond_3ad.c | 45 +++++++++++++++++++++++++++++++-----------
1 file changed, 33 insertions(+), 12 deletions(-)
--
1.8.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net 0/3] bonding: add port protection for bond_3ad_xxx_change()
2013-12-13 9:29 [PATCH net 0/3] bonding: add port protection for bond_3ad_xxx_change() Ding Tianhong
@ 2013-12-13 22:26 ` Jay Vosburgh
2013-12-18 21:53 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Jay Vosburgh @ 2013-12-13 22:26 UTC (permalink / raw)
To: Ding Tianhong; +Cc: Andy Gospodarek, David S. Miller, Veaceslav Falico, Netdev
Ding Tianhong <dingtianhong@huawei.com> wrote:
>Jay Vosburgh said that the bond_3ad_adapter_speed_changed and
>bond_3ad_adapter_duplex_changed is called with RTNL only, and
>the functions will modify the port's information with no further
>locking, they will not mutex against bond state machine and
>incoming LACPDU which do not hold RTNL, So I add port lock to
>protect the port information.
>
>But they are not critical bugs, they exist since day one, and till
>now they have never been hit and reported, because change for speed
>and duplex is very rare, and will not occur critical problem.
>
>The comments in the function is very old, cleanup the comments together.
For entire series:
Signed-off-by: Jay Vosburgh <fubar@us.ibm.com>
-J
>Ding Tianhong (3):
> bonding: protect port for bond_3ad_adapter_speed_changed()
> bonding: protect port for bond_3ad_adapter_duplex_changed()
> bonding: protect port for bond_3ad_handle_link_change()
>
> drivers/net/bonding/bond_3ad.c | 45 +++++++++++++++++++++++++++++++-----------
> 1 file changed, 33 insertions(+), 12 deletions(-)
>
>--
>1.8.0
---
-Jay Vosburgh, IBM Linux Technology Center, fubar@us.ibm.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net 0/3] bonding: add port protection for bond_3ad_xxx_change()
2013-12-13 22:26 ` Jay Vosburgh
@ 2013-12-18 21:53 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2013-12-18 21:53 UTC (permalink / raw)
To: fubar; +Cc: dingtianhong, andy, vfalico, netdev
From: Jay Vosburgh <fubar@us.ibm.com>
Date: Fri, 13 Dec 2013 14:26:02 -0800
> Ding Tianhong <dingtianhong@huawei.com> wrote:
>
>>Jay Vosburgh said that the bond_3ad_adapter_speed_changed and
>>bond_3ad_adapter_duplex_changed is called with RTNL only, and
>>the functions will modify the port's information with no further
>>locking, they will not mutex against bond state machine and
>>incoming LACPDU which do not hold RTNL, So I add port lock to
>>protect the port information.
>>
>>But they are not critical bugs, they exist since day one, and till
>>now they have never been hit and reported, because change for speed
>>and duplex is very rare, and will not occur critical problem.
>>
>>The comments in the function is very old, cleanup the comments together.
>
> For entire series:
>
> Signed-off-by: Jay Vosburgh <fubar@us.ibm.com>
Series applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-12-18 21:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-12-13 9:29 [PATCH net 0/3] bonding: add port protection for bond_3ad_xxx_change() Ding Tianhong
2013-12-13 22:26 ` Jay Vosburgh
2013-12-18 21:53 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).